From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3113823A98E for ; Fri, 17 Oct 2025 20:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731273; cv=none; b=NZPPzIAM1rgiFENThpycKK71LPEwtlCCXmIYbbx8fYfviAYhtD95VLFYHaxNdabMnBy8+YVSDr+zezrhQQhu7XA3Yx2O1vHCHs9ojQlY+WgjwxVarvh1LbaIHGZ7u8wjbUVpDsC2MU4RGlye0vBO/Gwfx1xu/J3b17FJYt/0Zbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731273; c=relaxed/simple; bh=K2ZJWWVPxcS3Zb+xMa4QB2/1GTr41KU5/gINSseGrdA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mJ11ReBgQqpR1W0lMoJqmnEkwDMkS2/Ww7cXBqzNYOeROvzZJr0gz2a8OHW1ORfbn0DEQDWeMTzdVqSD0E3e7HeOZ2LdnpyxTUFqjXLwOD9MQLB+pBiPTPGs/ELwmG0cGmB19aKd35r/UVndRag8Dc1rtaXbZqhmOaWsDauDC0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bXC6HAQl; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bXC6HAQl" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-363f137bbf8so19704431fa.2 for ; Fri, 17 Oct 2025 13:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760731270; x=1761336070; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZvamalkucLTXF0UtA58TBlyJrhax3HxRIT0v5R1YbAI=; b=bXC6HAQlCEI2dbevg0C4d1K4kgdW6/cSzS0y3dR1/ieHdkFq5QtxOAAEOpqvO4UtcJ U12jQRuyu8/p4RvrQxJCk85Ze3b/hPPyExOMTNjhk5Rl7KPZ0SULlHz2ivd8rz2m9IVl opyN28g53EtRTqjbpL6+/OsyWkChNkn50I3zDMbNtevJLvra7iSEJ/xmerUoURrSsBBp htO7X0w6LhRRoi26YUVv21ydFJvS1eFWoZBNpHrNIJyVO9umC+++Hg1oqaomQhI5vC5j EZtY58NdHAGydXX8O0YqXMBahVuyhe8UBEk/bTv8XdFEZJ5UniU3R0HKdCOHlkZFiuPP jlZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760731270; x=1761336070; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZvamalkucLTXF0UtA58TBlyJrhax3HxRIT0v5R1YbAI=; b=arvmeRHZaVgsbq3lCHVaIk20AZGLI7uTbXubLoiFm4JAB/TQUp6EiTBNBKQWz+orVV VyqtNPvCslJSyFa2+WETcZnXBgRSO8oaXcb27tYHYzfp8zSQKA8huZnGGAK1MVGHL3WN 3QN/jWpFlkoJZcfaIffJ5ktQAGbFO8EjrteKoIWcDrYcbhvmz75O7QbhPbb6cU2FfD0i Qlj2Zpk8ibT5szOSGV3jKefXlezVfRyLVFkjLNXGM0aKF4m6A53YaRM/FUNDOv2Ge+SF u4IkI4658HWTjh3fawZ2r3NtAH9qpxlcla5XCGSdDcEJCW9KTsERKxvwP9y6DsIk+Ows biEQ== X-Gm-Message-State: AOJu0YwdcJl4R5xbXav1Z3JzHWZyMa928hRmWI5T6BpU7YlDO4kvHi9t 5iIttTMopWziIaaOtKc6WC8TlD0kvYCP20iJMp7bL7MtjDXVqzcY2bCc X-Gm-Gg: ASbGncvfA7IvtFvEvc591mzIc2lfhQCiYE2JZQL1kwxJ0oCUy0sCNDHpYgcgoOyEs4i jyE672wMb0UOB/VvXCGHvX+Av+CfumCp/zw2An809EJunPj+a40n4eBVyko6G4qj2iUP1kIbfbv 8YqfpsbGYN6+PJuNDh7GNuFnY2PeX+JQ7/KNrbdvyImTCF3sKFwop05VbH2lzZNo3cnURqfWVNG Fa36US+idEcK+OQYq3rRnbowBVUwEakMbftIcyevAFc6UTO5tsdtvUd1l7dIloHXbOSwAO8j/y2 Hj3r6UirAx/4iuEpiC/1o4g1D1nnnVpiZLKzcZcCzNCp0i2p8nyyfR0qmxq/6NV7pXtxskqIV8f /4p4C+TQmdS3GtDp1o4iHqEY+bc2TwdzwY7gEvhY2A0Z03qjdV4vhomfyaV0rB6e8bJll48ol3V u0NXbndp/QDRQG0x5sLVHvS7Tu02XuXN6EnstkeWeZWknRQqMcQ0ONQXRkBHbgPQ== X-Google-Smtp-Source: AGHT+IGGkPzUg9+WLDnfzSVIMAOLQOKXgwa2ttL1tbW7RtbDwguoGHJ6HNdyipMTINLcvQ/30wWafQ== X-Received: by 2002:a2e:a583:0:b0:35f:246:a751 with SMTP id 38308e7fff4ca-3779781d39emr17282741fa.5.1760731270001; Fri, 17 Oct 2025 13:01:10 -0700 (PDT) Received: from [192.168.1.244] (public-nat-13.vpngate.v4.open.ad.jp. [219.100.37.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-377a921d99bsm1580861fa.22.2025.10.17.13.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 13:01:09 -0700 (PDT) From: Vladimir Lypak Date: Fri, 17 Oct 2025 19:58:39 +0000 Subject: [PATCH 5/6] drm/msm/dpu: Require linear modifier for writeback framebuffers Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251017-b4-dpu-fixes-v1-5-40ce5993eeb6@gmail.com> References: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Kalyan Thota , Vinod Polimera , Konrad Dybcio , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vladimir Lypak X-Mailer: b4 0.14.2 UBWC-related register configuration for writeback is not implemented in the driver yet but there aren't any checks for non-linear modifiers in atomic_check. Thus when compressed framebuffer is attached to writeback connector it will be filled with linear image data. This patch forbids non-linear modifiers for writeback framebuffers until UBWC support for writeback is properly implemented. Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c") Signed-off-by: Vladimir Lypak --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c index cd73468e369a93c50303db2a7d4499bcb17be5d1..7545c0293efbd8f7eb34a4ac56f616b7cadae1c0 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -72,6 +72,9 @@ static int dpu_wb_conn_atomic_check(struct drm_connector *connector, DPU_ERROR("invalid fb w=%d, maxlinewidth=%u\n", fb->width, dpu_wb_conn->maxlinewidth); return -EINVAL; + } else if (fb->modifier != DRM_FORMAT_MOD_LINEAR) { + DPU_ERROR("unsupported fb modifier:%#llx\n", fb->modifier); + return -EINVAL; } return drm_atomic_helper_check_wb_connector_state(conn_state->connector, conn_state->state); -- 2.51.0