Re: [PATCH] accel/qaic: Add support for PM callbacks

[kernel test robot <lkp@intel.com>]

Hi Youssef,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on drm-tip/drm-tip linus/master v6.18-rc2 next-20251023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Youssef-Samir/accel-qaic-Add-support-for-PM-callbacks/20251023-044052
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20251022204005.3888195-1-youssef.abdulrahman%40oss.qualcomm.com
patch subject: [PATCH] accel/qaic: Add support for PM callbacks
config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20251023/202510231820.AMln6kY3-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/202510231820.AMln6kY3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510231820.AMln6kY3-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/accel/qaic/qaic_drv.c:724:12: warning: 'qaic_pm_resume' defined but not used [-Wunused-function]
     724 | static int qaic_pm_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~
>> drivers/accel/qaic/qaic_drv.c:703:12: warning: 'qaic_pm_suspend' defined but not used [-Wunused-function]
     703 | static int qaic_pm_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~


vim +/qaic_pm_resume +724 drivers/accel/qaic/qaic_drv.c

   702	
 > 703	static int qaic_pm_suspend(struct device *dev)
   704	{
   705		struct qaic_device *qdev = pci_get_drvdata(to_pci_dev(dev));
   706	
   707		dev_dbg(dev, "Suspending..\n");
   708		if (qaic_data_path_busy(qdev)) {
   709			dev_dbg(dev, "Device's datapath is busy. Aborting suspend..\n");
   710			return -EBUSY;
   711		}
   712		if (qaic_is_under_reset(qdev)) {
   713			dev_dbg(dev, "Device is under reset. Aborting suspend..\n");
   714			return -EBUSY;
   715		}
   716		qaic_mqts_ch_stop_timer(qdev->mqts_ch);
   717		qaic_pci_reset_prepare(qdev->pdev);
   718		pci_save_state(qdev->pdev);
   719		pci_disable_device(qdev->pdev);
   720		pci_set_power_state(qdev->pdev, PCI_D3hot);
   721		return 0;
   722	}
   723	
 > 724	static int qaic_pm_resume(struct device *dev)
   725	{
   726		struct qaic_device *qdev = pci_get_drvdata(to_pci_dev(dev));
   727		int ret;
   728	
   729		dev_dbg(dev, "Resuming..\n");
   730		pci_set_power_state(qdev->pdev, PCI_D0);
   731		pci_restore_state(qdev->pdev);
   732		ret = pci_enable_device(qdev->pdev);
   733		if (ret) {
   734			dev_err(dev, "pci_enable_device failed on resume %d\n", ret);
   735			return ret;
   736		}
   737		pci_set_master(qdev->pdev);
   738		qaic_pci_reset_done(qdev->pdev);
   739		return 0;
   740	}
   741	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki