[PATCH 0/9] dt-bindings: PCI: qcom: Add missing required power-domains

[PATCH 0/9] dt-bindings: PCI: qcom: Add missing required power-domains

[Krzysztof Kozlowski]

Recent binding changes forgot to make power-domains required.

I am not updating SC8180xp because it will be fixed other way in my next
patchset.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (9):
      dt-bindings: PCI: qcom,pcie-sa8775p: Add missing required power-domains
      dt-bindings: PCI: qcom,pcie-sc7280: Add missing required power-domains
      dt-bindings: PCI: qcom,pcie-sc8280xp: Add missing required power-domains
      dt-bindings: PCI: qcom,pcie-sm8150: Add missing required power-domains
      dt-bindings: PCI: qcom,pcie-sm8250: Add missing required power-domains
      dt-bindings: PCI: qcom,pcie-sm8350: Add missing required power-domains
      dt-bindings: PCI: qcom,pcie-sm8450: Add missing required power-domains
      dt-bindings: PCI: qcom,pcie-sm8550: Add missing required power-domains
      dt-bindings: PCI: qcom,pcie-x1e80100: Add missing required power-domains

 Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml  | 1 +
 Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml   | 3 +++
 Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml | 1 +
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8150.yaml   | 3 +++
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8250.yaml   | 3 +++
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8350.yaml   | 3 +++
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8450.yaml   | 3 +++
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8550.yaml   | 3 +++
 Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml | 3 +++
 9 files changed, 23 insertions(+)
---
base-commit: 326bbf6e2b1ce8d1e6166cce2ca414aa241c382f
change-id: 20251029-dt-bindings-pci-qcom-fixes-power-domains-36a669b2e252

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

[PATCH 1/9] dt-bindings: PCI: qcom,pcie-sa8775p: Add missing required power-domains

[Krzysztof Kozlowski]

Commit 544e8f96efc0 ("dt-bindings: PCI: qcom,pcie-sa8775p: Move SA8775p
to dedicated schema") move the device schema to separate file, but it
missed a "if:not:...then:" clause in the original binding which was
requiring power-domains for this particular chip.

Fixes: 544e8f96efc0 ("dt-bindings: PCI: qcom,pcie-sa8775p: Move SA8775p to dedicated schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
index 19afe2a03409..f3c54226a19d 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
@@ -78,6 +78,7 @@ properties:
 required:
   - interconnects
   - interconnect-names
+  - power-domains
 
 allOf:
   - $ref: qcom,pcie-common.yaml#

-- 
2.48.1

Re: [PATCH 1/9] dt-bindings: PCI: qcom,pcie-sa8775p: Add missing required power-domains

[Krzysztof Kozlowski]

On 29/10/2025 16:40, Krzysztof Kozlowski wrote:
> Commit 544e8f96efc0 ("dt-bindings: PCI: qcom,pcie-sa8775p: Move SA8775p
> to dedicated schema") move the device schema to separate file, but it
> missed a "if:not:...then:" clause in the original binding which was
> requiring power-domains for this particular chip.
> 
> Fixes: 544e8f96efc0 ("dt-bindings: PCI: qcom,pcie-sa8775p: Move SA8775p to dedicated schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> index 19afe2a03409..f3c54226a19d 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> @@ -78,6 +78,7 @@ properties:
>  required:
>    - interconnects
>    - interconnect-names
> +  - power-domains


I am going through more of the bindings and I noticed now that "resets"
also were within "if:not:" and they should be required here too.

All patchses will be fixed in v2.

Best regards,
Krzysztof

[PATCH 2/9] dt-bindings: PCI: qcom,pcie-sc7280: Add missing required power-domains

[Krzysztof Kozlowski]

Commit 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to
dedicated schema") move the device schema to separate file, but it
missed a "if:not:...then:" clause in the original binding which was
requiring power-domains for this particular chip.

Cc: <stable@vger.kernel.org>
Fixes: 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml
index 4d0a91556603..a2e5755855aa 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml
@@ -76,6 +76,9 @@ properties:
     items:
       - const: pci
 
+required:
+  - power-domains
+
 allOf:
   - $ref: qcom,pcie-common.yaml#
 

-- 
2.48.1

[PATCH 3/9] dt-bindings: PCI: qcom,pcie-sc8280xp: Add missing required power-domains

[Krzysztof Kozlowski]

Commit c007a5505504 ("dt-bindings: PCI: qcom,pcie-sc8280xp: Move
SC8280XP to dedicated schema") move the device schema to separate file,
but it missed a "if:not:...then:" clause in the original binding which
was requiring power-domains for this particular chip.

Cc: <stable@vger.kernel.org>
Fixes: c007a5505504 ("dt-bindings: PCI: qcom,pcie-sc8280xp: Move SC8280XP to dedicated schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml
index 15ba2385eb73..29f9a412c5ea 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml
@@ -61,6 +61,7 @@ properties:
 required:
   - interconnects
   - interconnect-names
+  - power-domains
 
 allOf:
   - $ref: qcom,pcie-common.yaml#

-- 
2.48.1

[PATCH 4/9] dt-bindings: PCI: qcom,pcie-sm8150: Add missing required power-domains

[Krzysztof Kozlowski]

Commit 51bc04d5b49d ("dt-bindings: PCI: qcom,pcie-sm8150: Move SM8150 to
dedicated schema") move the device schema to separate file, but it
missed a "if:not:...then:" clause in the original binding which was
requiring power-domains for this particular chip.

Cc: <stable@vger.kernel.org>
Fixes: 51bc04d5b49d ("dt-bindings: PCI: qcom,pcie-sm8150: Move SM8150 to dedicated schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8150.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8150.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8150.yaml
index 26b247a41785..ceec5baedcd8 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8150.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8150.yaml
@@ -74,6 +74,9 @@ properties:
     items:
       - const: pci
 
+required:
+  - power-domains
+
 allOf:
   - $ref: qcom,pcie-common.yaml#
 

-- 
2.48.1

[PATCH 5/9] dt-bindings: PCI: qcom,pcie-sm8250: Add missing required power-domains

[Krzysztof Kozlowski]

Commit 4891b66185c1 ("dt-bindings: PCI: qcom,pcie-sm8250: Move SM8250 to
dedicated schema") move the device schema to separate file, but it
missed a "if:not:...then:" clause in the original binding which was
requiring power-domains for this particular chip.

Cc: <stable@vger.kernel.org>
Fixes: 4891b66185c1 ("dt-bindings: PCI: qcom,pcie-sm8250: Move SM8250 to dedicated schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8250.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8250.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8250.yaml
index af4dae68d508..2ad538019998 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8250.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8250.yaml
@@ -83,6 +83,9 @@ properties:
     items:
       - const: pci
 
+required:
+  - power-domains
+
 allOf:
   - $ref: qcom,pcie-common.yaml#
 

-- 
2.48.1

[PATCH 6/9] dt-bindings: PCI: qcom,pcie-sm8350: Add missing required power-domains

[Krzysztof Kozlowski]

Commit 2278b8b54773 ("dt-bindings: PCI: qcom,pcie-sm8350: Move SM8350 to
dedicated schema") move the device schema to separate file, but it
missed a "if:not:...then:" clause in the original binding which was
requiring power-domains for this particular chip.

Cc: <stable@vger.kernel.org>
Fixes: 2278b8b54773 ("dt-bindings: PCI: qcom,pcie-sm8350: Move SM8350 to dedicated schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8350.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8350.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8350.yaml
index dde3079adbb3..7106ff08da6c 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8350.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8350.yaml
@@ -73,6 +73,9 @@ properties:
     items:
       - const: pci
 
+required:
+  - power-domains
+
 allOf:
   - $ref: qcom,pcie-common.yaml#
 

-- 
2.48.1

[PATCH 7/9] dt-bindings: PCI: qcom,pcie-sm8450: Add missing required power-domains

[Krzysztof Kozlowski]

Commit 88c9b3af4e31 ("dt-bindings: PCI: qcom,pcie-sm8450: Move SM8450 to
dedicated schema") move the device schema to separate file, but it
missed a "if:not:...then:" clause in the original binding which was
requiring power-domains for this particular chip.

Cc: <stable@vger.kernel.org>
Fixes: 88c9b3af4e31 ("dt-bindings: PCI: qcom,pcie-sm8450: Move SM8450 to dedicated schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8450.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8450.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8450.yaml
index 6e0a6d8f0ed0..20c764717800 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8450.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8450.yaml
@@ -77,6 +77,9 @@ properties:
     items:
       - const: pci
 
+required:
+  - power-domains
+
 allOf:
   - $ref: qcom,pcie-common.yaml#
 

-- 
2.48.1

[PATCH 8/9] dt-bindings: PCI: qcom,pcie-sm8550: Add missing required power-domains

[Krzysztof Kozlowski]

Commit b8d3404058a6 ("dt-bindings: PCI: qcom,pcie-sm8550: Move SM8550 to
dedicated schema") move the device schema to separate file, but it
missed a "if:not:...then:" clause in the original binding which was
requiring power-domains for this particular chip.

Cc: <stable@vger.kernel.org>
Fixes: b8d3404058a6 ("dt-bindings: PCI: qcom,pcie-sm8550: Move SM8550 to dedicated schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sm8550.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8550.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8550.yaml
index 8f02a2fa6d6e..849100269884 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sm8550.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sm8550.yaml
@@ -84,6 +84,9 @@ properties:
       - const: pci # PCIe core reset
       - const: link_down # PCIe link down reset
 
+required:
+  - power-domains
+
 allOf:
   - $ref: qcom,pcie-common.yaml#
 

-- 
2.48.1

[PATCH 9/9] dt-bindings: PCI: qcom,pcie-x1e80100: Add missing required power-domains

[Krzysztof Kozlowski]

Power domains should be required for PCI, so the proper SoC supplies are
turned on.

Cc: <stable@vger.kernel.org>
Fixes: 692eadd51698 ("dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
index 61581ffbfb24..277337c51b49 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
@@ -73,6 +73,9 @@ properties:
       - const: pci # PCIe core reset
       - const: link_down # PCIe link down reset
 
+required:
+  - power-domains
+
 allOf:
   - $ref: qcom,pcie-common.yaml#
 

-- 
2.48.1

Re: [PATCH 9/9] dt-bindings: PCI: qcom,pcie-x1e80100: Add missing required power-domains

[Johan Hovold]

On Wed, Oct 29, 2025 at 04:40:46PM +0100, Krzysztof Kozlowski wrote:
> Power domains should be required for PCI, so the proper SoC supplies are
> turned on.
> 
> Cc: <stable@vger.kernel.org>

I have a feeling I've pointed this out before, but these kind of binding
patches really does not seem to qualify for stable backporting (e.g.
does not "fix a real bug that bothers people").

> Fixes: 692eadd51698 ("dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
 
> +required:
> +  - power-domains
> +

Johan

Re: [PATCH 9/9] dt-bindings: PCI: qcom,pcie-x1e80100: Add missing required power-domains

[Krzysztof Kozlowski]

On 29/10/2025 17:46, Johan Hovold wrote:
> On Wed, Oct 29, 2025 at 04:40:46PM +0100, Krzysztof Kozlowski wrote:
>> Power domains should be required for PCI, so the proper SoC supplies are
>> turned on.
>>
>> Cc: <stable@vger.kernel.org>
> 
> I have a feeling I've pointed this out before, but these kind of binding
> patches really does not seem to qualify for stable backporting (e.g.
> does not "fix a real bug that bothers people").

I wish stable users of DT bindings (so some 3rd party projects or
product trees) keep testing their stable kernels, their stable DTS with
the bindings, whenever they upgrade their LTS kernel. And if they keep
testing then they should be told about lack of the power domain. That's
why this is for.

Of course fix impact is pretty small, so I don't mind if the stable tag
is being dropped here, but I will not resend just for that unless PCI or
stable maintainers ask me.

Best regards,
Krzysztof

Re: [PATCH 9/9] dt-bindings: PCI: qcom,pcie-x1e80100: Add missing required power-domains

[Rob Herring]

On Wed, Oct 29, 2025 at 05:46:30PM +0100, Johan Hovold wrote:
> On Wed, Oct 29, 2025 at 04:40:46PM +0100, Krzysztof Kozlowski wrote:
> > Power domains should be required for PCI, so the proper SoC supplies are
> > turned on.
> > 
> > Cc: <stable@vger.kernel.org>
> 
> I have a feeling I've pointed this out before, but these kind of binding
> patches really does not seem to qualify for stable backporting (e.g.
> does not "fix a real bug that bothers people").

Presumably if someone omits power-domain and the driver doesn't work, 
then it's a bug affecting them.

I'm fine with dropping the stable tag because it will still most likely 
get picked up with the Fixes tag. :)

Rob
 

Re: [PATCH 9/9] dt-bindings: PCI: qcom,pcie-x1e80100: Add missing required power-domains

[Johan Hovold]

On Thu, Oct 30, 2025 at 01:08:27PM -0500, Rob Herring wrote:
> On Wed, Oct 29, 2025 at 05:46:30PM +0100, Johan Hovold wrote:
> > On Wed, Oct 29, 2025 at 04:40:46PM +0100, Krzysztof Kozlowski wrote:
> > > Power domains should be required for PCI, so the proper SoC supplies are
> > > turned on.
> > > 
> > > Cc: <stable@vger.kernel.org>
> > 
> > I have a feeling I've pointed this out before, but these kind of binding
> > patches really does not seem to qualify for stable backporting (e.g.
> > does not "fix a real bug that bothers people").
> 
> Presumably if someone omits power-domain and the driver doesn't work, 
> then it's a bug affecting them.

Yeah, and any such devicetree source fix would be a candidate for stable
backporting.
 
> I'm fine with dropping the stable tag because it will still most likely 
> get picked up with the Fixes tag. :)

Heh. I skimmed the 6.16 stable branch and it seems it was mostly
explicitly tagged binding patches that ended up being backported.

Johan