From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m10243.netease.com (mail-m10243.netease.com [154.81.10.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62AD34A3C for ; Sun, 2 Nov 2025 03:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=154.81.10.243 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762053882; cv=none; b=nulecGlZ66bklPIf9u2Na80RDHQIeJK9+ILTkDSJ3Rmri9lAkF0NraR+Q+NRBxL6udoUBRl/WGuiRzLj8dbRb97RwguetCYDIjBbWkdWxRtOfD/6KUYecf/umwiNOzu8Hz1isfamV4VnVaTfl3ebouKoCdCLJFZd9JSWcTha+Bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762053882; c=relaxed/simple; bh=SfJ9RMgwuVpZTKuIf6ysPpMKFQh7RYkezwGbBQOG2Hk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eohkF4ZjKO1efVa1ORqAfMT73hjAj0oghVjnx6LT0rHPnWKpbAwP0xDvzWoBGEPeItofRsg3tq6RjR250k8CDgaoWNzh3+TAkf7C7u7bx2BErWKnqvFAp4NGdY7j4FJTq+CoVL82EMilz/4aNMIQW/dwADVguWxJh7HKUfc8jAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thundersoft.com; spf=pass smtp.mailfrom=thundersoft.com; dkim=pass (1024-bit key) header.d=thundersoft.com header.i=@thundersoft.com header.b=A6TrMfIu; arc=none smtp.client-ip=154.81.10.243 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thundersoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thundersoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=thundersoft.com header.i=@thundersoft.com header.b="A6TrMfIu" Received: from ROG.lan (unknown [116.3.204.103]) by smtp.qiye.163.com (Hmail) with ESMTP id 2809d7952; Sun, 2 Nov 2025 11:09:13 +0800 (GMT+08:00) From: Hongyang Zhao To: dmitry.baryshkov@oss.qualcomm.com Cc: andersson@kernel.org, casey.connolly@linaro.org, christopher.obbard@linaro.org, hongyang.zhao@thundersoft.com, linux-arm-msm@vger.kernel.org, loic.minier@oss.qualcomm.com, rosh@debian.org Subject: Re: [PATCH v5 1/2] arm64: dts: qcom: rubikpi3: Add qcs6490-rubikpi3 board dts Date: Sun, 2 Nov 2025 11:09:00 +0800 Message-ID: <20251102030900.107190-1-hongyang.zhao@thundersoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9a428a53fd09d5kunmc5043f9784c667 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVkZS0lIVh9OGEpCSkNNSEpOSFYVFAkWGhdVEwETFh oSFyQUDg9ZV1kYEgtZQVlKSk1VSFVJS09VSktIWVdZFhoPEhUdFFlBWU9LSFVKS0hKTkxKVUpLS1 VKQktLWQY+ DKIM-Signature: a=rsa-sha256; b=A6TrMfIukmSSG2zk1IhYuZvHffWlt3YoSpt2n9gLGiytFknB3jGxlF4rnNX7QwY9l/g/AeQoz5/ns2XtNLIlHCCw3mQoqt3joeSqKZDsIkTn9VVdajrmpoDjB9rjEKmWPfut8zXSwMu9GOnPdGCnKJdmVZGeZ55aXh3zRCX9EQE=; c=relaxed/relaxed; s=default; d=thundersoft.com; v=1; bh=/Wk7gelrCokWjcSbafW75qF2+S26OGsNeJMhRgjZ8ds=; h=date:mime-version:subject:message-id:from; > On Fri, Oct 31, 2025 at 05:27:27PM +0800, Hongyang Zhao wrote: > > > On Sat, Oct 25, 2025 at 08:27:22PM +0800, Hongyang Zhao wrote: > > > > Add DTS for Thundercomm qcs6490-rubikpi3 board which uses > > > > QCS6490 SoC. > > > > > > > > Works: > > > > - Bluetooth (AP6256) > > > > - Wi-Fi (AP6256) > > > > - Ethernet (AX88179B connected to UPD720201) > > > > - FAN > > > > - Two USB Type-A 3.0 ports (UPD720201 connected to PCIe0) > > > > - M.2 M-Key 2280 PCIe 3.0 > > > > - RTC > > > > - USB Type-C > > > > - USB Type-A 2.0 port > > > > - 40PIN: I2C x1, UART x1 > > > > > > > > Signed-off-by: Hongyang Zhao > > > > Reviewed-by: Roger Shimizu > > > > Cc: Casey Connolly > > > > Cc: Christopher Obbard > > > > Cc: Loic Minier > > > > --- > > > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > > > .../dts/qcom/qcs6490-thundercomm-rubikpi3.dts | 1390 +++++++++++++++++ > > > > 2 files changed, 1391 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts > > > > > > > > + vreg_lt9611_3p3: vreg_lt9611_3p3 { > > > > > > regulator-foo-bar-baz, please. This way VPH PWR doesn't stand out. > > > > Understood, I will check the entire device tree and change: > > vreg_lt9611_3v3: regulator-lt9611-3v3 > > vreg_m2_1v8: regulator-m2-1v8 > > vreg_sdio_wifi_1v8: regulator-wifi-1v8 > > ... > > > > > > + > > > > + vph_pwr: vph-pwr-regulator { > > > > > > Otherwise you currently stuffed it in the middle of other regulators, > > > although it doesn't belong here. > > > > Understood, I will move vph-pwr-regulator after usb1-sbu-mux. > > I hope, you are talking about regulator-vph-pwr now. Got it, I will change it to regulator-vph-pwr and put it before all regulators: reserved-memory { ... } vph_pwr: regulator-vph-pwr { ... } vreg_lt9611_3v3: regulator-lt9611-3v3 { ... } [...] > > > > > + > > > > + led@1 { > > > > + reg = <1>; > > > > + color = ; > > > > + function = LED_FUNCTION_INDICATOR; > > > > + function-enumerator = <3>; > > > > + linux,default-trigger = "none"; > > > > + default-state = "off"; > > > > + panic-indicator; > > > > + label = "red"; > > > > > > So, is it "red" or LED_COLOR_ID_GREEN? > > > > This should be changed to: > > color = ; > > So, what is the actual LED colour? Also, is it a single multi-colour LED > or several separate LEDs? The actual color is the same as the label attribute. It's actually an LED package that combines three LEDs side-by-side. Our hardware colleagues thought it was three separate LEDs. I've uploaded a photo of the LEDs to Github: https://hongyang-rp.github.io > > > > > > > > > > + }; > > > > + > > > > + led@2 { > > > > + reg = <2>; > > > > + color = ; > > > > + function = LED_FUNCTION_INDICATOR; > > > > + function-enumerator = <2>; > > > > + linux,default-trigger = "none"; > > > > + default-state = "off"; > > > > + label = "green"; > > > > + }; > > > > + > > > > + led@3 { > > > > + reg = <3>; > > > > + color = ; > > > > + function = LED_FUNCTION_INDICATOR; > > > > + function-enumerator = <1>; > > > > + linux,default-trigger = "none"; > > > > + default-state = "off"; > > > > + label = "blue"; > > > > > > Likewise, why is this blue? > > > > This should be changed to: > > color = ; > > > > > > > > > + }; > > > > +}; > > > > + --- Thank you for the review! Hongyang