Re: [PATCH v5 1/2] arm64: dts: qcom: rubikpi3: Add qcs6490-rubikpi3 board dts

[Hongyang Zhao <hongyang.zhao@thundersoft.com>]

>On 10/31/25 10:27 AM, Hongyang Zhao wrote:
>>> On Sat, Oct 25, 2025 at 08:27:22PM +0800, Hongyang Zhao wrote:
>>>> Add DTS for Thundercomm qcs6490-rubikpi3 board which uses
>>>> QCS6490 SoC.
>>>>
>>>> Works:
>>>> - Bluetooth (AP6256)
>>>> - Wi-Fi (AP6256)
>>>> - Ethernet (AX88179B connected to UPD720201)
>>>> - FAN
>>>> - Two USB Type-A 3.0 ports (UPD720201 connected to PCIe0)
>>>> - M.2 M-Key 2280 PCIe 3.0
>>>> - RTC
>>>> - USB Type-C
>>>> - USB Type-A 2.0 port
>>>> - 40PIN: I2C x1, UART x1
>>>>
>>>> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
>>>> Reviewed-by: Roger Shimizu <rosh@debian.org>
>>>> Cc: Casey Connolly <casey.connolly@linaro.org>
>>>> Cc: Christopher Obbard <christopher.obbard@linaro.org>
>>>> Cc: Loic Minier <loic.minier@oss.qualcomm.com>
>>>> ---
>
>[...]
>
>>>> +			cpu_hot: cpu-hot {
>>>> +				temperature = <90000>;
>>>> +				hysteresis = <5000>;
>>>> +				type = "active";
>>>> +			};
>>>
>>> This has the same value as trip-point0. Is it intentional?
>> 
>> I overlooked the temperatures in sc7280.dtsi, I will remove cpu_hot.
>> 
>> Additionally, based on Konrad's final suggestion in
>> "[PATCH v4 1/2] arm64: dts: qcom: rubikpi3: Add qcs6490-rubikpi3 board dts",
>> I will remove the cooling-maps node (user space service will get netlink
>> information to control the fan), and finally change to:
>
>My suggestion was to fix the description and wire up the fan. I called
>your userland service creative because I didn't want to use the other
>word that came to mind.
>

Understood, I will change it to:

&thermal_zones {
	cpu0-thermal {
		trips {
			cpu_tepid: cpu-tepid {
				temperature = <65000>;
				hysteresis = <5000>;
				type = "active";
			};

			cpu_warm: cpu-warm {
				temperature = <80000>;
				hysteresis = <5000>;
				type = "active";
			};
		};

		cooling-maps {
			map-cpu-tepid {
				cooling-device = <&fan0 1 1>;
				trip = <&cpu_tepid>;
			};

			map-cpu-warm {
				cooling-device = <&fan0 2 2>;
				trip = <&cpu_warm>;
			};

			map-cpu-hot {
				cooling-device = <&fan0 3 3>;
				trip = <&cpu0_alert0>;
			};
		};
	};
};

---
Thank you for the review!
Hongyang