From: David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Casey Connolly <casey.connolly@linaro.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
phone-devel@vger.kernel.org, David Heidelberg <david@ixit.cz>
Subject: [PATCH v2 05/12] drm/panel: sofef00: Split sending commands to the enable/disable functions
Date: Thu, 13 Nov 2025 18:57:39 +0100 [thread overview]
Message-ID: <20251113-sofef00-rebuild-v2-5-e175053061ec@ixit.cz> (raw)
In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz>
From: David Heidelberg <david@ixit.cz>
It's not possible to send DSI panel commands in the .unprepare. Move it
to .disable and do similar for prepare, where we move the display on to
the .enable.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
drivers/gpu/drm/panel/panel-samsung-sofef00.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/drm/panel/panel-samsung-sofef00.c
index 3097040e6bfa0..a3651f0060bde 100644
--- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c
+++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c
@@ -68,6 +68,14 @@ static int sofef00_panel_on(struct sofef00_panel *ctx)
mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x20);
mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00);
+ return dsi_ctx.accum_err;
+}
+
+static int sofef00_enable(struct drm_panel *panel)
+{
+ struct sofef00_panel *ctx = to_sofef00_panel(panel);
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
+
mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
return dsi_ctx.accum_err;
@@ -110,11 +118,19 @@ static int sofef00_panel_prepare(struct drm_panel *panel)
return 0;
}
-static int sofef00_panel_unprepare(struct drm_panel *panel)
+static int sofef00_disable(struct drm_panel *panel)
{
struct sofef00_panel *ctx = to_sofef00_panel(panel);
sofef00_panel_off(ctx);
+
+ return 0;
+}
+
+static int sofef00_panel_unprepare(struct drm_panel *panel)
+{
+ struct sofef00_panel *ctx = to_sofef00_panel(panel);
+
regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies);
return 0;
@@ -154,6 +170,8 @@ static int sofef00_panel_get_modes(struct drm_panel *panel, struct drm_connector
static const struct drm_panel_funcs sofef00_panel_panel_funcs = {
.prepare = sofef00_panel_prepare,
+ .enable = sofef00_enable,
+ .disable = sofef00_disable,
.unprepare = sofef00_panel_unprepare,
.get_modes = sofef00_panel_get_modes,
};
--
2.51.0
next prev parent reply other threads:[~2025-11-13 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 17:57 [PATCH v2 00/12] Make Samsung SOFEF00 DDIC and panel work David Heidelberg via B4 Relay
2025-11-13 17:57 ` [PATCH v2 01/12] dt-bindings: panel: Convert Samsung SOFEF00 DDIC into standalone yaml David Heidelberg via B4 Relay
2025-11-14 8:13 ` Krzysztof Kozlowski
2025-11-16 13:55 ` Casey Connolly
2025-11-16 14:42 ` David Heidelberg
2025-11-16 17:46 ` David Heidelberg
2025-11-13 17:57 ` [PATCH v2 02/12] arch: arm64: qcom: sdm845-enchilada: Specify panel name within the compatible David Heidelberg via B4 Relay
2025-11-13 20:28 ` Bjorn Andersson
2025-11-13 17:57 ` [PATCH v2 03/12] drm/panel: sofef00: Clean up panel description after s6e3fc2x01 removal David Heidelberg via B4 Relay
2025-11-13 17:57 ` [PATCH v2 04/12] drm/panel: sofef00: Handle all regulators David Heidelberg via B4 Relay
2025-11-13 17:57 ` David Heidelberg via B4 Relay [this message]
2025-11-13 17:57 ` [PATCH v2 06/12] drm/panel: sofef00: Introduce page macro David Heidelberg via B4 Relay
2025-11-13 17:57 ` [PATCH v2 07/12] drm/panel: sofef00: Add prepare_prev_first flag to drm_panel David Heidelberg via B4 Relay
2025-11-13 17:57 ` [PATCH v2 08/12] drm/panel: sofef00: Initialise at 50% brightness David Heidelberg via B4 Relay
2025-11-13 17:57 ` [PATCH v2 09/12] drm/panel: sofef00: Introduce compatible which includes the panel name David Heidelberg via B4 Relay
2025-11-13 17:57 ` [PATCH v2 10/12] drm/panel: sofef00: Simplify get_modes David Heidelberg via B4 Relay
2025-11-13 17:57 ` [PATCH v2 11/12] drm/panel: sofef00: Mark the LPM mode always-on David Heidelberg via B4 Relay
2025-11-13 17:57 ` [PATCH v2 12/12] drm/panel: sofef00: Non-continuous mode and video burst are supported David Heidelberg via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113-sofef00-rebuild-v2-5-e175053061ec@ixit.cz \
--to=devnull+david.ixit.cz@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox