linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Marek Behún" <kabel@kernel.org>,
	"Antoine Tenart" <atenart@kernel.org>,
	mwojtas@chromium.org, netdev@vger.kernel.org,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Eric Dumazet" <edumazet@google.com>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com,
	davem@davemloft.net, "Florian Fainelli" <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Romain Gantois" <romain.gantois@bootlin.com>,
	devicetree@vger.kernel.org, "Paolo Abeni" <pabeni@redhat.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>,
	"Nicolò Veronese" <nicveronese@gmail.com>,
	"Tariq Toukan" <tariqt@nvidia.com>,
	"Köry Maincent" <kory.maincent@bootlin.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Andrew Lunn" <andrew@lunn.ch>, "Simon Horman" <horms@kernel.org>
Subject: Re: [PATCH net-next v21 01/14] dt-bindings: net: Introduce the ethernet-connector description
Date: Thu, 4 Dec 2025 12:35:41 -0600	[thread overview]
Message-ID: <20251204183541.GA1936817-robh@kernel.org> (raw)
In-Reply-To: <5dc32a3f-42d8-43d7-854b-3cf11c05544c@kernel.org>

On Sat, Nov 29, 2025 at 12:40:15PM +0100, Christophe Leroy (CS GROUP) wrote:
> 
> 
> Le 29/11/2025 à 10:21, Rob Herring (Arm) a écrit :
> > 
> > On Sat, 29 Nov 2025 09:22:13 +0100, Maxime Chevallier wrote:
> > > The ability to describe the physical ports of Ethernet devices is useful
> > > to describe multi-port devices, as well as to remove any ambiguity with
> > > regard to the nature of the port.
> > > 
> > > Moreover, describing ports allows for a better description of features
> > > that are tied to connectors, such as PoE through the PSE-PD devices.
> > > 
> > > Introduce a binding to allow describing the ports, for now with 2
> > > attributes :
> > > 
> > >   - The number of pairs, which is a quite generic property that allows
> > >     differentating between multiple similar technologies such as BaseT1
> > >     and "regular" BaseT (which usually means BaseT4).
> > > 
> > >   - The media that can be used on that port, such as BaseT for Twisted
> > >     Copper, BaseC for coax copper, BaseS/L for Fiber, BaseK for backplane
> > >     ethernet, etc. This allows defining the nature of the port, and
> > >     therefore avoids the need for vendor-specific properties such as
> > >     "micrel,fiber-mode" or "ti,fiber-mode".
> > > 
> > > The port description lives in its own file, as it is intended in the
> > > future to allow describing the ports for phy-less devices.
> > > 
> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > > Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > > Tested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> > > ---
> > >   .../bindings/net/ethernet-connector.yaml      | 57 +++++++++++++++++++
> > >   .../devicetree/bindings/net/ethernet-phy.yaml | 18 ++++++
> > >   MAINTAINERS                                   |  1 +
> > >   3 files changed, 76 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/net/ethernet-connector.yaml
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> 
> Those errors are unrelated to the blamed patch, the patch is about Ethernet
> the error is about thermal-sensors.

There was an assumption that the base (generally linux-next if not 
defined) works. That unfortunately was not the case when a patch applied 
introduced a tab char presumably as part of conflict resolution. So now 
almost every patch fails. Applying the months old patch was timed 
perfectly with my disappearing for US holidays as well as the merge 
window because as an added bonus it went into Linus' tree too. Anyways, 
Linus' tree and today's next are fixed now. The automated testing now 
aborts if the base has issues, so this shouldn't happen again (it will 
be for other reasons). So most of the patches aren't getting tested now 
until folks move of the broken linux-next versions.  

And thanks to all this, now Linus wants to change all kernel YAML files 
over to tabs instead. That's been my week...

Rob

  reply	other threads:[~2025-12-04 18:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-29  8:22 [PATCH net-next v21 00/14] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 01/14] dt-bindings: net: Introduce the ethernet-connector description Maxime Chevallier
2025-11-29  9:21   ` Rob Herring (Arm)
2025-11-29 11:40     ` Christophe Leroy (CS GROUP)
2025-12-04 18:35       ` Rob Herring [this message]
2025-11-29  8:22 ` [PATCH net-next v21 02/14] net: ethtool: Introduce ETHTOOL_LINK_MEDIUM_* values Maxime Chevallier
2025-12-02 13:03   ` Paolo Abeni
2025-12-02 15:48     ` Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 03/14] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 04/14] net: phy: dp83822: Add support for phy_port representation Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 05/14] dt-bindings: net: dp83822: Deprecate ti,fiber-mode Maxime Chevallier
2025-11-29  9:21   ` Rob Herring (Arm)
2025-11-29 11:42     ` Christophe Leroy (CS GROUP)
2025-11-29  8:22 ` [PATCH net-next v21 06/14] net: phy: Create a phy_port for PHY-driven SFPs Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 07/14] net: phy: Introduce generic SFP handling for PHY drivers Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 08/14] net: phy: marvell-88x2222: Support SFP through phy_port interface Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 09/14] net: phy: marvell: " Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 10/14] net: phy: marvell10g: Support SFP through phy_port Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 11/14] net: phy: at803x: Support SFP through phy_port interface Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 12/14] net: phy: qca807x: " Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 13/14] net: phy: Only rely on phy_port for PHY-driven SFP Maxime Chevallier
2025-11-29  8:22 ` [PATCH net-next v21 14/14] Documentation: networking: Document the phy_port infrastructure Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204183541.GA1936817-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=chleroy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dimitri.fedrau@liebherr.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=herve.codina@bootlin.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=kabel@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mwojtas@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicveronese@gmail.com \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=romain.gantois@bootlin.com \
    --cc=tariqt@nvidia.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).