From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E24F199FBA; Sun, 28 Dec 2025 17:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766943467; cv=none; b=T+YN7Fzkx6p3wNyrey6gd3eH/RR32+PncXT/DLVSeYMw0bue7aArevaeskvMB599oOJUHE+WA7j1Uvp5mrPApe8UBKCHusc3Ua4jTf/GiBTDIjTmZibEc9pm6bT0ylKIXJp57AgGNKnDd3WfaA9M9qxin0qn1i/galZSRgp4pSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766943467; c=relaxed/simple; bh=BVyrGvuZxQ32vWuyuPyWhvaKJBjsen6sagC/3IcqpSs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DO3jADQxkp6FQMxKlyeCKlKSJHjBitcAa5NkeIhwI+HUjDaJUZlGmoPawAYM/ZF+dFr2AzUr26AJrdnM1CVwH4yCKOIngR7OoEre0JqmkhHPYoQaQpwA5d7gWRWyw+ov6E/hHyF98FHrQFQ1v6G/7KD5nbXilPTSStNaF5LMgQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=V/wDRMsQ; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="V/wDRMsQ" Received: from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi [81.175.209.152]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9F8DB4BB; Sun, 28 Dec 2025 18:37:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1766943448; bh=BVyrGvuZxQ32vWuyuPyWhvaKJBjsen6sagC/3IcqpSs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V/wDRMsQYkz61hN+SmAYpeteMIET3dbzn84NCONg5GqGOSmCMYHVprroRZOofKUvp DRAuP2Wwl2hgYN0uyopjD1EL+FUTeQO+9puw4xsQJ8TneYfOeVS0YyqMSoQJZ/tDcm CJXJJ354O2ddLgV05A9JT32LE2IQcIyZmKoXDAzs= Date: Sun, 28 Dec 2025 19:37:24 +0200 From: Laurent Pinchart To: Dmitry Baryshkov Cc: Jani Nikula , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal Subject: Re: [PATCH v4 5/8] drm: renesas: rcar-du: use drmm_writeback_connector_init() Message-ID: <20251228173724.GR4094@pendragon.ideasonboard.com> References: <20251228-wb-drop-encoder-v4-0-58d28e668901@oss.qualcomm.com> <20251228-wb-drop-encoder-v4-5-58d28e668901@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251228-wb-drop-encoder-v4-5-58d28e668901@oss.qualcomm.com> On Sun, Dec 28, 2025 at 07:21:37PM +0200, Dmitry Baryshkov wrote: > Use drmm_plain_encoder_alloc() to allocate simple encoder and > drmm_writeback_connector_init() in order to initialize writeback > connector instance. The patch makes the driver more complex, so the commit message should explain why this is a good idea. > Reviewed-by: Suraj Kandpal > Reviewed-by: Louis Chauvet > Signed-off-by: Dmitry Baryshkov > --- > .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 23 +++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c > index 8cd37d7b8ae2..64cea20d00b3 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c > @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector *connector) > static const struct drm_connector_funcs rcar_du_wb_conn_funcs = { > .reset = rcar_du_wb_conn_reset, > .fill_modes = drm_helper_probe_single_connector_modes, > - .destroy = drm_connector_cleanup, > .atomic_duplicate_state = rcar_du_wb_conn_duplicate_state, > .atomic_destroy_state = rcar_du_wb_conn_destroy_state, > }; > @@ -202,15 +201,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcdu, > { > struct drm_writeback_connector *wb_conn = &rcrtc->writeback; > Extra blank line. > + struct drm_encoder *encoder; > + > + encoder = drmm_plain_encoder_alloc(&rcdu->ddev, NULL, > + DRM_MODE_ENCODER_VIRTUAL, NULL); > + if (IS_ERR(encoder)) > + return PTR_ERR(encoder); > + > + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); > + > + encoder->possible_crtcs = drm_crtc_mask(&rcrtc->crtc); > + > drm_connector_helper_add(&wb_conn->base, > &rcar_du_wb_conn_helper_funcs); > > - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, > - &rcar_du_wb_conn_funcs, > - &rcar_du_wb_enc_helper_funcs, > - writeback_formats, > - ARRAY_SIZE(writeback_formats), > - 1 << drm_crtc_index(&rcrtc->crtc)); > + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, > + &rcar_du_wb_conn_funcs, > + encoder, > + writeback_formats, > + ARRAY_SIZE(writeback_formats)); > } > > void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, -- Regards, Laurent Pinchart