Re: [PATCH v3] mmc: host: sdhci-msm: Add support for wrapped keys

[Eric Biggers <ebiggers@kernel.org>]

On Mon, Dec 29, 2025 at 12:35:07PM +0530, Neeraj Soni wrote:
> Add the wrapped key support for sdhci-msm by implementing the needed
> methods in struct blk_crypto_ll_ops and setting the appropriate flag in
> blk_crypto_profile::key_types_supported.
> 
> Tested on SC7280 eMMC variant.
> 
> How to test:
> 
> Use the "wip-wrapped-keys-2024-12-09" tag from https://github.com/ebiggers/fscryptctl
> and build fscryptctl that supports generating wrapped keys.

Use the official release of fscryptctl from
https://github.com/google/fscryptctl instead.  v1.3.0 has wrapped key
support.

Note that the tag you linked to was for an older version of the wrapped
key patches that wasn't compatible with the upstreamed version.  So it
isn't plausible that it still works.  I'll assume you actually tested a
different version and then just listed the wrong tag in your commit
message.  To avoid confusion, I've deleted that old tag.

> Tested-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>

Otherwise this patch looks good.

Reviewed-by: Eric Biggers <ebiggers@kernel.org>

- Eric