Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Hongyang Zhao <hongyang.zhao@thundersoft.com>
To: neil.armstrong@linaro.org
Cc: Laurent.pinchart@ideasonboard.com, airlied@gmail.com,
	andersson@kernel.org, andrzej.hajda@intel.com,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, hongyang.zhao@thundersoft.com,
	jernej.skrabec@gmail.com, jonas@kwiboo.se,
	konradybcio@kernel.org, krzk+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	rfoss@kernel.org, robh@kernel.org, rosh@debian.org,
	simona@ffwll.ch, tzimmermann@suse.de, vkoul@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: display: lt9611: Add dsi-port-b property
Date: Tue, 27 Jan 2026 16:48:54 +0800	[thread overview]
Message-ID: <20260127084854.1714905-1-hongyang.zhao@thundersoft.com> (raw)
In-Reply-To: <7d9041a3-9d2b-469a-9fa7-89d53bbd2a1f@linaro.org>

> On 1/27/26 07:58, Hongyang Zhao wrote:
> > Document the lontium,dsi-port-b property for selecting DSI Port B as
> > the input source instead of the default Port A.
> >
> > Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
> > Reviewed-by: Roger Shimizu <rosh@debian.org>
> > ---
> >   .../devicetree/bindings/display/bridge/lontium,lt9611.yaml          | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> > index 655db8cfdc25..9b7dba4e114c 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> > @@ -37,6 +37,12 @@ properties:
> >     vcc-supply:
> >       description: Regulator for 3.3V IO power.
> >
> > +  lontium,dsi-port-b:
> > +    type: boolean
> > +    description:
> > +      Use DSI Port B as the input source instead of Port A or Port A + B.
> > +      Required when the DSI is physically connected to Port B.
>
> This is not how this should be solved, the ports links are here for this exact purpose.
>
> port@0 represents port A, port@1 represent port B, so you need to describe the HW correctly
> in the first place.
>
> Populate only port1 and in the driver check which ports are population and change the
> configuration.
>
> Neil
>
> > +
> >     ports:
> >       $ref: /schemas/graph.yaml#/properties/ports
> >
> >

Hi Neil,

Thanks for the review. You're right - I'll use the ports to describe the
physical connection properly.

I'll update the patches to:
1. Make port@0 optional in the binding (require at least one of port@0 or port@1)
2. Update port descriptions to clarify port@0 = Port A, port@1 = Port B
3. Modify the driver to detect which port is populated and configure accordingly
4. Use port@1 in the RubikPi3 DTS since the DSI is physically connected to Port B

Will send v2 shortly.

Thanks,
Hongyang

  reply	other threads:[~2026-01-27  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27  6:58 [PATCH 0/3] Add DSI Port B input support for LT9611 HDMI bridge Hongyang Zhao
2026-01-27  6:58 ` [PATCH 1/3] dt-bindings: display: lt9611: Add dsi-port-b property Hongyang Zhao
2026-01-27  7:54   ` Neil Armstrong
2026-01-27  8:48     ` Hongyang Zhao [this message]
2026-01-27  6:58 ` [PATCH 2/3] drm/bridge: lt9611: Add support for DSI port B input Hongyang Zhao
2026-01-27  6:58 ` [PATCH 3/3] arm64: dts: qcom: qcs6490-rubikpi3: Use DSI port B Hongyang Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260127084854.1714905-1-hongyang.zhao@thundersoft.com \
    --to=hongyang.zhao@thundersoft.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=rosh@debian.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox