From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8445218AB9; Tue, 24 Feb 2026 05:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771911052; cv=none; b=AuxkLYsms1XRbJu4wNlWEtFPyjy2Vt8u+r/d7XhPKcprvPPm2I/3MIQywIGhE6agM6KR46Cf77Yhfu956eQdHRiyOauBXfJzLhfKnEDiGdk9YxPX9yg4szAaglsLpJOzpZfmZayksikRdlRzntjmy2XU4bTgwp162DmEJBLO7uE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771911052; c=relaxed/simple; bh=JoCqd4qTmhZAw9Ra/kUSAYchs5sr6tzJ0I7Nt266T1c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZETwmhL0GZA1kkr4Oq1qj9xYK79acNBhK4R3OFk+ySfHhKvXk7QEihA6zNTcv8+NT8kz/zH1rY2hRrqWa9etD5+h+p69qmpCypKzEYIx0Ig3SgsFNC9hxT63jwLsMV+18gyn4Ht+syIIi1lNkQAKl8CNosgr2aHY+qy1+omEb7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l712owvZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l712owvZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id A3568C2BC86; Tue, 24 Feb 2026 05:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771911052; bh=JoCqd4qTmhZAw9Ra/kUSAYchs5sr6tzJ0I7Nt266T1c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=l712owvZtBOLZNSZ8jVFkdyZ1s0SR6C8uijHIcEFtvLu+1rF3/RLeJ+j/N5dGW02R jjL/LJGDZ3tb4lEQiSd8xiJrpNykSM/lQUTPnDK+Ow9TRvV+RoCiyeF9tXaXhdutOE l5vgevn2Vt9DiOcL2pivOTvJNVV2ks2Axmage+ripyLGiPmI0CiZZdQOkOHHiHQg2J 7MfqYwdOmUIUsH6LJuPAWUD8oD5fyCAJ6eewu6b/lDkqxitXU/INr61sEYz1kIecD+ sqnciGqus0UECl2eF91R+xT20Z+Bb7SfQg5kLRv4Xxh2ygcnhKc9FKcb0vra9XwotY yt7Myk5h87KDg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939CCEFB800; Tue, 24 Feb 2026 05:30:52 +0000 (UTC) From: Manivannan Sadhasivam via B4 Relay Date: Tue, 24 Feb 2026 11:00:49 +0530 Subject: [PATCH v5 3/9] serdev: Do not return -ENODEV from of_serdev_register_devices() if external connector is used Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260224-pci-m2-e-v5-3-dd9b9501d33c@oss.qualcomm.com> References: <20260224-pci-m2-e-v5-0-dd9b9501d33c@oss.qualcomm.com> In-Reply-To: <20260224-pci-m2-e-v5-0-dd9b9501d33c@oss.qualcomm.com> To: Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Nathan Chancellor , Nicolas Schier , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mark Pearson , "Derek J. Clark" , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley , Marcel Holtmann , Luiz Augusto von Dentz , Bartosz Golaszewski , Andy Shevchenko , Bartosz Golaszewski Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org, Stephan Gerhold , Dmitry Baryshkov , linux-acpi@vger.kernel.org, Manivannan Sadhasivam , Hans de Goede , Bartosz Golaszewski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1461; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=9JYNk+DMPq2LlZQfTiexJ4EeAYXDboalcaCh+TYovs0=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBpnTeIZPVB6TXs7qJCxZKnKwelNFrs4yCQW7stK n5l2YxnGqCJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaZ03iAAKCRBVnxHm/pHO 9WeqB/4oeIaNaesPvXIPgrTC8c8dEL+ulzvpa7xXgn0f/n1iIZcd9Qvnor+uSHBIjnNX8YytZSU NIsWprNhRtUxTsmwu/NNQGg7R7AJbd4oHn6iQlDv7VLBN+H5wv7DoRHWXdIefCDpqsOMKLsWLi+ nBMntq4rZWhXVYbh3oKmMweIWcVMC1ABHIubxhIVf8W0SQUzlbu9UIThUVftK37wRFbS7GAkWXk YBaWTeSSp1nrKZL630unIuLiAyW/zW0ZrwfgilYI3oZD6RxCs0iZfe5EoHib+HCpnY9sqcKlq79 o0KO4smHOJfm+t7x0Fe6lXI+H7vupOMr/IjtMQh7G9ykqDb+ X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-Endpoint-Received: by B4 Relay for manivannan.sadhasivam@oss.qualcomm.com/default with auth_id=461 X-Original-From: Manivannan Sadhasivam Reply-To: manivannan.sadhasivam@oss.qualcomm.com From: Manivannan Sadhasivam If an external connector like M.2 is connected to the serdev controller in DT, then the serdev devices may be created dynamically by the connector driver. So do not return -ENODEV from of_serdev_register_devices() if the static nodes are not found and the graph node is used. Tested-by: Hans de Goede # ThinkPad T14s gen6 (arm64) Reviewed-by: Bartosz Golaszewski Signed-off-by: Manivannan Sadhasivam --- drivers/tty/serdev/core.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index bf88b95f7458..e9d044a331b0 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -561,7 +562,13 @@ static int of_serdev_register_devices(struct serdev_controller *ctrl) } else found = true; } - if (!found) + + /* + * When the serdev controller is connected to an external connector like + * M.2 in DT, then the serdev devices may be created dynamically by the + * connector driver. + */ + if (!found && !of_graph_is_present(dev_of_node(&ctrl->dev))) return -ENODEV; return 0; -- 2.51.0