From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9078B2D0635; Tue, 10 Mar 2026 09:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773136561; cv=none; b=o5YScuyYTWk5eJE20VeCwSOAy41J7ojPinCwFnI/BqF53Qy5uyXZ5KxTLfs45J4ReKqCH0OF9Eu10xbBwRFUKRmmqJkQJrsndiW5WkXJhHDgeBGWw8D15XzM9l+qU5MhfH7nCo1vvJZg4XYtCKxWrIXR8SrBec+DBhBsKdo0+oQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773136561; c=relaxed/simple; bh=+r3tE95HrRQqcdSdgD0hfWaR76TCI4iD6VxCNk0yqlk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DcZVobJDIc9WLfro9tscmP7cw8lHQnT4Ep9Vrs8aRQxeLo3bQCwSb/xWekBDPrj+i/jeSPnSVahJ4XMsIKceCLd9/9z5nHF/1OuoowftVU32c6JQiLTcvdpZ4tLtkdM5EiMqXzZ2SgQONgqS1SFQNKALX3v1jVCQSRciqNPpcJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q70qclMo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q70qclMo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EA0DC19423; Tue, 10 Mar 2026 09:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773136561; bh=+r3tE95HrRQqcdSdgD0hfWaR76TCI4iD6VxCNk0yqlk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q70qclMogNYUV+95K3evAVuHNX8opxG7tz4kF/m5eq4tYrCXz06FJP3s8hWHs2q9p GqXVV1HB1JjlpmDVN0ux5CgoHTJu/c5Bc9/S+1JFza60N/1AZ6VL681c4ThAyHe8Do IwUwrzu4wKmXMtlVcodvTOb3IABQRhXND1ZWaGe/KwqJlwR4wTMbNPmo+D8UvQFfsy D8X6ZoOxX1LZPZAW3qP/jqm3D7Kx0aMIglIfFNFIQb14N31+wmSfMZ4oJA/58QiZSP WutP0v8KyATrwWkLsai7GN99I5e8p2VRS0HbnE6sNLXZo85E6ygV2G9nuJR/NlgUBf WjvlAK5I+Vavw== Date: Tue, 10 Mar 2026 10:55:58 +0100 From: Krzysztof Kozlowski To: Mohammad Rafi Shaik Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: Re: [PATCH v1 1/4] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode Message-ID: <20260310-crazy-screeching-angelfish-297bab@quoll> References: <20260309111300.2484262-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260309111300.2484262-2-mohammad.rafi.shaik@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260309111300.2484262-2-mohammad.rafi.shaik@oss.qualcomm.com> On Mon, Mar 09, 2026 at 04:42:57PM +0530, Mohammad Rafi Shaik wrote: > Extend the qcom,q6apm-lpass-dais device tree binding to explicitly > describe Digital Audio Interface (DAI) child nodes. > > Add #address-cells and #size-cells to allow representation of multiple > DAI instances as child nodes, and define a dai@ pattern to document > per-DAI properties such as the interface ID and associated clocks. > > Qualcomm platforms like talos integrate third-party audio codecs or use > different external audio paths. These designs often require additional > configuration such as explicit MI2S MCLK settings for audio to work. > > Co-developed-by: Srinivas Kandagatla > Signed-off-by: Srinivas Kandagatla > Signed-off-by: Mohammad Rafi Shaik > --- > .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 41 ++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml > index 2fb95544d..1d770cbcb 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml > @@ -21,6 +21,34 @@ properties: > '#sound-dai-cells': > const: 1 > > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > +# Digital Audio Interfaces > +patternProperties: > + '^dai@[0-9]+$': > + type: object > + description: > + Q6DSP Digital Audio Interfaces. > + > + properties: > + reg: > + description: > + Digital Audio Interface ID > + > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + minItems: 1 > + maxItems: 3 No, this is just way too generic. There is no such syntax in the kernel and this should stop you right there. You are not allowed to add your own style. I don't think DAI is here a separate device needing its own resources expressed in DT. This is still part of ADSP so you just described in DT internal routing between two services on ADSP. > + > + additionalProperties: false > + > required: > - compatible > - '#sound-dai-cells' > @@ -29,7 +57,18 @@ unevaluatedProperties: false > > examples: > - | > - dais { Why? > + #include > + > + bedais { > compatible = "qcom,q6apm-lpass-dais"; > #sound-dai-cells = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + dai@16 { > + reg = ; > + clocks = <&q6prmcc LPASS_CLK_ID_MCLK_1 > + LPASS_CLK_ATTRIBUTE_COUPLE_NO>; So one entry, not three. > + clock-names = "mclk"; > + }; > }; > -- > 2.34.1 >