From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 746073B7B71 for ; Mon, 16 Mar 2026 15:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773676635; cv=none; b=mFiCsztIAM1RlWvfJ/Y18ruRRDd7K0KtoNQDl4M8elQlf9HhyD8VOVIq+JX6QHFcuGUAEHzTqcdszJT/PGS12ljSDX+Hxe/80dL0TAMlMtPxyTBkmXioENgaDaXKqiD+aEiMzo8A4ZF4Lr4LTPFl9gpmn2TmJBF8SueoWLfGfek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773676635; c=relaxed/simple; bh=PbKrBXthjNGfFtArOSneEVU2S5ohT/HxHPM5k6fcTws=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kA2DQdZ2spTHPwKg0bVBun4/diKfNEFA2IAxVXLwAL4YVRHXuD95cVmDb6p6dfWnV1hzodxjnObzOuvs4InzXrIQsXQ8VATvcerbA+wFn/phYEdJ0mFlikmWFsd4Y8GqKd6HVkF0C1hWcuJHnEIBx7ZjZ8fi5gD8GqKT4dJb4Gg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=F+wuM52t; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="F+wuM52t" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 0AB131A2E6A; Mon, 16 Mar 2026 15:57:08 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id CEBD15FC9A; Mon, 16 Mar 2026 15:57:07 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8D680103721F0; Mon, 16 Mar 2026 16:56:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773676624; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=gPWg45628wXOGTSku2sZt3UN9TbvmDc1uinjnNPjXiQ=; b=F+wuM52tfsJOst/pUkIjwdenzlZY0QftTQ/4NOcFwfqocdMH+NJh258BZnrMoKeqLFNMEN bc/L1DGDGBOGFcp6+xGMrdsjDhxpeU3BPexd032tb2bOu45ca1ox4QhIawUCc6kJ+bA9VX oPm7oNiLCUTiYQCqCHB3fegsu43UgYV3WkEKQGcGp0ATgB7Uei6Cs5z4mzzsVUCjPaNFO9 bKAx3EK1UM87DtIQX3KE3czU4JqXiKI0pEai0IcEfkeyeuv+wzPiiAq6ziT/0PdsYdWFbD JdtYjZRq09Tc1bq2iZhxGh7dMNzhhgNtvzkx6mw29MT90ATt/4M2/hLnjYz6eA== Date: Mon, 16 Mar 2026 16:56:37 +0100 From: Herve Codina To: Kuninori Morimoto Cc: "Martin =?UTF-8?B?UG92acOFwqFlcg==?=" , Alexandre Belloni , Alexandre Torgue , Andrei Simion , AngeloGioacchino Del Regno , Arnaud Pouliquen , Baolin Wang , Bard Liao , Benson Leung , Biju Das , Cezary Rojewski , Cheng-Yi Chiang , Chunyan Zhang , Claudiu Beznea , Cyril Chao , Dan Carpenter , Daniel Baluta , Daniel Mack , Fabio Estevam , Frank Li , Geert Uytterhoeven , Guenter Roeck , Haojian Zhuang , Jaroslav Kysela , Jonathan Hunter , Kai Vehmanen , Kunihiko Hayashi , Lad Prabhakar , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Masami Hiramatsu , Matthias Brugger , Max Filippov , Maxime Coquelin , Michal Simek , Nicolas Ferre , Nicolin Chen , Oder Chiou , Olivier Moysan , Orson Zhai , Peter Ujfalusi , Pierre-Louis Bossart , Ranjani Sridharan , Ray Jui , Robert Jarzmik , Sascha Hauer , Scott Branden , Sheetal , Shengjiu Wang , Srinivas Kandagatla , Sylwester Nawrocki , Takashi Iwai , Thierry Reding , Tim Bird , Tzung-Bi Shih , Venkata Prasad Potturu , Vijendar Mukunda , Vincenzo Frascino , Xiubo Li , chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v2 01/29] ASoC: soc-component: re-add pcm_new()/pcm_free() Message-ID: <20260316165637.7b09fa9b@bootlin.com> In-Reply-To: <87a4w8lde4.wl-kuninori.morimoto.gx@renesas.com> References: <87bjgoldf9.wl-kuninori.morimoto.gx@renesas.com> <87a4w8lde4.wl-kuninori.morimoto.gx@renesas.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Kuninori, On Mon, 16 Mar 2026 02:24:43 +0000 Kuninori Morimoto wrote: > Because old pcm_new()/pcm_free() didn't care about parameter component, > to avoid name collisions, we have added pcm_construct()/pcm_destruct() by > commit c64bfc9066007 ("ASoC: soc-core: add new pcm_construct/pcm_destruct") > > Because all driver switch to new pcm_construct()/pcm_destruct(), old > pcm_new()/pcm_free() were remoted by commit e9067bb502787 ("ASoC: s/remoted/removed > soc-component: remove snd_pcm_ops from component driver") > > But naming of pcm_construct()/pcm_destruct() are not goot. re-add > pcm_new()/pcm_free(), and switch to use it, again. > > Signed-off-by: Kuninori Morimoto > --- > include/sound/soc-component.h | 4 ++++ > sound/soc/generic/audio-graph-card.c | 1 + > sound/soc/soc-component.c | 10 +++++++++- > 3 files changed, 14 insertions(+), 1 deletion(-) Nothing more than the typo, Reviewed-by: Herve Codina Best regards, Hervé