From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6130D3033CF for ; Fri, 20 Mar 2026 01:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773971703; cv=none; b=oN6FmQvaRYBCYNq207vIk6bSSh7tiLhwzFdizxecaii0p4OteEtBMGLL3uL2FiL/JsYDusXO4i4fKt4GpGp+64faLFpsSvt4rR0FtFx4sa8tlwb47gBRr+afE+Q585cohHoQEGicqpbGF9rzFf4bys2BiVDfbHP2of9hwV5aQMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773971703; c=relaxed/simple; bh=R9G5DrWK7ZdreBHQ/NvwOHQkAkxN8nydMv+XrJUDCnI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rvw1h1aaBCZbaS5B2w75NpZSG4ijG5WktTaVpU4ot/ysKFeZyawPau5sSRqbUeqKDo5x+rwkd9RtiRbwIvauHhsDIkr32xn5pVtJSiIYcDuYktB7ylEoMQ+WT+FdjO9CAVGiCwo0PB1SxnuXMuBd1M+LJid/cNuR/d6Nzbb/EoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H0H0lOJ8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MH3swVtd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H0H0lOJ8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MH3swVtd" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62JIvXkC235075 for ; Fri, 20 Mar 2026 01:54:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Yu4Ju/BNMWhFePsUEYj76VBRHr5svFe8Za8zkvDfGq4=; b=H0H0lOJ8LZBrcg2Z oqfHF1G7yYVkcxyh9FMZuHnFq0EjwwtzPv/lk8xEZQNk27L95teSv+oLWwgLay4A fvvaUFGjrbVtuFe2sPXW/O/OL5LFlg/AB64dRYpJniQZBwLy8jcJc1NH124TSWOl JxGUM0pRJoY208DJZVsrIMsLIGZzPKV0Cpkm3Ai8dOk4DOauPCQ+paBAiodEfjRb Sm2WCQqcsWz7xUS3KwX7l9wGwJjDX6IgAhx9G6ogsBE+TuPIfu67o5h+rps+fnLB mm1C4dbY9IsEn1R4C+h/ZXywQSP9hoQ6n2GHHg2sATIaXCpthbNMJ8VXadCyFRqj 2lvPvg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0pvhrxr4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Mar 2026 01:54:56 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5090cc6a7d2so11515131cf.2 for ; Thu, 19 Mar 2026 18:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773971695; x=1774576495; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Yu4Ju/BNMWhFePsUEYj76VBRHr5svFe8Za8zkvDfGq4=; b=MH3swVtdg9ACOcTFvZSgEAb3R5kYRK20tei8Lhs5Jbn//U5nB4b6QL68j3vkkezUKn VtwDgNId9NblCDJJRncy5+C4PDuU1Epg99I0EkmKk8q9qXE6JgaiyUzK6kcqRT9Oagiu FBN23tXo0mP40bhEb57fBfVLczwW2V+co4hKCk/wXIDrRfULpF+S1gALTlnAiKii8Ldl hOdTwL1lrqXQ1HRILkI8m0/4zHz3S7+Wbhz1w3RHeMB76gWuKYHgFU1rsT984Qhf2TPN wFxh80eQLZ66Cqefad58hiyKbzuxkOiFGMxCWytbzVghEI4X0DRhcLyqDv9sM3qZj2l6 uPzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773971695; x=1774576495; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Yu4Ju/BNMWhFePsUEYj76VBRHr5svFe8Za8zkvDfGq4=; b=YpzQoF2HkxzIo4Xr/iVGxU2CBv5Xf2w2KAHV77dEGDgqbSzT5l7cufhmJ93THVKibN p8fOCkXRsqgaAk5SMDgYUlxJUiPDZqwYV2aFZusgXI38fqCovdvcF/YIa7y2imffzmbN PMFT6bgW7wKXDH33Nh7ZrTABujePKZxXkP51AqaPLCr8ztW6s5UJVF66VPELVKy2Zlx8 6inVWD8tqZ0cLC2MqJJWUxyHiLdUz4Tk6V/60KnVjAgUM79vHdsgHFUHee8jfn3S4Ggk FAm++EEWhwHuFvaeyx+k/MTKX2Rwkwlrqd425jRrzjRJtSmLy4zqdH7TUWLn+BHklaDY dU0Q== X-Forwarded-Encrypted: i=1; AJvYcCVXkRh2RojWJ44tuDagAAl5nq7QXKUhrevzxxSFS87K2deyBmIojb9lje2vXbMnKyoL59hgQxVgoQFBrR2T@vger.kernel.org X-Gm-Message-State: AOJu0Yzgx1C+uxG576lNZuLKX41aBBg4CbsYBKgIuyfNbmET1mUVujDN 3KHYe7HItSr5okr1Wf5BUctjl92lNfmhRuWHHglGZpmpHy9pvA1GbEWes9C7jDO2YFVcXdexPFT 6VlQ0vmGwBj2htIc/jLLdB0DmSe0PIhJgLBW5eCKasQY4ySJFMEdqTYigbux8KekcZQQ/soyMb2 u0 X-Gm-Gg: ATEYQzy2Pklg7LBwArqOisM3ryo5XfLKUKrZ7YX6wxfTKGUP/qm1KJH1PfGEtXHPAa0 eJxfnj8wDOphlMV0FmlHMiTo3UMzYAVO/eWlPZLGOOV0lenDPt3DNvaH0li1tv4iV0Do5fwiOJl JxPrQre9t+S9g6sYcqyDFmc6kQXfLr3o9WfT9e7bEJJDb1DxvH5s+jFewo6xc/ckyYLfwpQSwp1 B+a3ZIsjlZt7Uk9N0zZu8BID5rDs7/NyzDAQDQJ3SmnazsJb+yOabU1wme53H06FJMRnAMySvFE 6P4uDcIGWwXmimEX5g8zWf9w5OiqkVLrkYRRmqbd1oye4NcLz5ugHiQpKICMZFBK/cHd1ckOc6R CtLVLWG+fvgjcWk9tKgY3y0Ol+U+qOxLkVuypzAGCVee3nmiyRGzTNEn0/nhjFNx17+7a61sMGX dK0b1Cox/T62mCym+2A0ZVM5KCSW9XuNde+Fg= X-Received: by 2002:a05:622a:1b28:b0:509:20de:4acc with SMTP id d75a77b69052e-50b3753f7e5mr20695221cf.47.1773971694893; Thu, 19 Mar 2026 18:54:54 -0700 (PDT) X-Received: by 2002:a05:622a:1b28:b0:509:20de:4acc with SMTP id d75a77b69052e-50b3753f7e5mr20694881cf.47.1773971694286; Thu, 19 Mar 2026 18:54:54 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a285305eefsm232344e87.70.2026.03.19.18.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 18:54:52 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 20 Mar 2026 03:54:41 +0200 Subject: [PATCH v9 01/11] media: qcom: iris: drop pas_id from the iris_platform_data struct Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260320-iris-platform-data-v9-1-3939967f4752@oss.qualcomm.com> References: <20260320-iris-platform-data-v9-0-3939967f4752@oss.qualcomm.com> In-Reply-To: <20260320-iris-platform-data-v9-0-3939967f4752@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=6224; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=R9G5DrWK7ZdreBHQ/NvwOHQkAkxN8nydMv+XrJUDCnI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpvKjkAsbxPGbFF5oyEt/EhISI27We56rjYzWCN q79SvGI4w2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabyo5AAKCRCLPIo+Aiko 1a4IB/wLZo1cEX9xuwgfkg11keF9bpNDNrmy33+EVeQwnsNS1kAMZ83a6MJIy0cmHJ7sso/63CR lzQddruj3oRXL0OBvh3ok8CgAgyBLbUhIiOoXAStz7RgJjX1+RmbSVr2K2Bj7/k6oYcP4gTQocS 7Qu/eMA8V8PV5bhlkaS3N3eSYYFmVbcEt/8P3U3npzV5WNwf1IU3oFdZevBNx/e7gUMRugdvbSS cnqXdf/y01I1CZw7+gmkytpslC//WHhyZut9ceCecME+xWopjGu/ylaAhimaciGMxJrZJ2VXYGb 91/ZoUsrpGdbMLajkBqo93XGiQ2fX4tqUZ2H8jYKtQ6W4uQq X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=F95at6hN c=1 sm=1 tr=0 ts=69bca8f0 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=hYMYe-gnznq9qBW6PAEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: VDgeXSEBufOoHokYAWJQTctIyZBW6t33 X-Proofpoint-ORIG-GUID: VDgeXSEBufOoHokYAWJQTctIyZBW6t33 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIwMDAxMyBTYWx0ZWRfX0yQIwZ19qC97 XVVMqI1Dl9TIQOe2tC/9bFpmWgm286ORRh/ruDGX7aDpnzV7323PUdp+EWm8uzaFWG+serF1T2b ZfJ5Cn/ItPEB8QFiDFBgluxqkD9OLOpYsvzylMY6Tyk5IIHaRvF4mDNcleGIrOOVIR8AqmZSYj7 VwTSP7kU5jocOto0M+wps1lNdIVE18aUFlAxZDCvcCXLv7EtYeMbZU1OngJxLh9MbjbiorvnJOX jEZf2J2EPR7IJDnZx8srsWVyKv07jJ7hYRUf9kJ5kjhNpCc/cI7S9/edxDetRZA982zYvKvjtSD W+bSTx3EqrhWWsQg7/UkfS5mLYvf+KLpoI2LmQ+XBL3CfiE1xyrqKBwWMjLWDUkcACA6EYH7SKW +TclWxm7C8dM/F9LoK1GL613a1iwiQzK/pWIggFmV7OD7PVSvnqg9CF/3ft3yDD+sU5lynlF9zF L32Ld5oKHwkTP+s1Qdg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_04,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603200013 The PAS ID, the authentication service ID, used by the Iris is a constant and it is not expected to change anytime. Drop it from the platform data and use the constant instead. Reviewed-by: Dikshita Agarwal Reviewed-by: Konrad Dybcio Reviewed-by: Vikash Garodia Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_firmware.c | 11 ++++++----- drivers/media/platform/qcom/iris/iris_platform_common.h | 2 -- drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 -- drivers/media/platform/qcom/iris/iris_platform_gen2.c | 4 ---- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c index 5f408024e967..bc6c5c3e00c3 100644 --- a/drivers/media/platform/qcom/iris/iris_firmware.c +++ b/drivers/media/platform/qcom/iris/iris_firmware.c @@ -12,11 +12,12 @@ #include "iris_core.h" #include "iris_firmware.h" +#define IRIS_PAS_ID 9 + #define MAX_FIRMWARE_NAME_SIZE 128 static int iris_load_fw_to_memory(struct iris_core *core, const char *fw_name) { - u32 pas_id = core->iris_platform_data->pas_id; const struct firmware *firmware = NULL; struct device *dev = core->dev; struct resource res; @@ -53,7 +54,7 @@ static int iris_load_fw_to_memory(struct iris_core *core, const char *fw_name) } ret = qcom_mdt_load(dev, firmware, fw_name, - pas_id, mem_virt, mem_phys, res_size, NULL); + IRIS_PAS_ID, mem_virt, mem_phys, res_size, NULL); memunmap(mem_virt); err_release_fw: @@ -79,7 +80,7 @@ int iris_fw_load(struct iris_core *core) return -ENOMEM; } - ret = qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id); + ret = qcom_scm_pas_auth_and_reset(IRIS_PAS_ID); if (ret) { dev_err(core->dev, "auth and reset failed: %d\n", ret); return ret; @@ -93,7 +94,7 @@ int iris_fw_load(struct iris_core *core) cp_config->cp_nonpixel_size); if (ret) { dev_err(core->dev, "qcom_scm_mem_protect_video_var failed: %d\n", ret); - qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); + qcom_scm_pas_shutdown(IRIS_PAS_ID); return ret; } } @@ -103,7 +104,7 @@ int iris_fw_load(struct iris_core *core) int iris_fw_unload(struct iris_core *core) { - return qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); + return qcom_scm_pas_shutdown(IRIS_PAS_ID); } int iris_set_hw_state(struct iris_core *core, bool resume) diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h index f42e1798747c..e4eefc646c7f 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -12,7 +12,6 @@ struct iris_core; struct iris_inst; -#define IRIS_PAS_ID 9 #define HW_RESPONSE_TIMEOUT_VALUE (1000) /* milliseconds */ #define AUTOSUSPEND_DELAY_VALUE (HW_RESPONSE_TIMEOUT_VALUE + 500) /* milliseconds */ @@ -226,7 +225,6 @@ struct iris_platform_data { unsigned int controller_rst_tbl_size; u64 dma_mask; const char *fwname; - u32 pas_id; struct iris_fmt *inst_iris_fmts; u32 inst_iris_fmts_size; struct platform_inst_caps *inst_caps; diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c index aa71f7f53ee3..07ed572e895b 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c @@ -360,7 +360,6 @@ const struct iris_platform_data sm8250_data = { /* Upper bound of DMA address range */ .dma_mask = 0xe0000000 - 1, .fwname = "qcom/vpu-1.0/venus.mbn", - .pas_id = IRIS_PAS_ID, .inst_iris_fmts = platform_fmts_sm8250_dec, .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8250_dec), .inst_caps = &platform_inst_cap_sm8250, @@ -413,7 +412,6 @@ const struct iris_platform_data sc7280_data = { /* Upper bound of DMA address range */ .dma_mask = 0xe0000000 - 1, .fwname = "qcom/vpu/vpu20_p1.mbn", - .pas_id = IRIS_PAS_ID, .inst_iris_fmts = platform_fmts_sm8250_dec, .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8250_dec), .inst_caps = &platform_inst_cap_sm8250, diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c index a526b50a1cd3..1f23ddb972f0 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c @@ -934,7 +934,6 @@ const struct iris_platform_data sm8550_data = { /* Upper bound of DMA address range */ .dma_mask = 0xe0000000 - 1, .fwname = "qcom/vpu/vpu30_p4.mbn", - .pas_id = IRIS_PAS_ID, .inst_iris_fmts = platform_fmts_sm8550_dec, .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps = &platform_inst_cap_sm8550, @@ -1038,7 +1037,6 @@ const struct iris_platform_data sm8650_data = { /* Upper bound of DMA address range */ .dma_mask = 0xe0000000 - 1, .fwname = "qcom/vpu/vpu33_p4.mbn", - .pas_id = IRIS_PAS_ID, .inst_iris_fmts = platform_fmts_sm8550_dec, .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps = &platform_inst_cap_sm8550, @@ -1133,7 +1131,6 @@ const struct iris_platform_data sm8750_data = { /* Upper bound of DMA address range */ .dma_mask = 0xe0000000 - 1, .fwname = "qcom/vpu/vpu35_p4.mbn", - .pas_id = IRIS_PAS_ID, .inst_iris_fmts = platform_fmts_sm8550_dec, .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps = &platform_inst_cap_sm8550, @@ -1232,7 +1229,6 @@ const struct iris_platform_data qcs8300_data = { /* Upper bound of DMA address range */ .dma_mask = 0xe0000000 - 1, .fwname = "qcom/vpu/vpu30_p4_s6.mbn", - .pas_id = IRIS_PAS_ID, .inst_iris_fmts = platform_fmts_sm8550_dec, .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps = &platform_inst_cap_qcs8300, -- 2.47.3