Re: [PATCH v4 1/6] media: dt-bindings: Document SC8280XP/SM8350 Iris

Krzysztof Kozlowski
2026-03-13T08:25:19Z

On 13/03/2026 09:14, Dmitry Baryshkov wrote:
> On Fri, Mar 13, 2026 at 08:55:00AM +0100, Krzysztof Kozlowski wrote:
>> On Thu, Mar 12, 2026 at 05:14:22PM +0200, Dmitry Baryshkov wrote:
>>> The Iris block on SM8350 and SC8280XP is compatible with the Iris
>>> (Venus) on SM8250. Document those two IP cores, using qcom,sm8250-venus
>>> as a fallback compatible.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>> Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 10 ++++++++--
>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
>>> index 43a10d9f664e..3700f8fe91cc 100644
>>> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
>>> @@ -10,7 +10,7 @@ maintainers:
>>> - Stanimir Varbanov <stanimir.varbanov@linaro.org>
>>>
>>> description: |
>>> - The Venus IP is a video encode and decode accelerator present
>>> + The Iris2 IP is a video encode and decode accelerator present
>>
>> Why Venus name disappears? And why now this is Iris2, not Iris? It's the
>> first time such name is used. Just call it Venus/Iris if the new devices
>> renamed the block.
>
> SM8150, SC8180X had Iris 1.xx. SM8250 and SC7280 have Iris 2.xx. But
> when the bindings were written, it seems, it wasn't obvious (or
> important enough). I will change this to Venus / Iris 2.xx

Then "Iris v2.xx", how we call versions of blocks in all other cases.
The block is simply Iris, not Iris2, right?

Best regards,
Krzysztof