Re: [PATCH v3 2/3] iio: adc: qcom-pm8xxx-xoadc: remove redundant error logs when reading values

Jonathan Cameron
2026-04-20T18:00:07Z

On Mon, 6 Apr 2026 22:44:11 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sun, Apr 05, 2026 at 04:52:18PM +0000, Antony Kurniawan Soemardi wrote:
> > Drop dev_err() logging for -EINVAL and -ETIMEDOUT cases and rely on
> > return values to report errors, reducing unnecessary log noise.
>
> ...
>
> > ret = wait_for_completion_timeout(&adc->complete,
> > VADC_CONV_TIME_MAX_US);
> > if (!ret) {
> > - dev_err(adc->dev, "conversion timed out\n");
> > ret = -ETIMEDOUT;
> > goto unlock;
> > }
>
> In case you need a new version, the above can be replaced with a better
> alternative (assuming the ret is defined as not boolean and it is so):
>
> if (!wait_for_...(...)) {
> ret = ...;
> goto ...
> }
>
Given we are early in the cycle and have lots of time I would like this
change made. It avoids the current slightly nasty meaning changes of
ret where sometimes it being 0 is good, sometimes bad.
So a v4 please with this form that Andy suggested.

Thanks,

Jonathan