Re: [PATCH v3 2/3] iio: adc: qcom-pm8xxx-xoadc: remove redundant error logs when reading values

Andy Shevchenko
2026-04-06T19:44:18Z

On Sun, Apr 05, 2026 at 04:52:18PM +0000, Antony Kurniawan Soemardi wrote:
> Drop dev_err() logging for -EINVAL and -ETIMEDOUT cases and rely on
> return values to report errors, reducing unnecessary log noise.

...

> ret = wait_for_completion_timeout(&adc->complete,
> VADC_CONV_TIME_MAX_US);
> if (!ret) {
> - dev_err(adc->dev, "conversion timed out\n");
> ret = -ETIMEDOUT;
> goto unlock;
> }

In case you need a new version, the above can be replaced with a better
alternative (assuming the ret is defined as not boolean and it is so):

if (!wait_for_...(...)) {
ret = ...;
goto ...
}

--
With Best Regards,
Andy Shevchenko