Re: [PATCH 2/6] drm/msm: fbdev: Inline msm_alloc_stolen_fb()

Dmitry Baryshkov
2026-04-21T16:22:21Z

On Tue, Apr 21, 2026 at 02:51:15PM +0200, Thomas Zimmermann wrote:
> Inline msm_alloc_stolen_fb() into its only caller. This is necessary
> for converting fbdev emulation to use client buffers.
>
> There are some minor changes:
>
> - Handle errors for the non-stolen BO in the respective branch.
>
> - Fill mode_cmd right before using it with msm_framebuffer_init(). Both
> will later be replaced with client-buffer interfaces.
>
> - Set the modifier[0] to DRM_FORMAT_MOD_LINEAR. No functional change.
>
> - Integrate the error handling with the existing clean-up.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/msm/msm_drv.h | 2 --
> drivers/gpu/drm/msm/msm_fb.c | 46 ---------------------------------
> drivers/gpu/drm/msm/msm_fbdev.c | 44 +++++++++++++++++++++++++------
> 3 files changed, 36 insertions(+), 56 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

--
With best wishes
Dmitry