Re: [PATCH 1/6] drm/msm: Do not declare msm_framebuffer_init() as static

Dmitry Baryshkov
2026-04-21T16:09:27Z

On Tue, Apr 21, 2026 at 02:51:14PM +0200, Thomas Zimmermann wrote:
> Declare msm_framebuffer_init() in msm_drv.h and remove the static
> qualifier. The function will be required in msm_fbdev.c after inlining
> msm_alloc_stolen_fb().
>
> Also move msm_framebuffer_init() before msm_framebuffer_create(), so
> that it can later be made static again. Prepares msm's fbdev emulation
> for using client buffers.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/msm/msm_drv.h | 4 ++
> drivers/gpu/drm/msm/msm_fb.c | 72 +++++++++++++++++------------------
> 2 files changed, 39 insertions(+), 37 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

--
With best wishes
Dmitry