Re: [PATCH 2/7] media: qcom: iris: fix state-change debug log printing stale value

Konrad Dybcio
2026-04-22T12:20:41Z

On 4/22/26 1:16 PM, Dikshita Agarwal wrote:
> The state‑change debug log in iris_inst_change_state() always prints the
> same value for the old and new state, rendering it useless for
> debugging. This happens because the state is updated before the log is
> emitted.
>
> Log the transition before updating the state so the previous value is
> preserved, consistent with the existing sub‑state handling.
>
> Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops")
> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> ---

I'd argue it prints the opposite of stale, but the fix is good!

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad