Re: [PATCH v2 10/41] drm/ingenic: remove now-redundant call to drm_connector_attach_encoder()

Paul Cercueil
2026-04-23T17:59:37Z

Hi Luca,

Le jeudi 23 avril 2026 à 11:17 +0200, Luca Ceresoli a écrit :
> drm_connector_attach_encoder() is now called by
> drm_bridge_connector_init().
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index 4068114adf8c..70088db34f69 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -1330,8 +1330,6 @@ static int ingenic_drm_bind(struct device *dev,
> bool has_components)
>   ret = PTR_ERR(connector);
>   goto err_drvdata;
>   }
> -
> - drm_connector_attach_encoder(connector, encoder);
>   }
>
>   drm_for_each_encoder(encoder, drm) {