From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D712BDC23 for ; Fri, 24 Apr 2026 15:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777043513; cv=none; b=KD+DfBQJYjcG614WNLDQTGG74aDlkoj7IZTJq3WOy0poybQaN6WTGyzm0wkqFYNc3zKdI64iBU1CSuDUPHq9KxUTRA/iM+MJSDUm24tfXI7GJA9EeFpDbg3OxilghU6PVwjLqrMMohM2c/1JEYwJZf9Og+m1zjLojbPpQSXFG+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777043513; c=relaxed/simple; bh=RMCacskoFmZ9/Ng6hAjRi+I45M638ggU0L3+USVXwaM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sakKu/mgnXhgPdEKeBnSH5dXuaoZlk1tX/QbmR0FDQtJoD2VRYbTR5NjB6Yko7HeX/tBFxqPRZnfpiK4fsEwtScjLMCIKNioE6k0kYljdgi226Z/I3bOvbLrk6WQxcVhvc8oV39GosMuEINFLZg6UL4B7vslXoyv58WHl/fgr/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gPgu5Hdw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EwEArBRq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gPgu5Hdw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EwEArBRq" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63OE7eOc2291965 for ; Fri, 24 Apr 2026 15:11:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=lcPhu9r6gLN Un/M0FOO+8vu6c2tQ6RhDeBZbp1avftg=; b=gPgu5HdwyKtcYYBAr726GWrr65T FSrHH2sMTX9yA6xeW18FV+hz+y3yvdmRgAO/0D9HC4X0JDvcwKSeTtzkVBNdMF+u Xul+dd6YUjOZpzee2xookpDRdKlQpjoOBOp4qt62sCyp0tXEjDsLNyphU8p9r6fV qSgwCdYsn/emo2yobQTl46FRbKL3k/+1ftc4jLP6PieXmhM8+KGyfRisbRqbEMrG Wr6EvLE3XvoXkQlrczTX5uUnUDEVJGAjs0bWLWtCNdYB1ocZbrIHuTcPtiSLSfgH 3TLAfuAcrq2CpGbwsQtCDGFQz+llD9WBffsHUd8iqsefSDTo9AfEiqSiMdw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqxbpb69y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Apr 2026 15:11:51 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b258636d16so80307555ad.2 for ; Fri, 24 Apr 2026 08:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777043511; x=1777648311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lcPhu9r6gLNUn/M0FOO+8vu6c2tQ6RhDeBZbp1avftg=; b=EwEArBRqwbx28JSlE3/amzKiYdmKbCwYDWuLMLfT/19zP6D1uh8qBDYQFhcHbiE10t rGujB91vtq6XQQgQqNXXmg0KI/5/AjEiUlrxYJFY7mTpRxvv0IPk05mv0DDJrMVH0hU1 uygvy4fcpuzwmlfTqqFKYUMl5kZJpAODYCeJodPBk5kRbIODatUr6IbzjNHRG86aOoFg NAPMsu2BFBee009VYA+v0epMAI5md3DJ9lX2AybRsbLqLR3t0Ny/7VaN03AQhECkJEdG zqd6xDGjZ90oJquXSmj8FPyXcuoZwXTRykNRqExXCbqdRBBTRHVTe4WwHM9eaWBzAfQX 6uCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777043511; x=1777648311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lcPhu9r6gLNUn/M0FOO+8vu6c2tQ6RhDeBZbp1avftg=; b=KbeBDCTzPmYS+u9RjyIAMz+7dSdhwTACszX8S9lwi7OwuMqE6zvlcTltLe/+rRPJ1E rNoOZOWAUzap+1YQ4BOqfYUymCfbS9VOR8KFOd+NZ8vLhEWBI7Ec111e5pg8lJ9gMHsb IjG1wZzOGt/uVcDaMm+suc9lFPn+G020jk6UHZk5h2L4rzg9Flj64lFlHXlzXj3qNczN c/EeSTY8ee7GD3hGuBvmSvn/cfIGgDrFh9K2JiRYrLY/def0S19UfOTLNCOJ1JRqoenW zJwbaQH+2e3l8nhxWhdLni4Af7VjqRmaG1jQxZb3TT9+mZVI+0q3lDg1stdNP5GWG6kM C4nw== X-Gm-Message-State: AOJu0YxJwP8PuLZDZIz57R4txco9x1c1L0oXU0++ccMLQ+gFDmbPwcS5 UTg7Xh8J7sb9XLhFhf0JjvsmcwduRIv9T+O1v0gWrDXp0qjGiQOWBHeXfCxXsdCSJy+jRtCIm6e i65oupxFpBmwFUJqg4gKviawYgrJiLC0XIAa3LiI1GhL8lJojC3GeRmxGHPNaJDfY46ut X-Gm-Gg: AeBDiespu4OJ6yPmscZdaio5qvcrXyj6mrNjmwmVaT4Xu+//Ic8GcqeIB7fchjb7+HG ZUus0GB4syspu2Jz95DeRyu3wnOLSJYEbWKk4gcD6xhewmspFfF96mQ2UzTIP8zu5hX2DHrz+8O ggabNOq4dfc81lp5YSpa4P0GVGQE9Fm4w6wpGn6I2QnyU7F4+T0FYt4DWnzA93ZB1xz4R5liAFs sC7H/zlgSx9u25tiENoXE957AjAIOkt3foQmMPb8RuvI42gR64dkfjiUEtDFi5RgQc2T1GpwJKW sNwMa49zSeNSi5h4xUnPdLwRcP022+CW1GaFsoyIhpmiXfdFNALwMzmLGryvqctD0zv7G6CcnTH W7ovQXYty8WE0dhRGfVPkaZrbX3B9dF2kyd33YXYGVGc= X-Received: by 2002:a17:902:bd8c:b0:2b2:50f6:cdd9 with SMTP id d9443c01a7336-2b5f9ecb818mr216666995ad.8.1777043510611; Fri, 24 Apr 2026 08:11:50 -0700 (PDT) X-Received: by 2002:a17:902:bd8c:b0:2b2:50f6:cdd9 with SMTP id d9443c01a7336-2b5f9ecb818mr216666745ad.8.1777043510082; Fri, 24 Apr 2026 08:11:50 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0caa9sm225689865ad.40.2026.04.24.08.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 08:11:49 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Fri, 24 Apr 2026 08:10:37 -0700 Message-ID: <20260424151140.104093-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424151140.104093-1-robin.clark@oss.qualcomm.com> References: <20260424151140.104093-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ViiJD4JZOEEuz1Upr3hCzBhEqROsGocy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDE0NyBTYWx0ZWRfX3FuNLMoXyQnJ k07Z2BFpHEAQFggXDHLr6+BGJVVgj/3uei6SToPV3nht100M++dbiT75OESIOcUnR9pAVR+bV55 gfjnU4/uHm0n5xw9TkgWhqWGVSNxBz4Eihvy3p+tahxZjqdhMQSFKcaIFY1M9y9MzwOZzt5qmNv J2v4MLVcHcF4e/SwocFTVW+KDwoWQ/OjDT4FVSS/gSygY7QgABLLZxJLaGy4lyrB9KwjmYtExsz K1qLXbL7CkEKomQVs4Va2HAqGDXlResZ6ZrlhboT8Jasx7Jx4qxbJzX1rJdzDxmDrjF63ieVc2c pH1TzrcOdKkk/If02o9hYGcKcn1jEInoq2W8azZHXeWPHF5EV68m+7u1RLL/0guGiRZ+8HcDqGH +zh37bLOt7Do5Ww/t1gHVKsyvs6c7YloQb2uN8PhmFFAZZ4485MofxrcB/5suEbocOaOzuc3v+4 XSlZFKpI5X8UMSjmfrA== X-Proofpoint-ORIG-GUID: ViiJD4JZOEEuz1Upr3hCzBhEqROsGocy X-Authority-Analysis: v=2.4 cv=X+li7mTe c=1 sm=1 tr=0 ts=69eb8837 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=ZRXlmS4ShPoOlOK7p90A:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-24_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 impostorscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240147 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.53.0