From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B484D3D47C6 for ; Tue, 28 Apr 2026 20:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777406867; cv=none; b=PZErylEB9C228lYGvLVQ4svbCM7Otw0GDT69ha4Ez7hFwF1rPfx1NykK/suxYPfpSWyYGTgRB9yuYkgc6HQePmWjL9YO2wKm+Sf9BVb5pYUQsymWfqNCgqWK6VNhzjINr2TRRNJvukgYnlzj7cGNqh27x9dgwjW/nLgo/JONChQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777406867; c=relaxed/simple; bh=70ZUw+XXwGiBv0Z/9jZE4a1D1ZLPbnBPjY6fYI2V8PE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GsasW62kZh3lBwx8eUul3SYyhkcbtj9jfhJ8iT/s5r/wHKd6oOP+ftA3kyhhYYQodBXpLGAokkn88HFSofUxt/2+9u3PvbOI5D1N4V8lq0Oa2pjhg+FzoxV1TMjD6uvicPEonmmuF0Vmc5b/DMY0utSwRgAtlu78yir0Qr5AWes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Qn13UAMR; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Qn13UAMR" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2dec803f9f0so164098eec.0 for ; Tue, 28 Apr 2026 13:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777406862; x=1778011662; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwWtduOWgbcJH/5sVxzLGAMHPFkXvP7oJuezZGoggcs=; b=Qn13UAMRZfoao+u239MgZ436ALKacTJNllhkXBwljUxtYAkf/4H3vIX6BKD2lt/mgv zED4/iQ/9UWhwcPmPzDKusfBCmnUXGK3KBS/O9y7UXApKUh+us/WLbzrO4VZC3SEEEph IFPVUuLPF5S15/zztgmOGbJ7qULLzCwtpoN9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777406862; x=1778011662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iwWtduOWgbcJH/5sVxzLGAMHPFkXvP7oJuezZGoggcs=; b=RMAHjsM9t1LQ2F8nuIfydacb397MsNeUyyazNOCvSz4wprMBxh4z/RGpB3EusPjsB5 AasnFpTKCNz9q+EinC9VombRGZ0CLgkkOHbO4Xq861p4UCEQbgCOK/8jDnQk/BfCi5eO PbtHlIHwT2R1khcWcRgGmEdlqGYYlrvNLYgjbW1noPYIrCJVi2uJHG3B3+xx/0BuDZz9 PQJhBuV+sEilWywky9bBpazgoGJuszdflB3IpXXnnPdZStupLZd+3xdBL16LRlEihu/s 7nbYcJfILLl8arfsNjxl5/dstCJLwlxKO83oe6MJm15NGzYQSQ33R1Ru4Yp7NxJPo/fM UU1Q== X-Forwarded-Encrypted: i=1; AFNElJ9wyeKhR/mr9pspWMzVwm2RQ+Sw/QEAWqy4X0BrP+XvtpavJaZS7bjwilpliG5tUUOx5/MfST42jSGuobTj@vger.kernel.org X-Gm-Message-State: AOJu0YzB8hQNcjUQfOxiOLr1tBetlGZLw9ezxE8Oe34P3QYcD6jqCE9g WP55fPWcKS2ohEhiwMNpK0rop+zTEWz+lFL9rCpQuFHLpSQ0H32efibhvdwn0jJ5xA== X-Gm-Gg: AeBDiesWvMVZOd55Udi1k2uf/NGnpCWf3K43nIobDrfLe1ijatqLQT51CM71m3Ylh9M jMcXkSfdb0TqEsCMia4Jkxgjaji0yciY/ime+SReDWfqNlnGk/ivN5bZcpLUD3Vd7XMGNe3g+kt 9336ca6DlDovo6rLV4WUhQ1su87vAxZunXhBKNJ15HB6gXgG1C8d+mTmtTqt9stl6dloKbjn5mu 8oPFpxCFZgtgRRzX11xWn4R/1mcsGQWnbAyugf+oLO58LWagnKGP/LNVeHglvmrz7qMH5JphC5Y WX+mmbbXMGr9G4KXsetVsvJW20L/wI00/CXMgbxyJOr23TqVSQwajVSzp45w9sBO6EfTvk9k83p IM8s4krcS2GZHur84rLDagxxgKPZ53z8QLI7A3t7QZrzA7w0F21TY324Axs2SX5XXejnyg9Eikm UYgjs+kHUTgZKn/oWzhlXPj4LqbiVQUxCbxGYqKinGGAIGbDhPGefhd/b3VoTUHE0J4iP0y5K0 X-Received: by 2002:a05:7301:3d17:b0:2be:ca4:e114 with SMTP id 5a478bee46e88-2ed1b4057a0mr129402eec.9.1777406861689; Tue, 28 Apr 2026 13:07:41 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:4ff5:9607:c7e5:48f3]) by smtp.gmail.com with UTF8SMTPSA id 5a478bee46e88-2ed09fb712bsm3068754eec.12.2026.04.28.13.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 13:07:41 -0700 (PDT) From: Brian Norris To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Heiko Stuebner , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Konrad Dybcio Cc: devicetree@vger.kernel.org, Doug Anderson , linux-arm-kernel@lists.infradead.org, Tzung-Bi Shih , chrome-platform@lists.linux.dev, Brian Norris , linux-rockchip@lists.infradead.org, Julius Werner , Alim Akhtar , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] ARM: dts: samsung: Add #{address,size}-cells to Chromium-based /firmware Date: Tue, 28 Apr 2026 13:06:56 -0700 Message-ID: <20260428200712.2660635-5-briannorris@chromium.org> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260428200712.2660635-1-briannorris@chromium.org> References: <20260428200712.2660635-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Chromium/Depthcharge bootloaders may dynamically add a few device nodes to a system's DTB under a /firmware node. A typical DT looks something like the following: / { firmware { ranges; coreboot { compatible = "coreboot"; reg = <...>; ...; }; }; }; Notably, the /firmware node has an empty 'ranges', but does not have address/size-cells. Commit 6e5773d52f4a ("of/address: Fix WARN when attempting translating non-translatable addresses") started requiring #address-cells for a device's parent if we want to use the reg resource in a device node. This leads to errors like the following: [ 7.763870] coreboot_table firmware:coreboot: probe with driver coreboot_table failed with error -22 Add appropriate #{address,size}-cells to work around the problem. Note that Google has also patched the Depthcharge bootloader source to add {address,size}-cells [1], but bootloader updates are typically delivered only via Google OS updates. Not all users install Google software updates, and even if they do, Google may not produce updated binaries for all/older devices. [1] https://lore.kernel.org/all/20241209092809.GA3246424@google.com/ https://crrev.com/c/6051580 ("coreboot: Insert #address-cells and #size-cells for firmware node") Closes: https://lore.kernel.org/all/aeKlYzTiL0OB1y3g@google.com/ Fixes: 6e5773d52f4a ("of/address: Fix WARN when attempting translating non-translatable addresses") Signed-off-by: Brian Norris --- arch/arm/boot/dts/samsung/exynos5250-snow-common.dtsi | 5 +++++ arch/arm/boot/dts/samsung/exynos5250-spring.dts | 5 +++++ arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts | 5 +++++ arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts | 5 +++++ 4 files changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/samsung/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/samsung/exynos5250-snow-common.dtsi index 65b000df176e..a64cdec3a2ef 100644 --- a/arch/arm/boot/dts/samsung/exynos5250-snow-common.dtsi +++ b/arch/arm/boot/dts/samsung/exynos5250-snow-common.dtsi @@ -30,6 +30,11 @@ chosen { stdout-path = "serial3:115200n8"; }; + firmware { + #address-cells = <1>; + #size-cells = <1>; + }; + gpio-keys { compatible = "gpio-keys"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/samsung/exynos5250-spring.dts b/arch/arm/boot/dts/samsung/exynos5250-spring.dts index d126fccdcaf3..a337fd9e3473 100644 --- a/arch/arm/boot/dts/samsung/exynos5250-spring.dts +++ b/arch/arm/boot/dts/samsung/exynos5250-spring.dts @@ -33,6 +33,11 @@ chosen { stdout-path = "serial3:115200n8"; }; + firmware { + #address-cells = <1>; + #size-cells = <1>; + }; + gpio-keys { compatible = "gpio-keys"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts b/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts index 3759742d38ca..f24356784492 100644 --- a/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts @@ -50,6 +50,11 @@ chosen { stdout-path = "serial3:115200n8"; }; + firmware { + #address-cells = <1>; + #size-cells = <1>; + }; + fixed-rate-clocks { oscclk { compatible = "samsung,exynos5420-oscclk"; diff --git a/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts b/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts index bb019868b996..3df27eddba15 100644 --- a/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts @@ -49,6 +49,11 @@ chosen { stdout-path = "serial3:115200n8"; }; + firmware { + #address-cells = <1>; + #size-cells = <1>; + }; + fixed-rate-clocks { oscclk { compatible = "samsung,exynos5420-oscclk"; -- 2.54.0.545.g6539524ca2-goog