From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CFE6248F73 for ; Thu, 7 May 2026 01:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778116258; cv=none; b=QknU1y9kTgOmAZSsyGb5ytySpnH1R7DC5+hecyCK7ktw2KolWhF2QcP4kwOshcxbJZLnB0juEudBqLNH+M0wPiFWEMaF8nmKAwkWNT/+3JfjnAQZwkni1Dr2duSmWw/jQL0QTbUGeMCNKMyIp14Ug55m2X9RjIFjvCgl02sGfEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778116258; c=relaxed/simple; bh=1QlP7Ht2G4UJJw6JsObuL9FKuIo3jLuJ5rs2/0xHro8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GWf4rUmPY15CB/OHteDIlcvS5n99z9jNsorQbjn7F7t2DcwvAQ0We48EYrP4IBlJZKDutSBGLpwuISMFDNMf5w+bjeIuCkPNSnlbEUWmE58VaWm3uNBfWQEr5Jr97/ENYr3QEHBRAmZrEfhgQVGtSiuN4MMylz4VHNVxvfwkf/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XrQAkdoG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jPa0i+mb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XrQAkdoG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jPa0i+mb" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 646KlseL3757043 for ; Thu, 7 May 2026 01:10:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Quz1+hYLS+IVpR4ioPDtziPJPuojhivjRtEFcR5Dsis=; b=XrQAkdoGV6aznQRb Zk7jL/AJot66c85Wk2j2diVCfJtT2+HoQDiuZP6FjWbPrStDJo1gzhvIDKI+QT0/ WNZ5UfSYdaa5l3Ff4eRQPETOOUSgZZihF9CIPSQ7Mz6LihHTtnM1g7T42QWPVksA YZ/Xv+iOva1IBtLDJEWRToPJD2lbTb9ogfpoosPY1Q7IeIjii0KX5xLkUS7J/5gv S2uD0xbC6cq9E8eHN214dE+yQXV26QRjb0gE5NBnDi6aieTIVjTfJHNEE64EaN6b bwK3Qfxi87P9TeyHXjrhQm9LwL+yxA1gX4/Wujs7hD4ZAtRYtATb9dfw2UX9qj9x dio9lg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e00v1uugt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 01:10:56 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8eaaf673eb4so94502085a.2 for ; Wed, 06 May 2026 18:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778116255; x=1778721055; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Quz1+hYLS+IVpR4ioPDtziPJPuojhivjRtEFcR5Dsis=; b=jPa0i+mbunTS21Pbqt7mNZ9PD2mFk8WBmMkeLAuBDe1bA2EF5VJPO6L50rrsFiL5S7 vo1LXUqS2oHRHX/EwMtOQCQF+rleI1tFrXpZkaOeK1lxzUncVo5q6RcWSkuLAIOBgzpc jmslQX4BGTyWqRC/nzaE+G+Hwbuvyyn4s2+Q6nZ6LzZ7fpBfsMk3sQQqWYSGUb2g0UNg VBaxBQQTONjlLTSD1NsqqRiyqM5BQv+/bkZxjPQyJh/n4vHucTkDCFDmzQsOiyV8WLRt uiQUGOKOmZArzPgcAmNkMtBzH2vsOWQs4Wm60nDKG259JNSWMQZVi+bRuKw9S+siXRYe 9C4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778116255; x=1778721055; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Quz1+hYLS+IVpR4ioPDtziPJPuojhivjRtEFcR5Dsis=; b=bG+7TX9fof+ZyY0LFcvT6Dkmn8e0ncR3qA0e+t/AjEhjPsbIl8Px2m/hEXHmi4xr+y EsjgIGSlglSOzWjVJ3VW0VXMM0vgWfwq7Uv2/uCZ7eYDob+ZJMf047HXydIc1R+EFLkt qAr7a+1eE5o5SBzxk7w5FOWeNkvwCgghGuN4hmg1c6wyDjtjsPyItPvhOyXJLl1Gz9tX uabf/Q1NmNKc/WaEsGBS31HQ1PUKy2BFbiY/1Jm5nxXDcnjSPP4JF+sTxDmMBcKkPx4D NicNVQSA7k49DLFdqyStacm04RFbt3ILbPfxQz4tduntrJbYYE20yT67UZwjY55E35GJ XfJQ== X-Forwarded-Encrypted: i=1; AFNElJ/fXMtF48uKzsYqTAKt0lglrygSOrTEqehPd3mMahnouolO/fgWwGJYX5yTz27rM1q9h95SlMlTVmOs7FKo@vger.kernel.org X-Gm-Message-State: AOJu0YwpMDyIxCfnqUBb0YFNeRq9/aOKucaiHiuQhzu7vsntVFNbkhw/ nt7BmzFH334crsBejD7xMC1O0AyOP6hwX6fsOg79nDAp1rP4XMv38K+CiLej8uss57JqRpp1b5K vnoZQJODUKAgzSzlEvTZf61DtS6zh+bT7V9vUvN/8kD8u3HntLQMpw9UA+9dbzSqya40M X-Gm-Gg: AeBDiesWspsOXk6sTic19mqCV1GXVOCtkVYy+LJC6VgAN6RLugKsuCR4T2mwB33NL8Z APwfxLqkJZEojvl/pm3YGs8eaV1ZRckcabpdF2Fx5NRETUGVihhy5ezdNAIJYu9XWIiKYIHkZ16 AlgjghAgk5h6hvYbmQDpsRwERUlPexNgUXHw9oz5J1Mk/IDMn2Y7DXfe6+j1ReY2AubmdBvU585 GQc6tmuZApkMnkAyLY/RdtDiHfia0zMvsqOtCvMCB9KrDV6dZFcMUzMByS14f1+u6dSbzyH86tS xthklpWaC7dOwnxPangN+GPnUdupsiM47c1G/ETvb6Eu9Z7dN+vEWiQg6R4OHlacXb91Yj0+1pF aAiP6AcRP5PAwefZ90nITdadwLfSJw5Ph9gl+bIN26rZn7twVwaaKGW/brE9DOz1sdmHccMU0mu hsMOCjK9D/5MLNrS3M13ZvSn/DTeiDShu96X1AwIsmQz6sTQ== X-Received: by 2002:a05:620a:2a0d:b0:8eb:425:2ac6 with SMTP id af79cd13be357-904d4b59704mr841980885a.22.1778116255485; Wed, 06 May 2026 18:10:55 -0700 (PDT) X-Received: by 2002:a05:620a:2a0d:b0:8eb:425:2ac6 with SMTP id af79cd13be357-904d4b59704mr841976785a.22.1778116255030; Wed, 06 May 2026 18:10:55 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230e00sm5221967e87.29.2026.05.06.18.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 18:10:53 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 04:10:42 +0300 Subject: [PATCH v5 3/7] media: iris: don't specify highest_bank_bit in the source code Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260507-iris-ubwc-v5-3-e9a3aee53c49@oss.qualcomm.com> References: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> In-Reply-To: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue , Wangao Wang X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2440; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=1QlP7Ht2G4UJJw6JsObuL9FKuIo3jLuJ5rs2/0xHro8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp++aUhWXHJTdo70XvRKwJ6GRjpbcVSdIC2fJrd xPBFijrFsmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafvmlAAKCRCLPIo+Aiko 1Uh1B/96m2qYOJuCsfVHLH0lul9CSxOjG2U4PRerFqmH8bb8xlJmk8iTl8H3b3z2W0kaUR/9v3C zcoTd+betfJO2GY0WJGeV8Qly8uQrOxAi+0s0gXC4WM4FG+F0nG+1qOxfVvxFuiD/Jaulm/OqQG BWdTVw+mMiwTOm4/BZYG7dT646CakPD2PjUdj5zde0R237T3ZGpJIK5KFf9Z1DSMfgruoscN1Sw lJrmBulZW4clIk5vSofy96LHfkXwhc6dyawR+7+jzviYgs7uCrzSeyQRy4HWn9NkVAnUr7C7yE0 qchBripLPUCRVsgJsue9hwn9CegoLN6ii/15viWl9ip5FtWH X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: V8AFVij28TXcEf5ZdpHUi4QSRIzA-9HB X-Proofpoint-GUID: V8AFVij28TXcEf5ZdpHUi4QSRIzA-9HB X-Authority-Analysis: v=2.4 cv=cKXQdFeN c=1 sm=1 tr=0 ts=69fbe6a0 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=2VIzI6ABkMI1kr12n-IA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDAwOSBTYWx0ZWRfX3smwIIj2rGXm nWyYKsKcm4cArgNpjclLAv2r3LLJSIk79UUEp5Cb2kcR8tP9e7QqzTG77PVN6Z+GiTkDJE+iaCT x+Dk8Y4dMThb3qEHthWo309GIT8OZN4bisEzk3DpQIyZpTYaQeg4YH3fNfDfFOCWZkF2UfyfDxb KITylEOaQ7C2xFe+9mr75ljfXCKU0tEcrRjUcH/bmhPaOhaN/12EgYCrosLWmqDQAfppfDKqf3v 63h53h6ALCPEVtvnpgx0UKJB+AAxkp0PB2hQitAlZK9B96MOankPhiJCo28LiufyheKPnmzgYJE obGOldYTH8aaZ0G8xsab4agSEHuijTbJZs6/jVdmppPL8XeVsdix6MiGukE3kqbPzY+c/iUqpxx JVPSPvnkg+hWGwOTWDwt+q5D8F38uDn7HLRnYpWeKjocORa8HsagPxxc2pwi0zva1inqcVvPSfn 8qOSjJwfdoVJK96pscA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 spamscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070009 The highest_bank_bit param is specified both in the Iris driver and in the platform UBWC config. Use the platform UBWC configuration instead of specifying it directly in the source. Reviewed-by: Konrad Dybcio Reviewed-by: Bryan O'Donoghue Reviewed-by: Dikshita Agarwal Tested-by: Wangao Wang Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c | 2 +- drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - drivers/media/platform/qcom/iris/iris_platform_gen2.c | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c index aa4520b27739..6dc0cbaa9c19 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c @@ -160,7 +160,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade &payload, sizeof(u32)); - payload = core->iris_platform_data->ubwc_config->highest_bank_bit; + payload = ubwc->highest_bank_bit; iris_hfi_gen2_create_packet(hdr, HFI_PROP_UBWC_HBB, HFI_HOST_FLAGS_NONE, diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h index 08a9529e599b..5639eb5a75b6 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -77,7 +77,6 @@ struct tz_cp_config { struct ubwc_config_data { u32 max_channels; - u32 highest_bank_bit; u32 bank_swzl_level; u32 bank_swz2_level; u32 bank_swz3_level; diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c index 01c6ffa7e084..bdeb92e0b7bc 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c @@ -792,7 +792,6 @@ static const char * const sm8550_opp_clk_table[] = { static struct ubwc_config_data ubwc_config_sm8550 = { .max_channels = 8, - .highest_bank_bit = 16, .bank_swzl_level = 0, .bank_swz2_level = 1, .bank_swz3_level = 1, -- 2.47.3