From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4193B43E4B3 for ; Wed, 17 Jun 2026 10:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692653; cv=none; b=g+l1s1H0V/inOXmm9ug6/vnn7XFDNzDs5/sazLK8Zs6cVyOb3xQ+sScDR/PmiHlI7Hbn6Sm0YZacpx8HqN4YWDual8svF6n7ZfDf/Wu3zmGc7TJyehczu7TK9J9iGas8dFfp2Z9io27uGQBg42zKa2jVj/s6ywNYRhvW05h09/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692653; c=relaxed/simple; bh=yMC2x0vx3J0iXo0ls0Nysns2s/4zDPY2og/b5u+3KjE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IyLMWPL6Yc01CnIBGzpZWCZ7QsKoVxx6/Hq/w/pTmKJErkMAG8FYQzTelHjAZNri/STRqn6AoTULtwXx4ddfxX23zxOL9g+BMnAXxfyvrRAIXJhb0Z1gCgnrfSj689NbY+2jFgy06l+mYAynuXZoShRk8pwANHw09Wu0cFZdtr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aP3JmSrh; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aP3JmSrh" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-30be4a661aeso104398eec.0 for ; Wed, 17 Jun 2026 03:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781692646; x=1782297446; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7eMqE3BBUM7YLjw0Y2Au39yLx+nag/ZXvLG1ZHdqVe8=; b=aP3JmSrh3ecpivpRdrnwAPRgFheRUhfHgbkx8yagzphLyndwN4e3V04eCFRf8dFq8H RPtg4oK/omnE28GTqpz2rwXXlYs1kVa4Y9Uhrdyh5o9rdDhsC4g1AMocK0aNHkpLU3W4 Io8+dVqP2pMFBQy/0Ms7GNBroCynaAP+0IwoeJpZ9xqKYx0ZfbgJ7/GrqouUdS3q+udh dU3gpvtFFuq3LRUIQi6gYtoeqVpJWCCZ+zCekPs8j772Bq/RRlYcPvQao1YvkqZgjfl3 5lQMXIgK+uxsVL0XsXPUJg7lx5eNzV2frEe6j1BwmR1nja6Y92ueaUjhefTgojW96g7l C24A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781692646; x=1782297446; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7eMqE3BBUM7YLjw0Y2Au39yLx+nag/ZXvLG1ZHdqVe8=; b=ArY2e7ADV7O6k1lyOa/5fkVlLDp6Z/DQkh98mySd9gdIY07oBa/pggvH934c9t7VSg aXWIr6drBQsnUV0sYCSyLjPMBDdLdGD0czxBOEYAkfDc6ei6By0YCrDF9FLlKLo8HMq4 944RKGUjhJU19p2wwLPuleL8DkKcLvLDlz/J8ALUgOKRSf/KGLnBpywBpEqxIPPGrfiP fX352BZJrEa+UlJ7JvxCaeRJSYaxrWi2PBZLcK1uXnKYyBz5mAAXmIb9wKL3YF4YPZmo doCrTxAoBhRo8o1PC6trfdNqjDlljy5UmIf5U+m61YSFc1MHhxXeEvq47N2fz/56Lfa7 pRcQ== X-Forwarded-Encrypted: i=1; AFNElJ9tkgsqc9Rb7NuOP/I2IknyUuDbwMJKb5/5+w9a8dD8HwYWNrh2OzRLSDQArFDEy1z8eSX3KPyb2RZlkHiD@vger.kernel.org X-Gm-Message-State: AOJu0YwdcKxHUGBsM/YNyS6GV0B1SUxgpUaCnxHp2r5o2qZ0YELh9KJo gaQm0BxvQqOnkTRgfQT4z7FBrjgrLkhii19vimZmJaoQNDi3nQCenKlM X-Gm-Gg: AfdE7cnHqdz63+HNXON5r0LYCR/YBWNbuP7LesvSUXNwx3I0rW/NG8hM2ogXOUS+gCI 7Xiy4sQAnr64sUzKmapcZ8ICSvMNzMKUo97orkgwnp4nwROd8IoHzZbZfEp73pxqtg+yJ/PMLXc XdhZ1j2vgE8vuLsYjtfhfBC0U5JPhNlmAOjn9a7oEh4fjIejwdDOxZLUOByM0hk78NEI6LvS1+8 qQmJy24H/vrYolG/7/fa+n1T3Qujrnd+1KHz3vccsLnVsjJX1P1caREMEu9DHvJ1Xk86HHDbnA7 xWqMJdD3rfMYVWLw8l6p88zDjSfw3ksV6hMalikiLx4qs8ccnNU2Ze3LPli9/O/87A4+xuBlLRb jcDEAoSNlYoNAbBj+o6ZIhhZoJBrhnCLqCD7FgVV668CclDD/Vxf8V86hL95e6vLVpB7cYjKRG8 RhSNIdd5CXmbeuidQDBq8Sb72qmWV46X1KfFVjKf3Lam6oqrg= X-Received: by 2002:a05:7300:5b95:b0:304:ed85:5f43 with SMTP id 5a478bee46e88-30bca068312mr1553091eec.24.1781692646184; Wed, 17 Jun 2026 03:37:26 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d0828sm24616275eec.10.2026.06.17.03.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 03:37:25 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Cheng-Yi Chiang , Tzung-Bi Shih , Guenter Roeck , Benson Leung , David Rhodes , Richard Fitzgerald , povik+lin@cutebit.org, Charles Keepax , Support Opensource , Nick Li , Herve Codina , Srinivas Kandagatla , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Oder Chiou , Lars-Peter Clausen , nuno.sa@analog.com, Steven Eckhoff , patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bui duc phuc Subject: [PATCH 29/78] ASoC: codecs: es9356: Use guard() for mutex locks Date: Wed, 17 Jun 2026 17:31:46 +0700 Message-ID: <20260617103235.449609-30-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260617103235.449609-1-phucduc.bui@gmail.com> References: <20260617103235.449609-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/es9356.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/sound/soc/codecs/es9356.c b/sound/soc/codecs/es9356.c index 670e918b56a4..1915cce09809 100644 --- a/sound/soc/codecs/es9356.c +++ b/sound/soc/codecs/es9356.c @@ -501,16 +501,16 @@ static int es9356_power_state(struct snd_soc_dai *dai, unsigned char ps, unsigne } /* power state changes are not independent across functions */ - mutex_lock(&es9356->pde_lock); - ret = es9356_pde_transition_delay(es9356, func, pde_entity, ps?ps0:ps3); - if (ret) { - regmap_write(es9356->regmap, - SDW_SDCA_CTL(func, pde_entity, ES9356_SDCA_CTL_REQ_POWER_STATE, 0), ps?ps3:ps0); - es9356_pde_transition_delay(es9356, func, pde_entity, ps?ps3:ps0); - } else - dev_dbg(component->dev, "%s PDE is already %d\n", __func__, ps?ps0:ps3); - - mutex_unlock(&es9356->pde_lock); + scoped_guard(mutex, &es9356->pde_lock) { + ret = es9356_pde_transition_delay(es9356, func, pde_entity, ps?ps0:ps3); + if (ret) { + regmap_write(es9356->regmap, + SDW_SDCA_CTL(func, pde_entity, ES9356_SDCA_CTL_REQ_POWER_STATE, 0), + ps?ps3:ps0); + es9356_pde_transition_delay(es9356, func, pde_entity, ps?ps3:ps0); + } else + dev_dbg(component->dev, "%s PDE is already %d\n", __func__, ps?ps0:ps3); + } if (rate) regmap_write(es9356->regmap, @@ -929,7 +929,7 @@ static int es9356_sdw_interrupt_callback(struct sdw_slave *slave, int count = 0, retry = 3; int ret, stat, reg; - mutex_lock(&es9356->disable_irq_lock); + guard(mutex)(&es9356->disable_irq_lock); ret = sdw_read_no_pm(es9356->slave, SDW_SCP_SDCA_INT1); if (ret < 0) @@ -982,11 +982,9 @@ static int es9356_sdw_interrupt_callback(struct sdw_slave *slave, mod_delayed_work(system_power_efficient_wq, &es9356->interrupt_handle_work, msecs_to_jiffies(280)); - mutex_unlock(&es9356->disable_irq_lock); return 0; io_error: - mutex_unlock(&es9356->disable_irq_lock); pr_err_ratelimited("IO error in %s, ret %d\n", __func__, ret); return ret; } @@ -1092,9 +1090,8 @@ static int es9356_sdca_dev_system_suspend(struct device *dev) { struct es9356_sdw_priv *es9356 = dev_get_drvdata(dev); - mutex_lock(&es9356->disable_irq_lock); - es9356->disable_irq = true; - mutex_unlock(&es9356->disable_irq_lock); + scoped_guard(mutex, &es9356->disable_irq_lock) + es9356->disable_irq = true; return es9356_sdca_dev_suspend(dev); } -- 2.43.0