From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E9EF3749F4 for ; Thu, 23 Jul 2026 04:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784782444; cv=none; b=RRzdXJoNwcwVgN44B2KuVLuLWL3vMH8fqdC/TiY2LOm+2zBq93FjOG/Lz7BcUwxGUuJkHrYzoxIhMUK3hMwdLX2kRMiEyPDapyFp659jkSpp1VdBWLsCL6NUFQYr2wky+HnsN1wZkhbGiMDKRkGCWNWG4BjQZ8aOMXguMcFF1k4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784782444; c=relaxed/simple; bh=Fa/+gfQ3SzEgi11qWxA09O6FM4GPY4YkSzC3+KOzEZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JMF/nQUYUz+n6EclLNpmwMAqvKl1xoCy+UqYiwmfJNHFDj0RQmKpmYp+82BwppszeQWhKs3fbukHQXBqjgfVQNMeaJzFC1d17VIN8ZjFCi6f412I9NMibpE7MM7VshCkXZm2QrP2Dz73hmOy9zj66ZVytaNvwC2uSZ9PHGl9yb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HQ4YxXvW; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HQ4YxXvW" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ceaf8a1265so2791555ad.2 for ; Wed, 22 Jul 2026 21:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784782432; x=1785387232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aWHLEKCAQ5mV1sF9yyFHSMFUTDOduAtPgNwQ5RGsXm4=; b=HQ4YxXvW1HWsL77uOx4M2OlbEr+5qxltlY2cbuZduHJoDw8T00RUDWtWgZO4ioRGvY V2KOC6IAyFIlVIUxNRO0wSNl5NgBmPGePwXpLiydTgrL1YSku/CYRNaISNkmG8vTBCrJ 3uGAzW9mcaW32NGSk5owYwRikwn7dZMXZWLDahqnAlgG4EY/lo9xtxaKwNq4rHVU8Zcq oQLd2E8wwoZzAHn576JoxlXUB0b6Mg4Wl+yO2tFbxNiHGaKo+qo/Ditl8kOefZBUX3ER GpFexxbPzOOFYm9MT0G8PjZfu08FYgyBgd7ZDzuIPm5fevZoMCit7p1oDGtggIr/dZ4r PM+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784782432; x=1785387232; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aWHLEKCAQ5mV1sF9yyFHSMFUTDOduAtPgNwQ5RGsXm4=; b=Fz3AqxglnNnGS2YKMUipZTS3ffTOQRth40Sk0Ikd0zGfRTQ54GvzNZRv/rXj1faHzT s1IRZcn3lNVSxdBbplTezdICQyEbnbsHugA7fyBvqmU93MKRTrsHFNbW4XufQd0QpTBV jolsMk4Y/WHjScqjYmyzg19/N7R9Vblx/taJuJ2CFeYQs6cuxAr2YSGW2KaqQoXagUPw s5rvsQDR3cK/5mXIiqOzIZOMH2zrMYXGHiImhlt1madPc/6EQQ2TQzbXFZMA08c4eMNP x+mTvJTsxqqrnzLD1c9CGjtGiX6IfjPWFcThIYacL9NNA9Q7Lebms4WJk+smNSNu5+26 KW6g== X-Forwarded-Encrypted: i=1; AHgh+Rq8iy2oZPrH2yfnmfAFwZH7dX6xGHIQ7cBWFkAP79E/8GM4JS1HCDcWie2AFj7iKiEz/X9toHlptJe0U9/I@vger.kernel.org X-Gm-Message-State: AOJu0YyQOHR+VjiHQtkIBzFanMF0uWOHVClkA/UztBSCH4ich6uZXlqf wt0IQ78LGA6nJhugGJfuO9hFXmzPz9djhMwk69ae2SxPpYYZY+GjR4Up X-Gm-Gg: AR+sD10wizRGedbmECQFFpUOJ66OZfJiljznMK67oMgKPy5+2IWVo0fM8X5wfBD2oh4 /1i7nnWmeODUjaMeYke3CovOSm6yG8J/0pG//nnGfAcu0M6lUC/UPla4Jp8sGke3irj+nzyJk3U Hq5PKZHz5vw3oxP4EBtm3coG4Phu8RWEgSzpfRMb3U/CaidKIZHDa+P6kJgY30MS1rqc49b6vkE ROIVjopg8NQkpvE6ny2ZSyCvQ1MIgJ9qxsNyaTqsIuPUUKolhlZdGcHS46+dLToUhoN/0OYG4hp Itos6xMWCKMqcCGmgYvygnSlFDZc0Yw0qzc+zARwJoESxTHbj3LFJfbV3PnAeAV9PUnXhNsxuC9 9iq3lteUse6QSs39iS6P2NasUmewi6dem+A5+I3/DPKDYx50O++a+oNw/FebvnVX3RxEFwRNRzO KbRsIZNHmCJvAVegKl55yxAcswaQjJ0GC3b7Ox X-Received: by 2002:a17:902:f544:b0:2c9:97a8:8c17 with SMTP id d9443c01a7336-2cfa71ccbd6mr18632095ad.42.1784782432272; Wed, 22 Jul 2026 21:53:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfa57542e0sm7258365ad.67.2026.07.22.21.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 21:53:51 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , nuno.sa@analog.com, Shenghao Ding , Kevin Lu Cc: Baojun Xu , Sen Wang , Steven Eckhoff , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Linus Walleij , u.kleine-koenig@baylibre.com, Thorsten Blum , Kees Cook , Chen Ni , Bartosz Golaszewski , Shengjiu Wang , Sebastian Krzyszkowiak , Pengpeng Hou , Richard Fitzgerald , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, bui duc phuc Subject: [PATCH 01/26] ASoC: codecs: sigmadsp: Use guard() for mutex locks Date: Thu, 23 Jul 2026 11:53:02 +0700 Message-ID: <20260723045327.28260-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723045327.28260-1-phucduc.bui@gmail.com> References: <20260723045327.28260-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/sigmadsp.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c index 2e08fde3989c..b7dbeb237447 100644 --- a/sound/soc/codecs/sigmadsp.c +++ b/sound/soc/codecs/sigmadsp.c @@ -5,6 +5,7 @@ * Copyright 2009-2014 Analog Devices Inc. */ +#include #include #include #include @@ -135,7 +136,7 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, uint8_t *data; int ret = 0; - mutex_lock(&sigmadsp->lock); + guard(mutex)(&sigmadsp->lock); data = ucontrol->value.bytes.data; @@ -148,8 +149,6 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, ctrl->cached = true; } - mutex_unlock(&sigmadsp->lock); - return ret; } @@ -160,7 +159,7 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, struct sigmadsp *sigmadsp = snd_kcontrol_chip(kcontrol); int ret = 0; - mutex_lock(&sigmadsp->lock); + guard(mutex)(&sigmadsp->lock); if (!ctrl->cached) { ret = sigmadsp_read(sigmadsp, ctrl->addr, ctrl->cache, @@ -174,8 +173,6 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, ctrl->num_bytes); } - mutex_unlock(&sigmadsp->lock); - return ret; } @@ -677,10 +674,10 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp, return; changed = snd_ctl_activate_id(card, &ctrl->kcontrol->id, active); if (active && changed > 0) { - mutex_lock(&sigmadsp->lock); - if (ctrl->cached) - sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); - mutex_unlock(&sigmadsp->lock); + scoped_guard(mutex, &sigmadsp->lock) { + if (ctrl->cached) + sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); + } } } -- 2.43.0