From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17E814A498A for ; Wed, 7 Oct 2026 12:40:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791376816; cv=none; b=D6QUjSV9ev3l7g3/coydnGVRZfOdwlcA2my5Dvmz7mCgZ83ci5XsMEp9tfAi7S0AiAG3UduT+cfkl+SrVYvfD7+3efqBNkanimbio9fevkejsA/Er7B8RDi5DRWJw1VC9Ye1lC7gDVZKxmE6MJcHiDwPcfFvOkFy56x8PEOrb/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791376816; c=relaxed/simple; bh=gvlnRPbIuQpBNlIetJA1tcoffwd0qPM41kLziATxBNQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ep0syVfTWkZNd7QymQBIomWo2NgtQXqDkZOSvQgTD7n7cGHEQ1J5ofmgcBc/XWBhjUXG49IFFiia2bsJRgJRsjeUkpkl32Bwd7REhf65txDeyfWJd4rrlUqQH6X5cVJ+0qHsw4zFI/S2t8tOaSgEhSbSwUkVLb/9qo03Zo2CnNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XTPXz2PY; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XTPXz2PY" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2dfa54c8ccfso10189995ad.0 for ; Wed, 07 Oct 2026 05:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791376807; x=1791981607; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=lJssbI+xGs6ktfsC6Xw3DX5y7Ljs3Vvy25+XSMvy+cY=; b=XTPXz2PYjgwqLYr/+KzYv1mgR6TQ93ZOQ85RnJchI3nMOQx5cq/fwUHtAESlF71XpC a3xa3vUXerbShiA9FAbBNBLA47tv0zHBqfvwnYMXCEFXNCgParFFax+RUqNx3AjCjVoW a/in+Mqzf8rnhDp+F5+FP0kff69nmS8C+JjFAXj8LESgMPc6xbSbl3NxHFzpIKRx/c/S Pl+AjSa3nVsP3qpxY4EiXrtTVAgU1bwLS1J0EATgr6XHYJNAx/gnIjAaxPdp7kfV07bf dnT/SZlAA+VmrdCp0JLcachYIElvHzfo1Tmzc0wTVF0Cxe2GIDOdbfev4TmWuHZa7mIQ qF4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791376807; x=1791981607; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lJssbI+xGs6ktfsC6Xw3DX5y7Ljs3Vvy25+XSMvy+cY=; b=V1YASMgy9N58RA6uj2Td6Z58ZLqsb9jCT7iqw8Ox9G+kTX1MQbiXTw2HyfPdfF2DZm xVdh6N64w/Dyhag8Hu6hQD8k9YSh6ye67ZGCBb6ySICGvLCSfocHjokB1Y3AGLuIdIxQ 7WAuEQ/92rKhHdKFFBRUzNpif770HwgLMgg9n3a7wj4InGfhDb/qlbGQLtxGHrAq42t4 L7ABSpnxIbmvqu434YNV5DAsBWppPqzprJwqLXasbKIIR9rZ2s4j2qx91FRj/uTUW+jG LcBeJ0FFvVoKuD4WBfpPtkZg5d+NFWatcrCBUCcDyqBSM9BN1+t0CtDq1Lk+/Yr1pPRL Q/Yg== X-Forwarded-Encrypted: i=1; AKwUvBxkrLgl2rHD2ETIjUvFjALaDLGTYJEeRaGAwB7yt3Lw81a7Q6r4xGndR/2nNdCWw4ylZRNYVvLSoWnj531G@vger.kernel.org X-Gm-Message-State: AFq9FYK9GGR7gd+If4sZHXz8DK7kc68WziPtW8CczJFSfRGQE/JIkMvq rVMZQpSR9Qr62Z5PFAwzvbXNOtFAHmTaN/0w8TTLMff+yT0q74FiWxpdbwS6+WbAo24= X-Gm-Gg: AYBFou2DS62QDJ78IYCTgo4+9rJGPHVAvbreEJvnxb+seIS+wxqPQjeSMajQ5M1XSKl ZybRukXxDMOHn+OTDOSTBT0dUs57om41Wxpv+pqDDhwO7Mm63cz0Vq0Eus4aJ8e96oqj+tr1gZe LkCsi9EkX+f665rVE5DMd0AcUz6428MoaeL8xz+gIKqpcby31qgcmrySM8QBmUhdIGnYbN+XsYX RRHyZ3um/5h1703z4y5ijdPZ0yIXYcRyceCHlEZlCqFwcNcZSZ6MBWQhyAGydla2lB0qlf1ykzv MJHChyN7Mdb0H17IFWtMmGwyYSennReFMGLs8/ApKQocIoBZdaV+zpRMEQHpepF3E7IqrvoaIPC KuiQUJUEjmHFHdhh4Iq6Ah1KiEronIwcZd7Pu2NGEsg8NyI0TanKQq1WJXMqre3zhoAdTp22uuP bBl6BQkPiUGpOZ4w6DnqyHOKJ1dw/eVHGh5jNzfGAE+StspA0wjHf34YZQtu/PlOVzJ6B/JInpM EpW6l43tDlf1AI= X-Received: by 2002:a17:903:248:b0:2e3:cac:3868 with SMTP id d9443c01a7336-2e60050922cmr15218765ad.24.1791376806392; Wed, 07 Oct 2026 05:40:06 -0700 (PDT) Received: from DESKTOP-NM9EKIA ([125.134.240.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e6046fd284sm9675095ad.15.2026.10.07.05.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 05:40:05 -0700 (PDT) From: Joonhoe Kim <26rote@gmail.com> To: andersson@kernel.org, linusw@kernel.org, brgl@kernel.org Cc: konrad.dybcio@oss.qualcomm.com, jingyi.wang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: qcom: kaanapali: add the I2C strong pull-up bit Date: Wed, 7 Oct 2026 21:40:01 +0900 Message-ID: <20261007124001.1724-1-26rote@gmail.com> X-Mailer: git-send-email 2.55.0.windows.5 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Kaanapali TLMM has the I2C pull-up control in bit 13 of the pin config register, like SM8550, SM8650 and X1E80100, but the driver does not describe it, so "bias-pull-up = <2200>" cannot select the strong pull-up. The downstream kernel sets it on the camera CCI pins (config 0x2007). On a Lenovo TB323FU tablet, with only the weak pull-up every CCI transfer on the two sensor buses times out; with bit 13 set the sensors answer and their chip IDs read correctly. Fixes: 35ff9c6b318a ("pinctrl: qcom: add the tlmm driver for Kaanapali platforms") Assisted-by: LLM Signed-off-by: Joonhoe Kim <26rote@gmail.com> --- The board uses it as "bias-pull-up = <2200>" on the CCI pin states; the Kaanapali CCI nodes in the CAMSS series (v18) use plain bias-pull-up, which keeps the weak pull-up. Tested on v7.3-rc4 with a test switch that clears bit 13 when the pin state is applied, rebinding both CCI controllers each time: with bit 13 cleared the two sensors and the VCM on those buses failed with CCI timeouts 3 times out of 3, with it set they probed 3 times out of 3. drivers/pinctrl/qcom/pinctrl-kaanapali.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/qcom/pinctrl-kaanapali.c b/drivers/pinctrl/qcom/pinctrl-kaanapali.c index e95ac064b84c..e9351e29d38e 100644 --- a/drivers/pinctrl/qcom/pinctrl-kaanapali.c +++ b/drivers/pinctrl/qcom/pinctrl-kaanapali.c @@ -37,6 +37,7 @@ .mux_bit = 2, \ .pull_bit = 0, \ .drv_bit = 6, \ + .i2c_pull_bit = 13, \ .egpio_enable = 12, \ .egpio_present = 11, \ .oe_bit = 9, \ -- 2.43.0