From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.174 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793657115; b=C5GIYQmhyVS916XxsovoDcMHh+r/E11fdRYDedA7f/QFrP5aGgk3+MqT1wQpOTFJ/RwV oT0OuYV+pqFLwWxF/nt0WlCTJgGQHjnr3muJxIrYLZyIFm9BPgfTlf9UbY4ryS8qWzTJG OaTHDcsE8oi1oNFjbjrXqfOKzAGAwxLdJFloWvRgIGaYkXhdjoDqrnuFI8B/Bl93U1mS3 jcrFqfsuwxPUK4LHa5+3ATQsqCsJ7VMqBwRRQxhcobDbVGC+peGis1cyxY/YKb6fQ8fK9 ztijqBgirDXnqdymSY0CYfRVfD90MKnDlN04nbzx37QuPz98RG2pjPrwc4yjz+QFRcg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793657115; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=po9LaFR4COBNDjXRaH0sos9yo8To8XsMCK5cpaZoeE0=; b=vY9fylFij5E/Ew5UNdGVezx98/BpEEm3vh2Wyd4uJw1Kpz6MlWKd/Sz837ZIQPi3laEX 8f7wc8XRmnLNVMiF2NIKJvE70iX24SqxxapO8cDIdevLrESBVw81GPScBXbzNCVFUZPm+ rKyw1Jw5yehCRwsnr+CncpBBinD/oACPNJIysLvqeTWUeIp8EenqmnhxdmL+faKAaHEBz q6nG/ZL+DhF+kVGJJ9H/h0FGNLW4xLB7aA2gPaZHcUTRPiUe55a8wCfTkIrDvKihbRaN8 jBvH/HgY170gKMAfABIDaf2ugOIkB2/6YmjiefyY69XjJI9kl2M3hepeqhsyZbLdbXg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=JgsAov36; arc=none smtp.remote-ip=74.125.82.174 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4600B606EEAA for ; Mon, 2 Nov 2026 22:05:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4600B606EEAA Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=JgsAov36 Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-36a315ed211so122162eec.0 for ; Mon, 02 Nov 2026 14:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793657114; x=1794261914; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=po9LaFR4COBNDjXRaH0sos9yo8To8XsMCK5cpaZoeE0=; b=JgsAov36eHCi4xcxestGz2HdshrJ6ho9n42lUOpL6lQKXpCOfBnFjnryy5u/3Azz2R QBtXmKBE3qHG+ej0F5TintEHwkU0I+8of94h0KvhAr7BAoyXbzqsaz3k0dHYzSvxt0mh o9A8yJabfYDnFshUU1blgx1XfoBhbZJKvCM2n/P+aj3JfgvU5o8LMzckGXLJRLE8RmOb 1+prHhFrgG8VBkIw5oi/uib42Kh+n3PbXGiU3YCJX/Oqyel0V0ZDbMGMO+s/L4PS9HIg lWFDXvfliB3FFhQThiqrrtnABhPt+I2JzcIfkxI0MRNb4e8X8kTqIoLfG9HDNyaGjXPM X3iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793657114; x=1794261914; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=po9LaFR4COBNDjXRaH0sos9yo8To8XsMCK5cpaZoeE0=; b=MZQh57Muznad+aHsetQN1CuJoqpqtMy4uNI6iCABqf+JefN8jbOirx1eSetKpI4kD4 LFEirUwTqQOFECTRTJBXik4Df6KA0JTR1pZ84IHh+H/VI5Pj82thGia2UTCiM7zHrr1j h4yeb/9cHwf2rZcDNYsCzB287Xe0tnivksD8eQT8lV4xtDAle2a9x4uhrsKikj+OaEjF GkzrhJE84a3Dh9gFEEloep7Vq0Bi9/8Dq1YQ7qeQQEAUItE5GStHtwtnjxdCBqaVPQo4 rLV2xy8oiEwjhPsCTjSmuczdakiY/9vniWYpxdme4F7bG8W3KU49GwtoG4FoWbMpnr6R s1XA== X-Forwarded-Encrypted: i=1; AKwUvBwa/t0S48GpGYuo0vqAQOddu0ItjhLldIsqk6BPIZADJhA058rxUCGOLmy0TWFA8UjY+D3w3K1pg/hLr8eP@vger.kernel.org X-Gm-Message-State: APuU4Z94YSYDe8svPEuCsiQ8qkyEYG3IpTxpTRmnxWEX+vGmm3ShJhQA RwKqFfRxMVYZF68iYTdVa2q0l+itoCSCcSDexBu/gXXUx1O6p/9gTcbC X-Gm-Gg: AYBFou1uei3uJ/+4lJlLlTMx0NZH2+6J11rmYXdDabOpu9zld62lfujZ3AU6ml0iDV3 m2ninaNBy1VfQdqJj4YwEbwYaleSnBDbsb8yaLpbMCAxWOYmu89hDJygytApD9kzXJxxRijRHxm 5m9SXYetYFqnxRhcHghQ/6d4QY1t78KAenUwU96/wlmZ1JvHcQreHI7jRUM7kLDcTItQ6/7/lBl HY5nsBu/Hl3HGLY9V4Gy4DlKwnlawnhh6g3biTI622qCNH/f37B51du9qYeSxAK7zYQxp/EU5Pf D2d5++CuusVk95p0oDpFrjp410bRyRdaAj2rpA5hciFIrKez5DrKfVGQasUZNATmngDzoKT3oGr 760Tr/hxrX4dbroz3teyOmZzjrwdwZpd9qlxT46sqoe/MjJUlxBxB5rc+XXpEqfm10tsVE9DHAk hBy4QvvCEB6YfE5zYy7Ki43nYigsJAvpFDWRDL7dx/OXcm2k69TKCq4cQybt8xgS9o949x1X4NV k109QTrs+aWh+NOzJsw28lrai77a0YJjIJ0BsPs1zNhHkILwe0X4KiQXajj9a3s6CXKoguLrNPi qzfuXNLEKa2nK6xs9zkTTyp6fW6m1q72C8sgNHu8SwLP1tzQAiHIqRWlxjISjd2XCA== X-Received: by 2002:a05:7301:4d12:b0:369:dc59:7a6f with SMTP id 5a478bee46e88-36a422042d2mr15983030eec.1.1793657114197; Mon, 02 Nov 2026 14:05:14 -0800 (PST) Received: from DESKTOP-NM9EKIA ([125.134.240.130]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36a4291e38fsm46670346eec.15.2026.11.02.14.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 14:05:11 -0800 (PST) From: Joonhoe Kim <26rote@gmail.com> To: Vladyslav Tymoshchuk Cc: andersson@kernel.org, konradybcio@kernel.org, abelvesa@kernel.org, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, sre@kernel.org, krzk@kernel.org, lumag@kernel.org, casey.connolly@linaro.org, johan@kernel.org, jishnu.prakash@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com, daniel@quora.org, neil.armstrong@linaro.org, kees@kernel.org, gustavoars@kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/4] soc: qcom: pmic_glink: Hold back notifications over system sleep Date: Tue, 3 Nov 2026 07:05:09 +0900 Message-ID: <20261102220510.1721-1-26rote@gmail.com> X-Mailer: git-send-email 2.55.0.windows.5 In-Reply-To: <20261022164151.592-1-tvlad744@gmail.com> References: <20261022164151.592-1-tvlad744@gmail.com> X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I tried the series with suspend-to-idle on a Lenovo Y700 Gen 5 (TB323FU, Kaanapali/SM8850, FSA4480 on the SBU lines). This is v7.3 with out-of-tree board support. v7.3 does not have c7c56b6ec077, and I left the UCSI connector work on system_wq as well. So only the series kept the workers off the suspended devices. Without it, this setup crashed on a DP sink unplugged during suspend, as in [3] of your cover letter. - Monitor (pin assignment C) unplugged during suspend, default wakeup settings: the UCSI notification woke the system within a second. The held-back notifications were passed on right after the tasks were thawed. The altmode worker, fsa4480_set() and the UCSI connector work ran only then. No I2C errors, no reset. - The same with ucsi_glink wakeup disabled: no wakeup. The notifications waited until the power key and were passed on after resume. - Charger plugged in during suspend, qcom_battmgr wakeup enabled and ucsi_glink wakeup disabled: woke up 0.3 s after the plug-in. Two things I saw on this board, both the same without the series: - Plug-in of a DP sink during suspend (two runs with the series and one without, each after an unplug during suspend in the same boot): the firmware sends an altmode notification right away and a DP one 13 s later. The UCSI connector change only comes 13 s after that, so the system wakes up 26 s after the plug-in. - After an unplug during suspend, the DP controller is resumed before the held-back altmode notification is passed on. It tries to train the link to the monitor that is gone (about 10 s of timeouts), which delays passing on the notifications by as much. It also leaves the DP PHY initialised. So on the next resume the USB PHY init times out and the dwc3 resume fails with -110. The plug-in runs above ended that way, without USB. A plug-in during suspend after a fresh boot, without the series, does not hit the PHY problem. It still ends without a display, for another reason in UCSI; I'll report that separately. Tested-by: Joonhoe Kim <26rote@gmail.com> # SM8850 Thanks, Joonhoe Kim