From: Ard Biesheuvel <ardb+git@google.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
linux-arm-msm@vger.kernel.org
Subject: [PATCH 5/7] arm64: dts: qcom: c630: Wait for the touchpad at resume
Date: Wed, 11 Nov 2026 12:53:09 +0100 [thread overview]
Message-ID: <20261111115303.3749380-14-ardb+git@google.com> (raw)
In-Reply-To: <20261111115303.3749380-9-ardb+git@google.com>
From: Ard Biesheuvel <ardb@kernel.org>
When the SoC reaches deep sleep (AOSS sleep and CX collapse) in suspend
to idle, the touchpad is often reset, presumably because it loses power,
and it may still be starting up when it is powered on again at resume.
If it doesn't acknowledge the power on command, i2c-hid tries once more
0.5 ms later, and then fails the resume:
[ 712.566907] i2c_hid_of 3-0015: failed to change power setting.
[ 712.567528] i2c_hid_of 3-0015: PM: dpm_run_callback(): i2c_hid_core_pm_resume [i2c_hid] returns -6
hid-multitouch then never puts the touchpad back into touchpad mode, so
it stays in the mouse mode it starts up in, without two-finger
scrolling, until the next suspend and resume.
This happened after about one in eight suspends. With a debug patch that
keeps trying, the touchpad answered the next attempt, about 6 ms later,
each time it had missed the first two.
So give the touchpad a post power on delay of 20 ms, which i2c-hid-of
waits for at probe, and at every resume before powering the touchpad on,
as the touchpad isn't a wakeup source.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 3e4df4335be8..accd80005195 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -496,6 +496,8 @@ tsel: hid@15 {
hid-descr-addr = <0x1>;
interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
+
+ post-power-on-delay-ms = <20>;
};
tsc2: hid@2c {
--
2.56.0.611.g1030f0b940-goog
next prev parent reply other threads:[~2026-11-11 11:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 11:53 [PATCH 0/7] Lenovo Yoga C630 (sdm845) fixes Ard Biesheuvel
2026-11-11 11:53 ` [PATCH 1/7] arm64: dts: qcom: sdm845: Bump fastrpc shared DMA pool to 32MB for 16k pages Ard Biesheuvel
2026-11-11 14:42 ` Abel Vesa
2026-11-11 11:53 ` [PATCH 2/7] arm64: dts: qcom: c630: Use LN_BB_CLK2 as the eDP bridge reference clock Ard Biesheuvel
2026-11-11 12:43 ` Dmitry Baryshkov
2026-11-11 13:15 ` Ard Biesheuvel
2026-11-11 13:45 ` Ard Biesheuvel
2026-11-11 11:53 ` [PATCH 3/7] arm64: dts: qcom: c630: Enable DisplayPort alt mode Ard Biesheuvel
2026-11-11 12:50 ` Dmitry Baryshkov
2026-11-11 14:42 ` Abel Vesa
2026-11-11 11:53 ` [PATCH 4/7] arm64: dts: qcom: c630: Use the idle states from the ACPI tables Ard Biesheuvel
2026-11-11 12:56 ` Dmitry Baryshkov
2026-11-11 14:42 ` Abel Vesa
2026-11-11 11:53 ` Ard Biesheuvel [this message]
2026-11-11 12:22 ` [PATCH 5/7] arm64: dts: qcom: c630: Wait for the touchpad at resume Ard Biesheuvel
2026-11-11 12:58 ` Dmitry Baryshkov
2026-11-11 13:16 ` Ard Biesheuvel
2026-11-11 12:56 ` Dmitry Baryshkov
2026-11-11 11:53 ` [PATCH 6/7] platform: arm64: lenovo-yoga-c630: Disable the EC interrupt while suspended Ard Biesheuvel
2026-11-11 12:57 ` Dmitry Baryshkov
2026-11-11 11:53 ` [PATCH 7/7] platform: arm64: lenovo-yoga-c630: Expose the keyboard backlight as an LED Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111115303.3749380-14-ardb+git@google.com \
--to=ardb+git@google.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=ardb@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=lumag@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox