Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Jesse Casco <jesse.casco@gmail.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>
Cc: Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Jim Martin <jimmartin@gmail.com>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org
Subject: [PATCH 0/2] drm/msm/dp: make the eDP 1.4 LINK_RATE_SET path work
Date: Fri, 20 Nov 2026 14:20:48 -0500	[thread overview]
Message-ID: <20261120192050.73315-1-jesse.casco@gmail.com> (raw)

The eDP 1.4 link-rate table support picks a LINK_RATE_SET index in
dp_panel, but the selection never reaches link training: only rate and
num_lanes are copied into link_params, so LINK_RATE_SET is never
written and the rate-set fallback branch can't run. Patch 1 carries
the fields through. Patch 2 fixes the fallback once it is reachable,
so it stops at the lowest table entry instead of dropping to a standard
rate the sink was not told about.

I found this while bringing up an ASUS Zenbook A16 (Glymur), whose eDP
1.4 panel lists 1.62, 2.7 and 5.4 Gbps in SUPPORTED_LINK_RATES. At boot
the firmware has left LINK_BW_SET at 0x14, so dp_panel picks the
LINK_BW_SET path. When the compositor starts and the link caps are read
again, LINK_BW_SET reads 0 and dp_panel selects the rate table, but
without patch 1 that selection never reaches link training. With the
series the link trains through LINK_RATE_SET (5.4 Gbps, 4 lanes).

With a test-only change that fails the first clock-recovery attempt,
the fallback moves to index 1 and the panel trains at 2.7 Gbps,
reading back LINK_RATE_SET=0x01. The lowest entry of this panel's table
is RBR, so patch 2 does not change behavior here.

I tested on the A16 with a next-20261103-based kernel; the patches
apply unchanged to next-20261119. They touch dp_ctrl.c alongside
"drm/msm/dp: don't fall back to a link that can't carry the eDP
mode" [1], and the two apply in either order.

Jim, Cc'ing you as mentioned off-list: Omarchy's arm64 kernel carries
patch 1 as 2367 with your 2368-2371 on top, and your 2369 covers what
patch 2 does. I'm happy to drop patch 2 if you post yours.

[1] https://lore.kernel.org/r/20261115000021.78869-1-jesse.casco@gmail.com

Jesse Casco (2):
  drm/msm/dp: carry the eDP rate-set selection into the link parameters
  drm/msm/dp: stop the rate-set fallback at the lowest table entry

 drivers/gpu/drm/msm/dp/dp_ctrl.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)


base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
-- 
2.56.1


             reply	other threads:[~2026-11-20 19:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 19:20 Jesse Casco [this message]
2026-11-20 19:20 ` [PATCH 1/2] drm/msm/dp: carry the eDP rate-set selection into the link parameters Jesse Casco
2026-11-20 19:20 ` [PATCH 2/2] drm/msm/dp: stop the rate-set fallback at the lowest table entry Jesse Casco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120192050.73315-1-jesse.casco@gmail.com \
    --to=jesse.casco@gmail.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=jimmartin@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox