linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes
@ 2025-07-28  9:34 Loic Poulain
  2025-07-28 12:10 ` Dmitry Baryshkov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Loic Poulain @ 2025-07-28  9:34 UTC (permalink / raw)
  To: andersson, konradybcio
  Cc: robh, krzk+dt, linux-arm-msm, devicetree, Loic Poulain

The host controller supports HS200/HS400 and HS400 enhanced strobe mode.
On RB1, this improves Linux eMMC read speed, from ~170MB/s to 300MB/s.

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/qcm2290.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
index f49ac1c1f8a3..72503c1d0532 100644
--- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
@@ -953,6 +953,11 @@ &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>,
 			qcom,ddr-config = <0x80040868>;
 			bus-width = <8>;
 
+			mmc-ddr-1_8v;
+			mmc-hs200-1_8v;
+			mmc-hs400-1_8v;
+			mmc-hs400-enhanced-strobe;
+
 			status = "disabled";
 
 			sdhc1_opp_table: opp-table {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes
  2025-07-28  9:34 [PATCH] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes Loic Poulain
@ 2025-07-28 12:10 ` Dmitry Baryshkov
  2025-07-29  9:22 ` Konrad Dybcio
  2025-08-12  3:04 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-07-28 12:10 UTC (permalink / raw)
  To: Loic Poulain
  Cc: andersson, konradybcio, robh, krzk+dt, linux-arm-msm, devicetree

On Mon, Jul 28, 2025 at 11:34:26AM +0200, Loic Poulain wrote:
> The host controller supports HS200/HS400 and HS400 enhanced strobe mode.
> On RB1, this improves Linux eMMC read speed, from ~170MB/s to 300MB/s.
> 
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm2290.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes
  2025-07-28  9:34 [PATCH] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes Loic Poulain
  2025-07-28 12:10 ` Dmitry Baryshkov
@ 2025-07-29  9:22 ` Konrad Dybcio
  2025-08-12  3:04 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-07-29  9:22 UTC (permalink / raw)
  To: Loic Poulain, andersson, konradybcio
  Cc: robh, krzk+dt, linux-arm-msm, devicetree

On 7/28/25 11:34 AM, Loic Poulain wrote:
> The host controller supports HS200/HS400 and HS400 enhanced strobe mode.
> On RB1, this improves Linux eMMC read speed, from ~170MB/s to 300MB/s.
> 
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm2290.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> index f49ac1c1f8a3..72503c1d0532 100644
> --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> @@ -953,6 +953,11 @@ &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>,
>  			qcom,ddr-config = <0x80040868>;
>  			bus-width = <8>;
>  
> +			mmc-ddr-1_8v;
> +			mmc-hs200-1_8v;
> +			mmc-hs400-1_8v;
> +			mmc-hs400-enhanced-strobe;

These were always asked to be deferred to device DTs.. But it
seems like these are indeed controller properties.. I suppose
I'll submit a cleanup

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes
  2025-07-28  9:34 [PATCH] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes Loic Poulain
  2025-07-28 12:10 ` Dmitry Baryshkov
  2025-07-29  9:22 ` Konrad Dybcio
@ 2025-08-12  3:04 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2025-08-12  3:04 UTC (permalink / raw)
  To: konradybcio, Loic Poulain; +Cc: robh, krzk+dt, linux-arm-msm, devicetree


On Mon, 28 Jul 2025 11:34:26 +0200, Loic Poulain wrote:
> The host controller supports HS200/HS400 and HS400 enhanced strobe mode.
> On RB1, this improves Linux eMMC read speed, from ~170MB/s to 300MB/s.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes
      commit: 1d363a6cf8a2627f31bc3609a0fa9d85dfb0d9dc

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-12  3:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-28  9:34 [PATCH] arm64: dts: qcom: qcm2290: Enable HS eMMC timing modes Loic Poulain
2025-07-28 12:10 ` Dmitry Baryshkov
2025-07-29  9:22 ` Konrad Dybcio
2025-08-12  3:04 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).