Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Shawn Guo <shengchao.guo@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
	trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Subject: Re: [PATCH v3 3/5] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms
Date: Fri, 27 Feb 2026 08:35:15 +0100	[thread overview]
Message-ID: <20887046-26c3-47dc-9cc5-c537f8d90772@kernel.org> (raw)
In-Reply-To: <22273aee-73b5-4747-a2d4-6edce5102092@oss.qualcomm.com>

On 27/02/2026 06:52, Jingyi Wang wrote:
> qcom,milos-pas.yaml
> qcom,sa8775p-pas.yaml
> qcom,sc7180-pas.yaml
> qcom,sm8150-pas.yaml
> qcom,sm8350-pas.yaml
> modifying pas-common means we need to add explicit list in each file,
> (also we need to add constraint for smem-state)
> 
> To avoid affecting the existing yaml bindings, we assume below
> Option2: have a new common file for soccp yaml with "pong"
> interrupt along with 4 corresponding "smem-state"
> 
> the example will be like:
> kaanapali-soccp.yaml ref with soccp-common.yaml. and the common yaml
> will be very much pas-common.yaml content, while the interrupt and
> smem state will be updated.
> 


I don't understand how many files you want to have. Two new files, so
three common files?

You need one place for definition of common properties, so all
smem-states and smd/glink-edge. The interrupts don't have to be there at
all. They were placed because some devices have similar constraints and
the lists should be shared. If the list anyway cannot be shared via
common file, just move it to individual schemas. The other common bits
like clocks and power-domains also make little point in the common file
if they are not actually fixed (thus common).

Best regards,
Krzysztof

  reply	other threads:[~2026-02-27  7:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23  9:13 [PATCH v3 0/5] Add initial remoteproc support for Kaanapali SoC Jingyi Wang
2025-12-23  9:13 ` [PATCH v3 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP Jingyi Wang
2025-12-23 13:02   ` Krzysztof Kozlowski
2025-12-23  9:13 ` [PATCH v3 2/5] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP Jingyi Wang
2025-12-23 13:07   ` Krzysztof Kozlowski
2025-12-24  2:44     ` Jingyi Wang
2025-12-23  9:13 ` [PATCH v3 3/5] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms Jingyi Wang
2025-12-23 13:29   ` Krzysztof Kozlowski
2025-12-24  3:16     ` Jingyi Wang
2025-12-24  8:34       ` Krzysztof Kozlowski
2026-02-13  1:22         ` Shawn Guo
2026-02-26 17:12           ` Krzysztof Kozlowski
2026-02-27  5:52             ` Jingyi Wang
2026-02-27  7:35               ` Krzysztof Kozlowski [this message]
2025-12-23  9:13 ` [PATCH v3 4/5] remoteproc: qcom: pas: Add late attach support for subsystems Jingyi Wang
2025-12-23 20:15   ` Dmitry Baryshkov
2025-12-24  3:20     ` Jingyi Wang
2025-12-23 22:15   ` Stephan Gerhold
2025-12-24  4:43     ` Jingyi Wang
2025-12-26  2:10   ` kernel test robot
2025-12-23  9:13 ` [PATCH v3 5/5] remoteproc: qcom_q6v5_pas: Add SoCCP node on Kaanapali Jingyi Wang
2025-12-23 20:15   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20887046-26c3-47dc-9cc5-c537f8d90772@kernel.org \
    --to=krzk@kernel.org \
    --cc=aiqun.yu@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    --cc=shengchao.guo@oss.qualcomm.com \
    --cc=sibi.sankar@oss.qualcomm.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox