From: Marcel Holtmann <marcel@holtmann.org>
To: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Cc: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Bluez mailing list <linux-bluetooth@vger.kernel.org>,
robh@kernel.org, hemantg@codeaurora.org,
linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org,
tientzu@chromium.org, seanpaul@chromium.org,
rjliao@codeaurora.org, Yoni Shavit <yshavit@google.com>
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Bug fixes while collecting controller memory dump
Date: Wed, 5 Feb 2020 13:52:05 +0100 [thread overview]
Message-ID: <20C0BA0B-1069-4DCF-A8FA-3B6359621D30@holtmann.org> (raw)
In-Reply-To: <d89347d22c12ffca5ccf4e18e0c716ab@codeaurora.org>
Hi Venkata,
>> Hi Venkata,
>> Per our earlier review on chromium gerrit:
>> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1992966
>> I'm not too keen on the change from mutex to spinlock because it's
>> made the code more complex.
> [Venkata] :
>
> We have moved from mutex to spinlock as timer callback function is getting executed under interrupt context and not under process context.
can’t you use a delayed workqueue for this?
Regards
Marcel
prev parent reply other threads:[~2020-02-05 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 16:15 [PATCH v1] Bluetooth: hci_qca: Bug fixes while collecting controller memory dump Venkata Lakshmi Narayana Gubba
2020-02-04 23:10 ` Abhishek Pandit-Subedi
2020-02-05 8:03 ` Marcel Holtmann
2020-02-05 12:48 ` gubbaven
2020-02-05 12:52 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20C0BA0B-1069-4DCF-A8FA-3B6359621D30@holtmann.org \
--to=marcel@holtmann.org \
--cc=abhishekpandit@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=gubbaven@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
--cc=robh@kernel.org \
--cc=seanpaul@chromium.org \
--cc=tientzu@chromium.org \
--cc=yshavit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox