From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67EBC1386DF for ; Thu, 15 Feb 2024 10:41:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707993700; cv=none; b=H6kooxl6L/U4fSdgVR+OPCi+/W3qlLJSaiD0fYyOzAvepIwVmYj7pddtgITnquLbQ+rIGmonRgebJ8yxwa9v80BETvTq44xDfaSaVzK68gCd481bfRa6328Gv+qDRc119/LfrKxUNkOOMYDCDqcwMF+t/1PYwPOoGDbJIQ5LooM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707993700; c=relaxed/simple; bh=89kL2m38VBLYpfi08xjvcphV/ms31WL7c/6vBV5WjpU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YJdu1oGVjuKv6gOcDup2puoReL3TZPXsjTnlqm1EZCCngBJOsAclXnswzxhZMH77nyCdUjvR7z6fZLMunOplfhh+58ENADiznXIOq8RzbOKTVjsvqsnJ5iP8j6rQMBtHQXwciNWnMj2krJoFl52X6MCzthpsagvtcnDCaZ7tuxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xqZ8IFgw; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xqZ8IFgw" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5116ec49365so893085e87.3 for ; Thu, 15 Feb 2024 02:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707993696; x=1708598496; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VUYBcKj53WAi3y6gltiMvu5JfERqWvi9YPUJbVOf3Mo=; b=xqZ8IFgwUXKumSOUVZAIsE0FgE4GYClyDu3Vl9k/AxbjuLtH0kQeMDXvcjb+Xbt3LY fsHyeJMIF/NT5CWUElsZ+p+9DabFV6VRAogrsYH7IcrJB64hzHSw/aKogwwNGB1lKfLu g+rrfTps2TJa7zi8/NGRw+PxEobtTT0PMz+RA0G1VofzxPbCOASoyqj3qRruNmGRBNjb UhzW6i0o0KS8msLx6/jz7XZdxgVoxfZtQ0o4D9XEUOYxdOnWaAiBBA/y8vQ90L1TJCXP mJaiwhk2QYTtWuLSLEK47S3i/P9hwy/pPc1I/QPpMON8G+9aL+tDEC0PYqbkEcVg4rRt xOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707993696; x=1708598496; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VUYBcKj53WAi3y6gltiMvu5JfERqWvi9YPUJbVOf3Mo=; b=K5im05tkZ1HfTi53jcYU4Qjz3OnyEurpB2JsyYbNRcwdZt0Og8BuizYt2AB2fVwPNC hjoI/S5KLQN4r8fjeNd5P9QaEOYy6Gnkn1Pw5Tv/hk+lWyoS36ib8TwjxVH2cSoQCZMS BqGC255kZ2n+n9R6paIwTl6tYNDmJZcVQC11hddZSzhwQtw0+6jrWUuCw/+PSbxnH4gh etab5z2DXPieh3+cpkyAWpJkaJmpGhRd+m99bZOcaqlWW7Ip1d4hkk04Et3wqH6aEZAP hSg1OpeRcYDwcbRbVi9eB5k1mnfXbifemWWg0XkvCRcIMpltTbiDsHOH8sFOuRu8uDqs C/6g== X-Forwarded-Encrypted: i=1; AJvYcCXt7eGwXljKwCXjxN+k9FYqswvgXrvG1WE0mXXcC/fHvTPL3XHgN01bKm5v9LN8P0ir+bHNHfKZhLzaPWIjayn21SelWA3z8xAMJQYyvA== X-Gm-Message-State: AOJu0YzwguHG0ku+foNmMiEt/9KNRoYUJohB5eDvRIJF2ST8lJMj6Iur C2RGAK6AGMI+lJPbII/YJ6D+O/4X2CUfsEXuoZ2ClnN2+7WfVmcRE8asysK3ZEw= X-Google-Smtp-Source: AGHT+IEcAT4U/SeoV9QZ1GoMtyBdueDaX8N8avvtZi0g2w+pf1DVcF9RtUYsg2KCjzAVQ534XzYb1w== X-Received: by 2002:a05:6512:3ca5:b0:511:87c6:3060 with SMTP id h37-20020a0565123ca500b0051187c63060mr1648595lfv.12.1707993696399; Thu, 15 Feb 2024 02:41:36 -0800 (PST) Received: from [192.168.192.135] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id t26-20020ac243ba000000b005119fdbac87sm189167lfl.289.2024.02.15.02.41.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 02:41:35 -0800 (PST) Message-ID: <20ab318e-e79f-419e-b68b-85ae0e5ab128@linaro.org> Date: Thu, 15 Feb 2024 11:41:32 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel Content-Language: en-US To: neil.armstrong@linaro.org, Luca Weiss , Linus Walleij Cc: Jessica Zhang , Sam Ravnborg , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Andy Gross , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20240110-fp4-panel-v2-0-8ad11174f65b@fairphone.com> <20240110-fp4-panel-v2-2-8ad11174f65b@fairphone.com> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 14.02.2024 10:50, neil.armstrong@linaro.org wrote: > On 14/02/2024 10:33, Luca Weiss wrote: >> On Mon Jan 22, 2024 at 12:27 PM CET, Luca Weiss wrote: >>> On Fri Jan 12, 2024 at 11:26 AM CET,  wrote: >>>> On 12/01/2024 11:23, Linus Walleij wrote: >>>>> On Fri, Jan 12, 2024 at 10:52 AM Luca Weiss wrote: >>>>> >>>>>> Since there's zero indication Truly is involved in this panel in my >>>>>> documentation - much less the number 5P65 - I'm not going to add that. >>>> >>>> Ack >>>> >>>>> >>>>> OK then, I fold, thanks for looking into it. >>>>> Keep the Himax hx83112a file name and symbols. >>>>> >>>>>> So in short this panel is the model 9A-3R063-1102B from DJN, which uses >>>>>> a Himax HX83112A driver IC. >>>>> >>>>> So compatible = "djn,9a-3r063-1102b" since the setup sequences for >>>>> hx83112a are clearly for this one display? >>>> >>>> Yep let's settle on that! >>> >> >> Hi Neil and Linus, >> >> Any feedback about the below question? >> >> Regards >> Luca >> >>> It's clear to me to use "djn,9a-3r063-1102b" in the driver now but what >>> about dts? >>> >>> Currently here in v2 we have this: >>> compatible = "fairphone,fp4-hx83112a-djn", "himax,hx83112a"; >>> >>> Should this just become this? >>> compatible = "djn,9a-3r063-1102b"; >>> >>> Or e.g. this? >>> compatible = "djn,9a-3r063-1102b", "himax,hx83112a"; >>> >>> Or something else completely? Do we have some documentation / best >>> practises around this maybe? > > Sorry I totally missed the question. > > Not sure if "himax,hx83112a" is needed here, the "djn,9a-3r063-1102b" is enough to know the IC is hx83112a. > > I don't think you'll ever find a "djn,9a-3r063-1102b" with another controller IC ? > > And "himax,hx83112a" alone as fallback is not enough to describe the panel hardware, so I think it should be dropped. +1 Konrad