Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
	tingguo.cheng@oss.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Update regulator settings
Date: Wed, 8 Oct 2025 14:44:58 +0200	[thread overview]
Message-ID: <20cb3921-1344-4e47-864e-ea99759a1dad@oss.qualcomm.com> (raw)
In-Reply-To: <20250919-b4-rb3gen2-update-regulator-v1-1-1ea9e70d01cb@oss.qualcomm.com>

On 9/19/25 12:39 PM, Rakesh Kota wrote:
> Update min/max voltage settings for regulators below to align
> with the HW specification
> vreg_l3b_0p504
> vreg_l6b_1p2
> vreg_l11b_1p504
> vreg_l14b_1p08
> vreg_l16b_1p1
> vreg_l17b_1p7
> vreg_s1c_2p19
> vreg_l8c_1p62
> vreg_l9c_2p96
> vreg_l12c_1p65.

You should rename the regulators that have now changed their
ranges.. I'm a big fan of stripping the voltage suffix entirely
fwiw

[...]

>  		vreg_l9c_2p96: ldo9 {
>  			regulator-name = "vreg_l9c_2p96";
>  			regulator-min-microvolt = <2700000>;
> -			regulator-max-microvolt = <35440000>;
> +			regulator-max-microvolt = <3544000>;

This change is funny, no one noticed that before..

Konrad

  reply	other threads:[~2025-10-08 12:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19 10:39 [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Update regulator settings Rakesh Kota
2025-10-08 12:44 ` Konrad Dybcio [this message]
2025-10-08 12:59   ` Dmitry Baryshkov
2025-10-27 22:37 ` Bjorn Andersson
  -- strict thread matches above, loose matches on Subject: below --
2025-09-19  9:07 Rakesh Kota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20cb3921-1344-4e47-864e-ea99759a1dad@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rakesh.kota@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=tingguo.cheng@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox