From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC 05/21] drm/omap: Remove FB_KMS_HELPER and FB related config options Date: Sat, 01 Aug 2015 13:02:05 +0300 Message-ID: <2190055.OdQA4o6Iei@avalon> References: <1436769848-4990-1-git-send-email-architt@codeaurora.org> <1436769848-4990-6-git-send-email-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:59760 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbbHAKBZ (ORCPT ); Sat, 1 Aug 2015 06:01:25 -0400 In-Reply-To: <1436769848-4990-6-git-send-email-architt@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Archit Taneja Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, airlied@linux.ie, Tomi Valkeinen Hi Archit, Thank you for the patch. On Monday 13 July 2015 12:13:52 Archit Taneja wrote: > Remove FB_* config options since the driver doesn't call any fbdev > functions directly. > > Remove FB_KMS_HELPER as this would now be selected by the top level > FBDEV_EMULATION config option. If the fbdev emulation isn't selected, > the drm_fb_helper functions will be stubbed out. > > Cc: Tomi Valkeinen > Cc: Laurent Pinchart > > Signed-off-by: Archit Taneja I like that, one step closer to removing fbdev altogether (even if there are many steps left) :-) Acked-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/Kconfig | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/Kconfig > b/drivers/gpu/drm/omapdrm/Kconfig index 6c220cd..340ece7 100644 > --- a/drivers/gpu/drm/omapdrm/Kconfig > +++ b/drivers/gpu/drm/omapdrm/Kconfig > @@ -5,11 +5,6 @@ config DRM_OMAP > depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM > depends on OMAP2_DSS > select DRM_KMS_HELPER > - select DRM_KMS_FB_HELPER > - select FB_SYS_FILLRECT > - select FB_SYS_COPYAREA > - select FB_SYS_IMAGEBLIT > - select FB_SYS_FOPS > default n > help > DRM display driver for OMAP2/3/4 based boards. -- Regards, Laurent Pinchart