From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94AD831A077 for ; Fri, 7 Nov 2025 10:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512600; cv=none; b=jhbh0WNPjed8lGbgDhe2tKqhrGgMZTr/hmwAqbPHWHf0vpB8mkfpGKnOT53lleStvYuC9qQsgX5IUIMZu90XLqfZxROkpXEBWe4UpofA/50++1rohyOCl8wCK75Qn56Tb3hlx6WdBQ/pwB5uksxByqhERdRx4dB/2r9Xj12XwLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512600; c=relaxed/simple; bh=k6CWVoo79rJIhFxcP1Zi6lbWRJyVheMfi9XXd+LkGTU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZvnEGE2XnL9d/inR1bIq528MJSthDNSNWTgTSXlkfUPIt7MDGVR7PnjQCG+1yQW8v82YquIE/2GXqC5j6f6rthrhK3RqauN3R+6n2EXdKrLeAcxKTsmPVEeZZlTYbVpqOjAFE2Etp8Uk6WfuqOKH1AZhJ5BGOmpX5KiBiuWXxjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j19zi5vc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aVpK38KF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j19zi5vc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aVpK38KF" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A757e0u2273380 for ; Fri, 7 Nov 2025 10:49:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=j19zi5vcZvZc+J3h eil5EXgb7o+MHafKBi9Slf1MAsHwht9ShJKuhVBN4IuNbfkFvOasu8HUs+laic1i ApQFCQDDkr0nR1Z4s/mFsEJRFNaTWW7B62zkTCNyqa8FVCGzmDgnRi4aJaWpx3yo 7YBrhqEKVuWBhNuAaoE60NFeKFuxZH+p+rn0tyDvgwMCTDDPUaOdyqcmIN20Yni7 e+FAQn327eA/EMJkdOZ1oKcI5NWQiBeaIRCP9KmnXRYAWj3UM/IlF2kolv1vNI8Y 9Rr7K9olNJaawFxFkksQTdDzKZOepplYR1QpfkBYS3jwKcxtOTKS7ODirqnsgtuo rorS0A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a9abmrytb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Nov 2025 10:49:57 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b22253132cso21447085a.3 for ; Fri, 07 Nov 2025 02:49:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762512597; x=1763117397; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=aVpK38KFUkFW6kHSwtDvmqmr+IpLTyoG+3Gj2IH6kwa7KJ9sRechIttPb6jEiqRkIT shiAQol5uzyZL7OUgnKhrLYoTq3W8g+FmNJbcRgmFmtueqEFfXqKIkbSdm79N+EIESeI aF+3ys97Ay+qY41i5G/AJleovoe3ssLGjj3GCoyw+2fE9EiRwzWu9P6n2/XX4K/FXjED qsJBWCUkM/9u6u8IC4/xzcXdaxlS43MobCRNrBQD58R2Sf8BOZLdDCMqwfNQF/EeLQJB 5EZ9ecmojBYR+VkpotxpmrkAps9jZPwIdB5DOTLaN0M9TgkFTXgSrepDr+q0gJ9yWJMy KY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762512597; x=1763117397; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=wzilysOBs8/YhyVw9pd+0LoODDfSlE61c0iwrYjCNJgdWrHXfN+pgF2kmvtRcNWSul cm9fWrdpibXIqLL5XagQs2qw6fGGnTEusHiMGLkUfeGanh7R9BsGNSqE5/MdBieb51Ft yM5CO7loLDxsdb5lPMCTJUVqx9Ya+Y3xz8E0L7tQtivRDv6bl7L9YDMGLzHsFGfVNt8d rL63rOquk7WIVsRIesYp/7kzvEQ27SKjyOfYYOL0sg2iTGWUoZe425J2C6bAMsEQPNh9 mKTInpw0aqUKTRumfvStxUHIybNziHn41DTIL4uUQ1NUaxOoUL/JlfaLalivkjoQ0GWK 7KJw== X-Gm-Message-State: AOJu0YwiZpGCtyX9K4Q2HSUex1WH5WtHwn24vJf+e6wVzrFnQAGg0CJw hDOZK6nZF/LVB93jqGyYc8S/QJdiXYf1wsGz+AYucgFx97dqU6Rg//PjmAaORyVKsS0HSqWtzMy /c/tVlxEKMGko3waVZlaLe6F2YunpiUrxhAAIJwWKGZeGS1pyN7a53Lhjo/ZLbswoEUja X-Gm-Gg: ASbGnctu93kzt/op9kPASlrBE4cZCQWShHqWWIYfIuZEJBYP/BpMoVovxJN7ADzEa5I xkaPHwj0gzOqzPmFmqYjv0wzF301UTcDYqYKJUr2gr6Oicr0dtuEc/FQbph5kqk7nQbmGgMFcNI 41hE6lf53OnaAY7/EI08gj1KUPbr5+H/hNAnBf8jvOen3CGlFG2b1laxbvEG9VRa/7f3eu6+qpP 6UwE8pFBMRRGjnoWY/LsgKHJC88soycgkr61dPJ7ON5wyz3W9wHoptQEcfBDxjb+BV/KB/dAqCN FGxV/38VgNV7m9Oo4TFwxYLXT2YmgWtLey4Uac1ktPkKq9KvWNeo5aeJWgC5DGB5hR8NMSs89i2 FFYClkIgTaYcDQDRj6ee1d19Vx1NVWvmuFtKpTFjUH/2FbjktRqxfPfr4 X-Received: by 2002:ac8:5a51:0:b0:4e8:966b:459b with SMTP id d75a77b69052e-4ed949bb0f9mr18063431cf.5.1762512596833; Fri, 07 Nov 2025 02:49:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFb3Xbou/G0Zzd63eLA+eutWoqm0V75Q2RL/wdtW4sHDSzQGKhPaQSn2W6oLQojU83FQkCi9A== X-Received: by 2002:ac8:5a51:0:b0:4e8:966b:459b with SMTP id d75a77b69052e-4ed949bb0f9mr18062921cf.5.1762512596362; Fri, 07 Nov 2025 02:49:56 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf9bc2fcsm204678566b.50.2025.11.07.02.49.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 02:49:55 -0800 (PST) Message-ID: <21a3d269-76e6-4da9-aa25-bfd1fb6dfb07@oss.qualcomm.com> Date: Fri, 7 Nov 2025 11:49:48 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/8] net: stmmac: qcom-ethqos: use generic device properties To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski References: <20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org> <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: xgBMHMoBcP6ZLTGLLhGk3_o1xqJqlzXj X-Proofpoint-ORIG-GUID: xgBMHMoBcP6ZLTGLLhGk3_o1xqJqlzXj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA3MDA4NyBTYWx0ZWRfX7wmHKmwT2wi1 QQhHkDykrf8AM5avkVO33SQjYQc00Wx25+wXmoy8lOLWIkAqG+g6yEq4zQKScgSOR8kn5dLb4Hq Izp8NtqiTeXxX1ZK0kyHy8yL4fUHZZ6qAsvfXHWjAnbhf0riUSJRo1CK/GxKnm8O/jmF21q0dkl edkNhR1GP6fbpImGdbDCdQEuwia+QatKC4f4Y6nY+cSLshOO9H/NwwoxK6IySaPfnkXKWMicMA5 fYWb9/0RCbC2ghhFiYIgsupDjuq8O2Gb42zQGCOFx1MuDGfiOLnawD7hy+GoTgcWATwU2BSM4Mw mn3BOQXpxUEsW9PsYNdQ1dsVtz7FBVsL3EmVKulNdOalHc6C409NCiZn+G8dQF2TbrbpwFJroxD rd1VzOfOt/vNVUepIO35ZvOv63RvSQ== X-Authority-Analysis: v=2.4 cv=HPjO14tv c=1 sm=1 tr=0 ts=690dced5 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=xTS94RJRWet4TjKJq7QA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-07_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511070087 On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > In order to drop the dependency on CONFIG_OF, convert all device property > getters from OF-specific to generic device properties and stop pulling > in any linux/of.h symbols. > > Signed-off-by: Bartosz Golaszewski > --- [...] > - if (of_property_read_bool(np, "snps,tso")) > + if (device_property_present(dev, "snps,tso")) This is a change in behavior - "snps,tso = <0>" would have previously returned false, it now returns true although it seems like it's the plat driver clunkily working around not including the common compatible and inlining parts of the common probe functions.. Konrad