From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B0BD14A0AD for ; Wed, 10 Jul 2024 23:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.89.44.39 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720653523; cv=none; b=PIQMKz3ylqdeWyLYdl+IniNSPkcZUQtC3/YSbalFVfWZiZksnNdudfSeCgVOrL0wpux4fEcppl+fEwjd5LBzqLIPRjBM3o99UwdhjMUk3OOAdr/7Ftd49vFosMrHI8dxzTsfAiFF3rBVT2NevDJBE4p/yWo1936+U0styvXDzFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720653523; c=relaxed/simple; bh=/Z3LhZV9FBdTa0nv078PPSOZZz1Eynyr/1qLnzPpDH4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dj9dQf7n9vNVUiiQogpE9MSsp/DbkmMnYBcb7tYSMRurZfDcYZRk9p4LZi0jSmtKvxy3DVtVTo5wlnYWX0nCiixyISoPdyvy4QD5EONnj/k+Boimr5nUYPHMLb9H0Qv1r4ULSAy7K9VPL54Qtcxgf6Dj8DyTBB/b7t42aoBacCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=Yey7/kAu; arc=none smtp.client-ip=35.89.44.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="Yey7/kAu" Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id RcXKsciHCvH7lRgYcsFoNI; Wed, 10 Jul 2024 23:17:06 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id RgYbsHsjUeCxMRgYbs8Okh; Wed, 10 Jul 2024 23:17:05 +0000 X-Authority-Analysis: v=2.4 cv=M/yGKDws c=1 sm=1 tr=0 ts=668f1671 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=frY+GlAHrI6frpeK1MvySw==:17 a=IkcTkHD0fZMA:10 a=4kmOji7k6h8A:10 a=wYkD_t78qR0A:10 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=twV4k4tpM6jbvoAuFuAA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kMfEEDYKHMIokzjHcMS3uX5TREDWKTeMbnyO8Tlp8ZQ=; b=Yey7/kAuGkQWaUkXdzhvE7MtbZ Fka+U097WBwjTUiHBRvkS59k3pur9fzY9FFUlCRPABTGH+bzL+WvfkesEIPKKG9qW2Mrcrt/3UKym lLz7nONovpggW4DRyTPjijfclbmwWoHFwgfPbCZsQ2COIDoF3jePJKC766jLAtGVsILezxjq3/XCV xI25a0KqoFVGfL2NFar7pbc/Xk0VTG77NNJg1h1hWJqYvpLUbL7r8qSiT+l+qUfmje4n5MWMi4CcQ wZ5tICMMdXUSIBGOFyfy3mtjBK5q7WvbkMgmmFO+Sg6Udb24FLQgwhV0H6A72zfOnReKdHtlsfOY0 m5d9xXNA==; Received: from [201.172.173.139] (port=39968 helo=[192.168.15.4]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1sRgYa-004DUh-1x; Wed, 10 Jul 2024 18:17:04 -0500 Message-ID: <21e3d039-a447-4779-b751-4cbf9a4e7584@embeddedor.com> Date: Wed, 10 Jul 2024 17:17:03 -0600 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: venus: hfi_cmds: struct hfi_session_release_buffer_pkt: Add __counted_by annotation To: Kees Cook , Stanimir Varbanov Cc: Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab , "Gustavo A. R. Silva" , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240710230728.work.977-kees@kernel.org> <20240710230914.3156277-2-kees@kernel.org> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: <20240710230914.3156277-2-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 201.172.173.139 X-Source-L: No X-Exim-ID: 1sRgYa-004DUh-1x X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.15.4]) [201.172.173.139]:39968 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 13 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGvJk/moER3PNcjkFgq0Rx0z5x/n4c/QlRnuRgwth31V5vKFgeON9iFTonB/lU8GxOTtZvxWId7O4RGmaSHs5gOOqB4bCM1DTjO4DDhc6coyi0Rfmy4b rVQgnauyWztiwj06LcDG8klDVYxtzGbJ2InESN8KIl/dc9kz6zmYWzJ8f+r876Yk18xSb276rGMN/7cSljWybxBIcYYDCtwCSleWlvoISi+fXxfG23muMjbR On 10/07/24 17:09, Kees Cook wrote: > The only direct user of struct hfi_session_release_buffer_pkt is > pkt_session_unset_buffers() which sets "num_buffers" before using it > as a loop counter for accessing "buffer_info". Add the __counted_by > annotation to reflect the relationship. > > Signed-off-by: Kees Cook > --- > Cc: Stanimir Varbanov > Cc: Vikash Garodia > Cc: "Bryan O'Donoghue" > Cc: Mauro Carvalho Chehab > Cc: "Gustavo A. R. Silva" > Cc: linux-media@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-hardening@vger.kernel.org Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h > index 42825f07939d..1adf2d2ae5f2 100644 > --- a/drivers/media/platform/qcom/venus/hfi_cmds.h > +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h > @@ -227,7 +227,7 @@ struct hfi_session_release_buffer_pkt { > u32 extradata_size; > u32 response_req; > u32 num_buffers; > - u32 buffer_info[]; > + u32 buffer_info[] __counted_by(num_buffers); > }; > > struct hfi_session_release_resources_pkt {