From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 408FC32ED2F; Thu, 13 Nov 2025 08:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763021453; cv=none; b=NRRrv0ay+TRKkLeo8t14UShtZ8xYrPuoD+SpTKNppdxDRKGkjeoL+pM43LCao6AZBuKG1QyPKFWx3bafJFLTAOj23oYv9lv8R5uRS50zn7kf6bd+L45RSZ4MHfQDH7S1+9H6vJVT5oJBaaEs0gSpsoNJABv5J/5PA0e+mirmbiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763021453; c=relaxed/simple; bh=WzKoEocAJC7FdMdHE7Dt75drpTyNfmdl94td2jReVY8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rz9IRWszewLSd+5u7+lOCYT7kD/s9xLmTwXfvyxTctiXw8mcYdGz8xVVERSixlQ/y3S5mBhWV3OZPCH/AxYZdalLjOmTwZdDs0I8QYQNcjpV0K2JeaJR4FBhMXhy3Y4nhOsV+KLDezXe4cy22W/DFWl2ep/LS9KqiXmMDwnZB/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=CUWyeqgs; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="CUWyeqgs" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id BD24FC0F56D; Thu, 13 Nov 2025 08:10:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 662B86068C; Thu, 13 Nov 2025 08:10:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 49ABA102F1BFF; Thu, 13 Nov 2025 09:10:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763021447; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=M3+aKTOIenGftNdk1yVOu9tIQlDGr8NCbK8NJ7Ofmko=; b=CUWyeqgsbpmiskIh05Y3xODwBRnwBI2KZgH/KPNlL96QAoCGCVcwTsZwUqVi/wtaFeyEVn tkEZ3JlJpZOc5Ia9T4BQXDE6JSt4mx9YW5PP8nCFLlvYQzOwEgrx2Ni304blYKBuJUTL5b kXPR07CiaeUNrab2aazgJdRkSD4BEHcQYdETyI1KmQM/ZY0BpL+UcK6IWDzDjG/stqPo8N emV5Oy7+nvmZAS6QDaMwRtU/nLUWWoKctyJcIQtFpfEc9gLVmdp8XPd/OBBZsm6PUg6Tlt JWkr9DkjPzdbvsxxyKz0nCTGBtYnlVu96ZGFm7EpVAcI1sPUsPck/Fp1bw0HGg== Message-ID: <21e8408a-027a-4e74-899e-8ec59ddb17ef@bootlin.com> Date: Thu, 13 Nov 2025 09:10:37 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v15 01/15] dt-bindings: net: Introduce the ethernet-connector description To: Andrew Lunn Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com, Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Antoine Tenart , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Romain Gantois , Daniel Golle , Dimitri Fedrau References: <20251106094742.2104099-1-maxime.chevallier@bootlin.com> <20251106094742.2104099-2-maxime.chevallier@bootlin.com> <56410c74-3d0e-4cdc-87a0-230cad8f691a@lunn.ch> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <56410c74-3d0e-4cdc-87a0-230cad8f691a@lunn.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Andrew, On 11/11/2025 04:34, Andrew Lunn wrote: > On Thu, Nov 06, 2025 at 10:47:26AM +0100, Maxime Chevallier wrote: >> The ability to describe the physical ports of Ethernet devices is useful >> to describe multi-port devices, as well as to remove any ambiguity with >> regard to the nature of the port. >> >> Moreover, describing ports allows for a better description of features >> that are tied to connectors, such as PoE through the PSE-PD devices. >> >> Introduce a binding to allow describing the ports, for now with 2 >> attributes : >> >> - The number of lanes, which is a quite generic property that allows >> differentating between multiple similar technologies such as BaseT1 >> and "regular" BaseT (which usually means BaseT4). > > You still use lanes here, but the implementation has moved on to > pairs. > > Please add my Reviewed-by when you fix this. I'm about to send v16, but I have also taken Rob's comments into account so I'm going to err on the safe side and not include your review tag, in case I mess this up :( again, thanks a lot for the round of reviews on v15 ! Maxime > > Andrew