Re: [PATCH 20/97] usb: dwc3-qcom: Convert to platform remove callback returning void

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 18.05.2023 01:01, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/usb/dwc3/dwc3-qcom.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 959fc925ca7c..167f851c8e59 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -938,7 +938,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int dwc3_qcom_remove(struct platform_device *pdev)
> +static void dwc3_qcom_remove(struct platform_device *pdev)
>  {
>  	struct dwc3_qcom *qcom = platform_get_drvdata(pdev);
>  	struct device *dev = &pdev->dev;
> @@ -958,8 +958,6 @@ static int dwc3_qcom_remove(struct platform_device *pdev)
>  
>  	pm_runtime_allow(dev);
>  	pm_runtime_disable(dev);
> -
> -	return 0;
>  }
>  
>  static int __maybe_unused dwc3_qcom_pm_suspend(struct device *dev)
> @@ -1052,7 +1050,7 @@ MODULE_DEVICE_TABLE(acpi, dwc3_qcom_acpi_match);
>  
>  static struct platform_driver dwc3_qcom_driver = {
>  	.probe		= dwc3_qcom_probe,
> -	.remove		= dwc3_qcom_remove,
> +	.remove_new	= dwc3_qcom_remove,
>  	.driver		= {
>  		.name	= "dwc3-qcom",
>  		.pm	= &dwc3_qcom_dev_pm_ops,