From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] ASoC: dt-bindings: qcom,sm8250: Add Dell XPS13 9345 sound card
Date: Wed, 22 Oct 2025 12:56:31 +0200 [thread overview]
Message-ID: <224288d8-9a04-4a76-95c7-c0af4ed967e3@kernel.org> (raw)
In-Reply-To: <20251021-dell-xps13-9345-enable-audio-v1-1-6f3f6bbd977b@linaro.org>
On 21/10/2025 15:50, Abel Vesa wrote:
> The Dell XPS13 9345 maps the speakers and tweeters starting from
> the right side instead of left, which means we need to handle it
> differently then the rest of the X Elite platforms.
>
> So document its new compatible.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> index 868acc077046596120ea7f427e802282ed03c853..20566224d2e42574ab96f93c11924bbeae22f0bc 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> @@ -29,6 +29,7 @@ properties:
> - qcom,sm8750-sndcard
> - const: qcom,sm8450-sndcard
> - enum:
> + - dell,xps13-9345-sndcard
When I explained you how to proceed, I said - you need front compatible,
because this sound card is compatible with existing one, with a quirk
needed.
Might not matter if we go with mixers solution as suggested by Srini.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-22 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 13:50 [PATCH RFC 0/3] ASoC: qcom: x1e80100: Add sound card support for Dell XPS13 9345 Abel Vesa
2025-10-21 13:50 ` [PATCH RFC 1/3] ASoC: dt-bindings: qcom,sm8250: Add Dell XPS13 9345 sound card Abel Vesa
2025-10-22 10:56 ` Krzysztof Kozlowski [this message]
2025-10-21 13:50 ` [PATCH RFC 2/3] ASoC: qcom: x1e80100: Add Dell XPS13 9345 support Abel Vesa
2025-10-22 10:34 ` Dmitry Baryshkov
2025-10-21 13:50 ` [PATCH RFC 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345: Add Left/Right Speakers and Tweeter Abel Vesa
2025-10-22 16:28 ` Konrad Dybcio
2025-10-22 17:04 ` Alexey Klimov
2025-10-21 20:21 ` [PATCH RFC 0/3] ASoC: qcom: x1e80100: Add sound card support for Dell XPS13 9345 Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224288d8-9a04-4a76-95c7-c0af4ed967e3@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox