From: Luca Weiss <luca@lucaweiss.eu>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] remoteproc: qcom_q6v5_pas: Use resource with CX PD for MSM8974
Date: Sun, 6 Jul 2025 10:31:38 +0200 [thread overview]
Message-ID: <226fd16c-8071-43c7-9ecc-9bd95e319aaf@lucaweiss.eu> (raw)
In-Reply-To: <hwewzj4ygfbb22vxrahjfc3b4oxyagh3nkd26bs3p5k2fcxr6m@mkgtyjkxz3d7>
On 05-07-2025 10:57 p.m., Dmitry Baryshkov wrote:
> On Sat, Jun 21, 2025 at 03:19:57PM +0200, Luca Weiss wrote:
>> MSM8974 requires the CX power domain, so use the msm8996_adsp_resource
>> which has cx under proxy_pd_names and is otherwise equivalent.
>>
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> ---
>> drivers/remoteproc/qcom_q6v5_pas.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hmm. You are modifying the ADSP configuration in the driver, but at the
> same time you've dropped CX supply from the MSS remoteproc.
The qcom_q6v5_mss driver has this support for .fallback_proxy_supply,
which are used in case the power domain is not specified.
So no driver change is necessary in the mss driver for both old and new
devicetrees, but the adsp driver does not have this fallback, so that's
why the adsp config is updated.
Does that make it clear?
Regards
Luca
next prev parent reply other threads:[~2025-07-06 8:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 13:19 [PATCH 0/4] Start using rpmpd for power domains on MSM8974 Luca Weiss
2025-06-21 13:19 ` [PATCH 1/4] dt-bindings: remoteproc: qcom,adsp: Make msm8974 use CX as power domain Luca Weiss
2025-06-21 13:19 ` [PATCH 2/4] remoteproc: qcom_q6v5_pas: Use resource with CX PD for MSM8974 Luca Weiss
2025-07-05 20:57 ` Dmitry Baryshkov
2025-07-06 8:31 ` Luca Weiss [this message]
2025-07-06 10:08 ` Dmitry Baryshkov
2025-07-06 12:32 ` Luca Weiss
2025-07-06 13:17 ` Dmitry Baryshkov
2025-07-06 15:35 ` Luca Weiss
2025-06-21 13:19 ` [PATCH 3/4] ARM: dts: qcom: msm8974: Sort header includes alphabetically Luca Weiss
2025-06-21 13:31 ` Konrad Dybcio
2025-06-21 13:19 ` [PATCH 4/4] ARM: dts: qcom: msm8974: Start using rpmpd for power domains Luca Weiss
2025-06-23 12:39 ` Konrad Dybcio
2025-06-23 16:44 ` Luca Weiss
2025-06-24 13:25 ` Konrad Dybcio
2025-06-24 0:59 ` [PATCH 0/4] Start using rpmpd for power domains on MSM8974 Dmitry Baryshkov
2025-06-24 18:46 ` Luca Weiss
2025-06-24 21:03 ` Dmitry Baryshkov
2025-07-05 14:16 ` Luca Weiss
2025-07-05 15:52 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226fd16c-8071-43c7-9ecc-9bd95e319aaf@lucaweiss.eu \
--to=luca@lucaweiss.eu \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).