From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64BF15531A for ; Fri, 22 Nov 2024 12:50:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732279861; cv=none; b=o//88+kVCjkcSCvjGhjcuAsKTWfoBBWTVEsCDQP1Nige6CPiX0crjFxUtuGYz3cYrvVy4P2218w9RWmABUEkr0+WsB5D5CaxfBLhRbfKsIGJ2RjZ098LJtmO9j+GWoj6ViJcSmjMfeoUWYjTTuP7xwFJ4r2s9+y71QdE8rOXoyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732279861; c=relaxed/simple; bh=JBHOh4rUnLADzXtOwvC84g7/JrNLMPYtlQhDKTzIkJw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gGmyTGr5AyZRQwqsOBkzr7CzjWzCcYtzaTcwz6+QnDp635/jtqyBMUmpDN8NZ6oRIc0gOFsxv2bbEYVpV1G5ga9G3GURovJ6ESZo5lGKwJ7D11v86UwRm7HFVTS0q+uDnysTmV4wlFtJZImW0THhFyigl3jIlZ1TarQ4gz23HhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=euAhNgAx; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="euAhNgAx" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-38232c6311fso1433228f8f.3 for ; Fri, 22 Nov 2024 04:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732279858; x=1732884658; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KISqflzqP4C+qpQH2POLD8D91UlEquq5DIx6lhdqv9U=; b=euAhNgAxorUVFsIASQSjJa5dVhdxz+PiPyB5faPqRuOSn+aKWBG1XSpIl/VtWkKuwE Bdw8vLDl8bK7tPpnovrsliIbLi8LnW5uodLlL6Ul+gIPrxi20foUl4G/ZRXgxjxbtsD7 7op1n9gMyGQZ6g90HwJtVnu6jY4nwcm8pwBCKDc+rjqtMWkiC2kydcTeujeEJaMfI1d3 cE5/bvgkjCBEnpRWhLXxRvIaIpqb1xBpj2606A0HQ/fdtTyjBsgvLE7FSmoopUN4Ja+M VJiE3BjevBK1/LfB4qbqdh9scSHNJgwzqRnD3RJOQY1evJ8MzW/Vj2po8Kk+FK4enI4E SyCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732279858; x=1732884658; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KISqflzqP4C+qpQH2POLD8D91UlEquq5DIx6lhdqv9U=; b=spGn/b+3E9WajbApPywhY344R7MC7UV+h7qU/aeE/27G5N0SIlWM9x48nGHeWWBbft AyCmRkDN+a/EhgMUi0VrBljtcLAJIs+eXEZRhTL2TzTK7rhXT1QRI67QFyxvKGeOv0zf UGqRME0j1YUN9kmKPlTwCBNmTlN7E34oF3mlcAQtxOdglsC95eqvodpur+kI7WIzuGD1 kvdYWN/1xwLBuALHRKVWuxzS+1frVleW16jnkpW+fQ2YlspGWGjA7FKmgBm0RbAbHBzg OTEF+lsJJ1XD8S4QbcHkmE8sduLdLnfEhExdAjFNGBq49RYv/foLNyflAZ5HNq+W5jCv kxxQ== X-Gm-Message-State: AOJu0YzLUWq17pciZ7YZEUwrE8Tvifn6LMrevwKFmBUwAmK7nSLi+3eK 5/dEL+MuHKNqyLNXFbtzwKK/Go18368jl1q50YDtrbjeSwZEvM6fn1vqynyq/CQ= X-Gm-Gg: ASbGnctizFi7A34D4+iyIU1gY3GUO/rPzcoBFbOBkGWL101YYOAGrek8XFXy8qzHz9h FS4dvpJSST73O6s7RczMc3J6u5DVk6NqsM+r7Fc1G3M7Gavz++DCbkTuWFGtdMSOfuv32IlUYBZ 3OcN6RGhFZvZdsMSqrhdO9PuLP8iU47d46XaA4oHwx66SnIzen4mfMykSnvDQ5BeH895Vl92u0w lkDNORECRD1dFp1p5bAAtvPfh6r70RuzG3x/UzN5wKKHVKpTheiOYnUYb/jYIc= X-Google-Smtp-Source: AGHT+IH8paRTgv6TgTv/fMTI/UYofpz859HmfaEoTHqkrdKZAJ6nGDUeZc0w5K8HyhUYuBIakIZLDQ== X-Received: by 2002:a05:6000:186b:b0:381:cffc:d40b with SMTP id ffacd0b85a97d-38260bcd023mr2225909f8f.39.1732279858025; Fri, 22 Nov 2024 04:50:58 -0800 (PST) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fbedf63sm2333104f8f.102.2024.11.22.04.50.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2024 04:50:57 -0800 (PST) Message-ID: <2299ec8f-4b80-48ea-96ed-d1eb40998e55@linaro.org> Date: Fri, 22 Nov 2024 12:50:56 +0000 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4 To: Renjiang Han , Bjorn Andersson , Michael Turquette , Stephen Boyd , Stanimir Varbanov , Vikash Garodia , Mauro Carvalho Chehab Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20241122-switch_gdsc_mode-v1-0-365f097ecbb0@quicinc.com> <20241122-switch_gdsc_mode-v1-2-365f097ecbb0@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20241122-switch_gdsc_mode-v1-2-365f097ecbb0@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/11/2024 10:31, Renjiang Han wrote: > - if (IS_V6(core)) > + if (IS_V6(core) || IS_V4(core)) sdm845 IS_V4() The GDSCs for the clock OTOH are static struct gdsc vcodec0_gdsc = { .gdscr = 0x874, .pd = { .name = "vcodec0_gdsc", }, .cxcs = (unsigned int []){ 0x890, 0x930 }, .cxc_count = 2, .flags = HW_CTRL | POLL_CFG_GDSCR, .pwrsts = PWRSTS_OFF_ON, }; static struct gdsc vcodec1_gdsc = { .gdscr = 0x8b4, .pd = { .name = "vcodec1_gdsc", }, .cxcs = (unsigned int []){ 0x8d0, 0x950 }, .cxc_count = 2, .flags = HW_CTRL | POLL_CFG_GDSCR, .pwrsts = PWRSTS_OFF_ON, }; I can't see how this series will work on 845. --- bod