From: Rudraksha Gupta <guptarud@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with unlock gate
Date: Wed, 18 Mar 2026 11:35:48 -0700 [thread overview]
Message-ID: <22b1b8f1-b87d-4f34-9e04-0a39758bfe15@gmail.com> (raw)
In-Reply-To: <20260307-fennec-of-nonstop-hurricane-de4f97@quoll>
On 3/7/26 07:46, Krzysztof Kozlowski wrote:
> On Fri, Mar 06, 2026 at 04:58:02PM -0800, Rudraksha Gupta wrote:
>> Some flash ICs use the same one-wire pulse-count protocol as the RT8515
>> but have only a single GPIO line for both flash and torch modes, plus an
>> optional unlock gate (e.g. a PMIC MPP) that must be driven high before
>> the chip responds to the enable GPIO.
>>
>> Make ent-gpios optional and add an unlock-gpios property to support
>> these variants. Add a oneOf constraint requiring exactly one of
>> ent-gpios or unlock-gpios. Add a binding example showing the
>> single-GPIO configuration.
>>
>> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
>> ---
>> .../devicetree/bindings/leds/richtek,rt8515.yaml | 36 +++++++++++++++++++++-
>> 1 file changed, 35 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml
>> index 0356371a6b01..820cf8c55090 100644
>> --- a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml
>> +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml
>> @@ -15,6 +15,10 @@ description: |
>> current for each mode is defined in hardware using two resistors
>> RFS and RTS.
>>
>> + This driver also supports single-GPIO flash ICs that use the same
> Drop reference to driver and explain the hardware here.
>
>> + one-wire pulse-count protocol on one line for both flash and torch.
>> + For these, only enf-gpios is required.
>> +
>> properties:
>> compatible:
>> const: richtek,rt8515
>> @@ -26,6 +30,14 @@ properties:
>> ent-gpios:
>> maxItems: 1
>> description: A connection to the 'ENT' (enable torch) pin.
>> + Optional for single-GPIO flash ICs where enf-gpios is used for
>> + both flash and torch modes.
> So what happens with ENT GPIO on such boards? How is it connected?
Hello Krzysztof,
Thanks for these comments. I have addressed these in v2
Rudraksha
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-03-18 18:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 0:58 [PATCH 0/3] Samsung Expressatt: Camera Flash Rudraksha Gupta via B4 Relay
2026-03-07 0:58 ` [PATCH 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with unlock gate Rudraksha Gupta via B4 Relay
2026-03-07 15:46 ` Krzysztof Kozlowski
2026-03-18 18:35 ` Rudraksha Gupta [this message]
2026-03-08 23:20 ` Linus Walleij
2026-03-18 18:36 ` Rudraksha Gupta
2026-03-07 0:58 ` [PATCH 2/3] leds: flash: " Rudraksha Gupta via B4 Relay
2026-03-08 23:24 ` Linus Walleij
2026-03-07 0:58 ` [PATCH 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash Rudraksha Gupta via B4 Relay
2026-03-07 8:23 ` David Heidelberg
2026-03-18 18:39 ` Rudraksha Gupta
2026-03-08 23:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b1b8f1-b87d-4f34-9e04-0a39758bfe15@gmail.com \
--to=guptarud@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox