From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 325B6284B3B for ; Fri, 27 Feb 2026 22:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229667; cv=none; b=HUJPR36tY5nxIoG7k+W96o3cPIFnBQAxfbbLO4eJYdH8y8L3OnG5WGEVSEIAEqhrFqmL1C7F06Iwzb5mubEISYst0/gXX37yuSFwith/YyKl5oiaelU11Yt+sFt80E0rTPe4748haKpDg/USCWzWq8GMeXSiFCRmqpNrMeA+/DQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229667; c=relaxed/simple; bh=mAzcRoJBasmeGlXQNqZiZH4u/NL//5nG7PikmKl8E6U=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=m7FzIXDmNLwx2qkr449BccYd2II2u8BSiGobur2pssA6XkUqRf3k6rKcaxlSFqLOh+iiauuMWd7RdyPyZLoqVIRQJ9+Pd5Lotj0Onr5C7k+ILNX5ihD7Y2bi3kFbjiir0BeUduz4R5ySbpsHdrIQBdWFdW3TZNWipMSSR7Z8L9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QN2PkoMv; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QN2PkoMv" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4398913af88so2221182f8f.2 for ; Fri, 27 Feb 2026 14:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772229664; x=1772834464; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qfcMSv/VkkX2uxiYYkJjDIlwc6S46+mM12tf1ZM4Tyg=; b=QN2PkoMvMlGWfE+Gestx6+y95fnJ3wbNZOdqTV/KUwM+iRFcg4DxfZGzK58RrSOmp8 A+TGIcFCQDukgXjgWgghnX6GCmaUe//uC6XjfFXG+0TDmgkzhUnJQ8mkeLNKkxPnXB0K AR0BGUxlD99y1t6Z1NwzW0pB8oxw1zbBJ/b2tRlHAlKNxojsKyk+am6Jfr0JZHhZGJbN DP+QPX2uSwzO49jliT80YsZiwY3ReTuypO3FOYxkasoVyOIBVpiQUMZfCg+7XyQGgkDD ZO+t54nUuGksQa9BvYK57IUzXy98tY5p3UrAfUCWd454edDNTjCkJiKvBcUfQ34pyvXa okcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772229664; x=1772834464; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qfcMSv/VkkX2uxiYYkJjDIlwc6S46+mM12tf1ZM4Tyg=; b=ZiHAjWAEWMuNLWlZds/5bR1j/VbcutqxwYXP+ljwTjOm4iZwpCXI0pK3UxZXh9dwuS ugiqcMVpr1IVIRh297GyuGsCQA36ftgSlrp8OGd4joqoNhuLetjHWkgn0CpCJWs2G81P aYwoK1We56r41zXeQnQKNo3MqmE0GWPJF/YDWMQGGe91uijniPivHfpSTQrjjM/QGDIL vS9AHg7mw+n5GIzuNAyuD70TsaCIRdvuKWkLS92AslgGCIuwfkHIwCEOSW/j67EZt8TI tSZTlaHWQTjOqnyQw34u5iWSWNCKGZHrgH6E3+tP0FsIvmpozk/aEmkKAwBSbmnunjPJ kOgA== X-Gm-Message-State: AOJu0Yww2UDNj6w4kvb3ABHKikc6YaZ46SYHcJdE45G0s1nat5Srwq7N xZKpN2QSZG0HqH6hMREWcifHdWDH3mMDOYsU70c1So6Tr9a4BXw7SnihMVNhrT+0PQI= X-Gm-Gg: ATEYQzyj2u3PhIrsXfoJ1s7LKKshv+ofKe6aYy2l06GMXYkBLY56VoUWRHlT1m9ahdO yF92VJWm00prQrr1jl4YvKK/LjXXC8OTfN1D1oo5V95+3qPBtw+PWTJD876VrFRpxd0CeI6cjPh hTowicnIAgYM6YWgIO/8taMAUsegAfLf0IUaSPPvd9GvOwX/81Egiu85rJd2640HBDXhv60zvzV FhrUwDqCZ1YMwmcwgjcLTpueyAdJabUoBOpOujrkXXCvXoyVrNFV3T0fGoGZKBUMIw2g7QABsYJ XjOTxHY0zsJqb5uyt51JQbdkydU2bpFGohuVHod7X3TP2x9I6b369aejZtKyY2z3UFfn0e0xPJJ dlbyb9WPpeHW6EvpkMcnW6Tnkbj/wsgdlNAtISmFdMivy7A28pAxPKe2KE6itdk77zKPcnF1fpx aE8JDz/nuXGsz6ooK3mnc2aX7ktYo430Tf5Msa6D89b5VkKVtop+/BCxNRm2AggdYxGDTjeN12J hIkdI/yihjx07Rk+9FQcbBU X-Received: by 2002:a05:6000:4301:b0:437:719d:a753 with SMTP id ffacd0b85a97d-4399dddb9c8mr6708195f8f.11.1772229664528; Fri, 27 Feb 2026 14:01:04 -0800 (PST) Received: from [192.168.16.154] (host86-188-11-239.range86-188.btcentralplus.com. [86.188.11.239]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c71b75dsm9137081f8f.17.2026.02.27.14.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 14:01:03 -0800 (PST) Message-ID: <233492977e4d890fa90fcbcac66bcbb918d63bcd.camel@linaro.org> Subject: Re: [PATCH v8 01/18] dt-bindings: media: qcom,x1e80100-camss: Assign correct main register bank to first address From: Christopher Obbard To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski Date: Fri, 27 Feb 2026 22:01:03 +0000 In-Reply-To: <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-1-95517393bcb2@linaro.org> References: <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-0-95517393bcb2@linaro.org> <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-1-95517393bcb2@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Bryan, On Wed, 2026-02-25 at 15:11 +0000, Bryan O'Donoghue wrote: > The first register bank should be the 'main' register bank, in this case > the CSID wrapper register is responsible for muxing PHY/TPG inputs direct= ly > to CSID or to other blocks such as the Sensor Front End. >=20 > commit f4792eeaa971 ("dt-bindings: media: qcom,x1e80100-camss: Fix isp un= it address") > assigned the address to the first register bank "csid0" whereas what we > should have done is retained the unit address and moved csid_wrapper to b= e > the first listed bank. >=20 > Signed-off-by: Bryan O'Donoghue Reviewed-by: Christopher Obbard > --- > .../devicetree/bindings/media/qcom,x1e80100-camss.yaml | 12 ++++++= ------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.= yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > index 2d1662ef522b7..9aaed897f7e0e 100644 > --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > @@ -21,12 +21,12 @@ properties: > =20 > reg-names: > items: > + - const: csid_wrapper > - const: csid0 > - const: csid1 > - const: csid2 > - const: csid_lite0 > - const: csid_lite1 > - - const: csid_wrapper > - const: csiphy0 > - const: csiphy1 > - const: csiphy2 > @@ -190,15 +190,15 @@ examples: > #address-cells =3D <2>; > #size-cells =3D <2>; > =20 > - camss: isp@acb7000 { > + camss: isp@acb6000 { > compatible =3D "qcom,x1e80100-camss"; > =20 > - reg =3D <0 0x0acb7000 0 0x2000>, > + reg =3D <0 0x0acb6000 0 0x1000>, > + <0 0x0acb7000 0 0x2000>, > <0 0x0acb9000 0 0x2000>, > <0 0x0acbb000 0 0x2000>, > <0 0x0acc6000 0 0x1000>, > <0 0x0acca000 0 0x1000>, > - <0 0x0acb6000 0 0x1000>, > <0 0x0ace4000 0 0x1000>, > <0 0x0ace6000 0 0x1000>, > <0 0x0ace8000 0 0x1000>, > @@ -211,12 +211,12 @@ examples: > <0 0x0acc7000 0 0x2000>, > <0 0x0accb000 0 0x2000>; > =20 > - reg-names =3D "csid0", > + reg-names =3D "csid_wrapper", > + "csid0", > "csid1", > "csid2", > "csid_lite0", > "csid_lite1", > - "csid_wrapper", > "csiphy0", > "csiphy1", > "csiphy2",