From: Depeng Shao <quic_depengs@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>, <rfoss@kernel.org>,
<todor.too@gmail.com>, <mchehab@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<vladimir.zapolskiy@linaro.org>
Cc: <quic_eberman@quicinc.com>, <linux-media@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>,
Yongsheng Li <quic_yon@quicinc.com>
Subject: Re: [PATCH 11/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding
Date: Fri, 6 Dec 2024 10:18:50 +0800 [thread overview]
Message-ID: <2515c9d8-0e9d-4e1e-b8ff-764b53ea3edb@quicinc.com> (raw)
In-Reply-To: <0909a2b2-089d-41f3-82e6-f0e05682ce27@linaro.org>
Hi Bryan,
On 12/6/2024 12:11 AM, Bryan O'Donoghue wrote:
> On 05/12/2024 15:55, Depeng Shao wrote:
>> + iommus = <&apps_smmu 0x800 0x20>;
>
> This iommu list looks a bit spartan.
>
> Here's what I have for X1E:
>
> https://git.codelinaro.org/bryan.odonoghue/kernel/-/
> commit/9686eaf9557c386a2525d6668da6fe24ffd518c4#5b6ff684e5292a4c0b51f6a38631777fafae7561_4749_4874
>
> Could you double check this list ?
>
Since the camss driver just support ife, so I think only ife related
iommus are needed, just like we don't add ipe,bps,jpeg related clk and
register in the dt-binding.
msm_cam_smmu_ife {
compatible = "qcom,msm-cam-smmu-cb";
iommus = <&apps_smmu 0x800 0x20>;
......
};
> ---
> bod
Thanks,
Depeng
next prev parent reply other threads:[~2024-12-06 2:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 15:55 [PATCH v5 00/16] media: qcom: camss: Add sm8550 support Depeng Shao
2024-12-05 15:55 ` [PATCH 01/16] media: qcom: camss: csiphy-3ph: Fix trivial indentation fault in defines Depeng Shao
2024-12-05 15:55 ` [PATCH 02/16] media: qcom: camss: csiphy-3ph: Remove redundant PHY init sequence control loop Depeng Shao
2024-12-05 15:55 ` [PATCH 03/16] media: qcom: camss: csiphy-3ph: Rename struct Depeng Shao
2024-12-05 15:55 ` [PATCH 04/16] media: qcom: camss: csiphy: Add an init callback to CSI PHY devices Depeng Shao
2024-12-05 15:55 ` [PATCH 05/16] media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field inside csiphy struct Depeng Shao
2024-12-05 15:55 ` [PATCH 06/16] media: qcom: camss: csiphy-3ph: Use an offset variable to find common control regs Depeng Shao
2024-12-05 15:55 ` [PATCH 07/16] media: qcom: camss: csid: Move common code into csid core Depeng Shao
2024-12-05 15:55 ` [PATCH 08/16] media: qcom: camss: csid: Make TPG optional Depeng Shao
2024-12-10 23:44 ` Vladimir Zapolskiy
2024-12-11 13:09 ` Depeng Shao
2024-12-05 15:55 ` [PATCH 09/16] media: qcom: camss: vfe: Move common code into vfe core Depeng Shao
2024-12-05 15:55 ` [PATCH 10/16] media: qcom: camss: Add callback API for RUP update and buf done Depeng Shao
2024-12-05 15:55 ` [PATCH 11/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding Depeng Shao
2024-12-05 16:11 ` Bryan O'Donoghue
2024-12-06 2:18 ` Depeng Shao [this message]
2024-12-06 10:06 ` Bryan O'Donoghue
2024-12-06 14:32 ` Depeng Shao
2024-12-05 15:55 ` [PATCH 12/16] media: qcom: camss: Add default case in vfe_src_pad_code Depeng Shao
2024-12-06 0:21 ` Bryan O'Donoghue
2024-12-06 2:20 ` Depeng Shao
2024-12-05 15:55 ` [PATCH 13/16] media: qcom: camss: Add sm8550 compatible Depeng Shao
2024-12-06 0:19 ` Bryan O'Donoghue
2024-12-05 15:55 ` [PATCH 14/16] media: qcom: camss: csiphy-3ph: Add Gen2 v2.1.2 two-phase MIPI CSI-2 DPHY support Depeng Shao
2024-12-05 16:15 ` Bryan O'Donoghue
2024-12-06 2:26 ` Depeng Shao
2024-12-05 15:55 ` [PATCH 15/16] media: qcom: camss: Add CSID 780 support for sm8550 Depeng Shao
2024-12-06 0:14 ` Bryan O'Donoghue
2024-12-06 2:31 ` Depeng Shao
2024-12-05 15:55 ` [PATCH 16/16] media: qcom: camss: Add support for VFE hardware version Titan 780 Depeng Shao
2024-12-06 0:18 ` Bryan O'Donoghue
2024-12-06 2:41 ` Depeng Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2515c9d8-0e9d-4e1e-b8ff-764b53ea3edb@quicinc.com \
--to=quic_depengs@quicinc.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=quic_yon@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox