* [PATCH 1/2] dt-bindings: add mfd/max77705 definitions
2025-08-30 22:21 [PATCH 0/2] starqltechn: fix max77705 device irqs Dzmitry Sankouski
@ 2025-08-30 22:21 ` Dzmitry Sankouski
2025-08-31 10:05 ` Dmitry Baryshkov
2025-08-30 22:21 ` [PATCH 2/2] arch: arm64: sdm845: starqltechn: fix max77705 interrupts Dzmitry Sankouski
2025-09-02 13:17 ` [PATCH 0/2] starqltechn: fix max77705 device irqs Rob Herring (Arm)
2 siblings, 1 reply; 6+ messages in thread
From: Dzmitry Sankouski @ 2025-08-30 22:21 UTC (permalink / raw)
To: Chanwoo Choi, Krzysztof Kozlowski, Lee Jones, Rob Herring,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski
Cc: linux-kernel, devicetree, linux-arm-msm, Dzmitry Sankouski
Add a dt-bindings include file for max77705 devicetree definition, define
available irq numbers.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
MAINTAINERS | 1 +
include/dt-bindings/mfd/max77705.h | 16 ++++++++++++++++
2 files changed, 17 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 020d7aa13188..82f500cf3c02 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15166,6 +15166,7 @@ F: drivers/clk/clk-max77686.c
F: drivers/extcon/extcon-max14577.c
F: drivers/extcon/extcon-max77693.c
F: drivers/rtc/rtc-max77686.c
+F: include/dt-bindings/mfd/max77705.h
F: include/linux/mfd/max14577*.h
F: include/linux/mfd/max77686*.h
F: include/linux/mfd/max77693*.h
diff --git a/include/dt-bindings/mfd/max77705.h b/include/dt-bindings/mfd/max77705.h
new file mode 100644
index 000000000000..34fcf1642e2d
--- /dev/null
+++ b/include/dt-bindings/mfd/max77705.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * DTS binding definitions used for the MAX77705 PMIC.
+ *
+ * Copyright (C) 2025 Dzmitry Sankouski <dsankouski@gmail.com>
+ */
+
+#ifndef _DT_BINDINGS_MFD_MAX77705_H
+#define _DT_BINDINGS_MFD_MAX77705_H
+
+#define MAX77705_IRQ_CHG 0
+#define MAX77705_IRQ_TOP 1
+#define MAX77705_IRQ_FG 2
+#define MAX77705_IRQ_USBC 3
+
+#endif
--
2.39.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: add mfd/max77705 definitions
2025-08-30 22:21 ` [PATCH 1/2] dt-bindings: add mfd/max77705 definitions Dzmitry Sankouski
@ 2025-08-31 10:05 ` Dmitry Baryshkov
2025-08-31 10:25 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-08-31 10:05 UTC (permalink / raw)
To: Dzmitry Sankouski
Cc: Chanwoo Choi, Krzysztof Kozlowski, Lee Jones, Rob Herring,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
linux-kernel, devicetree, linux-arm-msm
On Sun, Aug 31, 2025 at 01:21:21AM +0300, Dzmitry Sankouski wrote:
> Add a dt-bindings include file for max77705 devicetree definition, define
> available irq numbers.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> MAINTAINERS | 1 +
> include/dt-bindings/mfd/max77705.h | 16 ++++++++++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 020d7aa13188..82f500cf3c02 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15166,6 +15166,7 @@ F: drivers/clk/clk-max77686.c
> F: drivers/extcon/extcon-max14577.c
> F: drivers/extcon/extcon-max77693.c
> F: drivers/rtc/rtc-max77686.c
> +F: include/dt-bindings/mfd/max77705.h
> F: include/linux/mfd/max14577*.h
> F: include/linux/mfd/max77686*.h
> F: include/linux/mfd/max77693*.h
> diff --git a/include/dt-bindings/mfd/max77705.h b/include/dt-bindings/mfd/max77705.h
> new file mode 100644
> index 000000000000..34fcf1642e2d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/max77705.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * DTS binding definitions used for the MAX77705 PMIC.
> + *
> + * Copyright (C) 2025 Dzmitry Sankouski <dsankouski@gmail.com>
> + */
> +
> +#ifndef _DT_BINDINGS_MFD_MAX77705_H
> +#define _DT_BINDINGS_MFD_MAX77705_H
> +
> +#define MAX77705_IRQ_CHG 0
> +#define MAX77705_IRQ_TOP 1
> +#define MAX77705_IRQ_FG 2
> +#define MAX77705_IRQ_USBC 3
There is usually no need to define IRQs as bindings.
> +
> +#endif
>
> --
> 2.39.5
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: add mfd/max77705 definitions
2025-08-31 10:05 ` Dmitry Baryshkov
@ 2025-08-31 10:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-31 10:25 UTC (permalink / raw)
To: Dmitry Baryshkov, Dzmitry Sankouski
Cc: Chanwoo Choi, Lee Jones, Rob Herring, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, linux-kernel,
devicetree, linux-arm-msm
On 31/08/2025 12:05, Dmitry Baryshkov wrote:
> On Sun, Aug 31, 2025 at 01:21:21AM +0300, Dzmitry Sankouski wrote:
>> +
>> +#ifndef _DT_BINDINGS_MFD_MAX77705_H
>> +#define _DT_BINDINGS_MFD_MAX77705_H
>> +
>> +#define MAX77705_IRQ_CHG 0
>> +#define MAX77705_IRQ_TOP 1
>> +#define MAX77705_IRQ_FG 2
>> +#define MAX77705_IRQ_USBC 3
>
> There is usually no need to define IRQs as bindings.
Yeah, that's not really a binding.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arch: arm64: sdm845: starqltechn: fix max77705 interrupts
2025-08-30 22:21 [PATCH 0/2] starqltechn: fix max77705 device irqs Dzmitry Sankouski
2025-08-30 22:21 ` [PATCH 1/2] dt-bindings: add mfd/max77705 definitions Dzmitry Sankouski
@ 2025-08-30 22:21 ` Dzmitry Sankouski
2025-09-02 13:17 ` [PATCH 0/2] starqltechn: fix max77705 device irqs Rob Herring (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Dzmitry Sankouski @ 2025-08-30 22:21 UTC (permalink / raw)
To: Chanwoo Choi, Krzysztof Kozlowski, Lee Jones, Rob Herring,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski
Cc: linux-kernel, devicetree, linux-arm-msm, Dzmitry Sankouski
Since max77705 has a register, which indicates interrupt source, it acts
as an interrupt controller.
Use max77705 as an interrupt controller for charger and fuelgauge
subdevices.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 03b63b987a18..7ccab6ba7d21 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -10,6 +10,7 @@
#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/leds/common.h>
+#include <dt-bindings/mfd/max77705.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include <dt-bindings/sound/qcom,q6afe.h>
#include <dt-bindings/sound/qcom,q6asm.h>
@@ -584,14 +585,16 @@ &uart9 {
&i2c14 {
status = "okay";
- pmic@66 {
+ max77705: pmic@66 {
compatible = "maxim,max77705";
reg = <0x66>;
interrupt-parent = <&pm8998_gpios>;
interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
pinctrl-0 = <&pmic_int_default>;
pinctrl-names = "default";
#address-cells = <1>;
+ #interrupt-cells = <2>;
#size-cells = <0>;
leds {
@@ -631,8 +634,8 @@ max77705_charger: charger@69 {
reg = <0x69>;
compatible = "maxim,max77705-charger";
monitored-battery = <&battery>;
- interrupt-parent = <&pm8998_gpios>;
- interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&max77705>;
+ interrupts = <MAX77705_IRQ_CHG IRQ_TYPE_LEVEL_LOW>;
};
@@ -641,8 +644,8 @@ fuel-gauge@36 {
compatible = "maxim,max77705-battery";
power-supplies = <&max77705_charger>;
maxim,rsns-microohm = <5000>;
- interrupt-parent = <&pm8998_gpios>;
- interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&max77705>;
+ interrupts = <MAX77705_IRQ_FG IRQ_TYPE_LEVEL_LOW>;
};
};
--
2.39.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] starqltechn: fix max77705 device irqs
2025-08-30 22:21 [PATCH 0/2] starqltechn: fix max77705 device irqs Dzmitry Sankouski
2025-08-30 22:21 ` [PATCH 1/2] dt-bindings: add mfd/max77705 definitions Dzmitry Sankouski
2025-08-30 22:21 ` [PATCH 2/2] arch: arm64: sdm845: starqltechn: fix max77705 interrupts Dzmitry Sankouski
@ 2025-09-02 13:17 ` Rob Herring (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-09-02 13:17 UTC (permalink / raw)
To: Dzmitry Sankouski
Cc: linux-kernel, Conor Dooley, Chanwoo Choi, devicetree,
Krzysztof Kozlowski, Bjorn Andersson, Lee Jones, Konrad Dybcio,
Krzysztof Kozlowski, linux-arm-msm
On Sun, 31 Aug 2025 01:21:20 +0300, Dzmitry Sankouski wrote:
> For max77705 charger and fuelgauge subdevice, use max77705 interrupt
> controller.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Dzmitry Sankouski (2):
> dt-bindings: add mfd/max77705 definitions
> arch: arm64: sdm845: starqltechn: fix max77705 interrupts
>
> MAINTAINERS | 1 +
> arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 13 ++++++++-----
> include/dt-bindings/mfd/max77705.h | 16 ++++++++++++++++
> 3 files changed, 25 insertions(+), 5 deletions(-)
> ---
> base-commit: 3cace99d63192a7250461b058279a42d91075d0c
> change-id: 20250830-starqltechn-correct_max77705_nodes-1162dc2d9fe7
> prerequisite-change-id: 20250830-max77705_77976_charger_improvement-e3f417bfaa56:v1
> prerequisite-patch-id: 534eff3c30a7b998f90f7be9537ff54c7f68543b
> prerequisite-patch-id: 60362587901a812e50ab0e9a2cf25eeea769ef9c
> prerequisite-patch-id: 09e302f4c28ec741f2985f858d72627d15e197f0
> prerequisite-patch-id: 195796a157978c67980cdd3e1bacbd0ae677e3a3
> prerequisite-patch-id: efdf7936ffca1f97fc550118ae9a2a0795828f88
> prerequisite-patch-id: bc2ce3683ecab7a91fe2ca00d35798d0f4ea5f80
> prerequisite-patch-id: 2547b245dce99798d36835b1d729b21b6d1906e5
> prerequisite-patch-id: 30d3ca50e1b09abd360ddf33982223cce24c6859
> prerequisite-patch-id: deac1d76b95764903b7b6c937d7d4b43ed9f74ed
> prerequisite-change-id: 20250831-max77705-fix_interrupt_handling-0889cee6936d:v1
> prerequisite-patch-id: f2f0ada814ee906cdc40b88427650d08b89a5d1a
>
> Best regards,
> --
> Dzmitry Sankouski <dsankouski@gmail.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit 3cace99d63192a7250461b058279a42d91075d0c
Deps: looking for dependencies matching 10 patch-ids
Deps: Applying prerequisite patch: [PATCH 1/9] power: supply: max77705_charger: move active discharge setting to mfd parent
Deps: Applying prerequisite patch: [PATCH 2/9] power: supply: max77705_charger: refactoring: rename charger to chg
Deps: Applying prerequisite patch: [PATCH 3/9] power: supply: max77705_charger: use regfields for config registers
Deps: Applying prerequisite patch: [PATCH 4/9] power: supply: max77705_charger: return error when config fails
Deps: Applying prerequisite patch: [PATCH 5/9] power: supply: max77705_charger: add writable properties
Deps: Applying prerequisite patch: [PATCH 6/9] power: supply: max77705_charger: rework interrupts
Deps: Applying prerequisite patch: [PATCH 7/9] power: supply: max77705_charger: use REGMAP_IRQ_REG_LINE macro
Deps: Applying prerequisite patch: [PATCH 8/9] power: supply: max77705_charger: implement aicl feature
Deps: Applying prerequisite patch: [PATCH 9/9] power: supply: max77976_charger: fix constant current reporting
Deps: Applying prerequisite patch: [PATCH] mfd: max77705: rework interrupts
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250831-starqltechn-correct_max77705_nodes-v1-0-5f2af9d13dad@gmail.com:
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dtb: pmic@66 (maxim,max77705): '#address-cells', '#interrupt-cells', '#size-cells', 'interrupt-controller' do not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml#
^ permalink raw reply [flat|nested] 6+ messages in thread