From: Markus Elfring <Markus.Elfring@web.de>
To: Qasim Ijaz <qasdev00@gmail.com>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
David Airlie <airlied@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH] drm/msm/dpu: reorder pointer operations after sanity checks to avoid NULL deref
Date: Sun, 9 Mar 2025 11:00:15 +0100 [thread overview]
Message-ID: <25e29571-6b96-49cc-aa72-e3040fde8004@web.de> (raw)
In-Reply-To: <20250308144839.33849-1-qasdev00@gmail.com>
…
> Fix this by reordering the dereference after the sanity checks.
Another wording suggestion:
Thus move the assignment of the variable “dpu_enc” behind a null pointer check.
Would an other summary phrase be nicer?
Regards,
Markus
prev parent reply other threads:[~2025-03-09 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 14:48 [PATCH] drm/msm/dpu: reorder pointer operations after sanity checks to avoid NULL deref Qasim Ijaz
2025-03-09 8:16 ` Dmitry Baryshkov
2025-03-09 10:00 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25e29571-6b96-49cc-aa72-e3040fde8004@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=qasdev00@gmail.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox