From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function Date: Wed, 22 Nov 2017 00:08:45 -0600 Message-ID: <25ec431a-2c1b-d352-f9ef-c663864664b6@codeaurora.org> References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-31-git-send-email-okaya@codeaurora.org> <6a78596e-720a-80a2-9d96-dcc79a32f677@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6a78596e-720a-80a2-9d96-dcc79a32f677@codeaurora.org> Content-Language: en-US Sender: linux-pci-owner@vger.kernel.org To: Sinan Kaya , linux-pci@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , open list List-Id: linux-arm-msm@vger.kernel.org On 11/21/17 11:55 PM, Sinan Kaya wrote: > For places where domain number information is available, I extracted domain number > and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers. My suggestion is that you restrict your first patch set to only these patches. > The assumption at this point is for pci_get_bus_and_slot() usages to be caught > in code-review. How about this: static inline struct pci_dev * __deprecated pci_get_bus_and_slot(unsigned int bus, unsigned int devfn) { return pci_get_domain_bus_and_slot(0, bus, devfn); } -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.