From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF61E314A9F for ; Fri, 6 Feb 2026 16:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770394504; cv=none; b=EccIAxMK0dN1S+zzE3+GM1E4qZ4Tf26smWQM3kqN5s9t4wbRwEckN3+1YuKNg/fJ423BSSVE7wEIz+8E3WQzXBpIP6ReovaCa/6kSCO2uoLLm1AdVkJdQSt5pUCrx7n3SBaYj1GqOutU57QkOHrWbWFWcM3uS9Sy9ViAErg6tJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770394504; c=relaxed/simple; bh=P0NIqZQz1ZuPN1WOQdcydyvKFlAz4sQwOlQIHQk4RKc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hYLxzvy0AzWTfzu8Hq9bneCc/UoMOHbkXxTHCKYj/EfQ+8bTp2KdevbFlNEaYhbm/pd68SRPMly2KJD0acdBFA6XnGU7DbfdxqyqpybnRoZHKoo/zz6eILto9o2lKcjtXa1N/S4IzvIMMUOuvYsbAqKuNvcBpcR5vSuuh74S9ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GrrhMFas; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N0UhHRLg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GrrhMFas"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N0UhHRLg" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 616EwfoC1852685 for ; Fri, 6 Feb 2026 16:15:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dG7rCBLmsllqxE3JifHOxAivjsQ6xAQSOGv64Hb83b4=; b=GrrhMFasrk2T0PLz WhbebKjpO0TpwmZNRQ/9wQBGpJQawTwTk9On3yDfH2jyidNcPPssOMuO4mSiKphr nmTtC7SG5jg0w9dW4x6CGdugilScZcLIzQXgzcN2gI5z7rANrp5ybvN1UDesuSL0 h5tEtkn4PJm1CAa3Ra7rkZWCCha2IIQVs2G4vktexlMnbJ2DZnFavPD1OHYvWfdq sgKE+rR2q13mGhvIO/INlrRoz2DGHTszdGujoyeyVxT0xiCTieCEf+EybwILTn88 DgUCYiro4FUvREi0L3TujhVQ2qD7XH33EEGJOhchCPqUlQJg5PmSn+cxae49NJwC 5VRG8A== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5c149hr1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 16:15:02 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-81f53036ac9so1772091b3a.3 for ; Fri, 06 Feb 2026 08:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770394502; x=1770999302; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dG7rCBLmsllqxE3JifHOxAivjsQ6xAQSOGv64Hb83b4=; b=N0UhHRLgeA7+oXD0MIWiaNG3C5GxBLQzfqEk1zkzZ0tS6OJxWOYQBcJadg8qYaADVJ GplMf5zNuF8mKjR+xahujt+DxfX77jIjuEz/1mZQpejxKjEePZvvzXhbHoNktKc1Mo4n M+yVQ2+Yq0q5sHJ4YCT7PYxsbwoSgnMve/TNrOKu9+D/6uSChpmoxVDLA3H2aPVLh30X nabteSwGv52MSbbb6iuMwFdNqc5CehxYcqqFYSdUS2E5CQsScIaL8rCBnvToAXu9LL6O cHTIsJyZKW0mNfYy0ucU9QGUjdbLsuXjwSsUdCDj9vBrQzgKubskl0P4ycVSk3FwmbML 4Z6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770394502; x=1770999302; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dG7rCBLmsllqxE3JifHOxAivjsQ6xAQSOGv64Hb83b4=; b=VXHpnYPtsi7lkFsz6jc/kmIfByGu/5e98UUMjkGwG2FkrNkmV1W5KgtSq2inG1s0x1 72hVpQ49mg1nkitzPS/XbOgNhdJw+NMC0IFImAsfD0Vqg/A5Rp/NlbJq4pHBYCELxCnU F8UlvjJG+RDMMA+63v3oIxjKgPpbwolmX8HSZIM4tydrmB434fVlmQJ9NRFT3ysI9X6S alkLlnItdEtQAw6bDPzGoBFOsAIIL/TAymjtSwe/9u2HmIBJkhRyCMnRkZs14U6y4hSu GdC1GOTQvqNqn7RA6QLn7QPJ4eY9i2+SPX5Nc0WRWM41wa/2fJy1AiWNxgYjPjKgqyhU rTbg== X-Forwarded-Encrypted: i=1; AJvYcCWY+TFMdNUwW0Jj0fl/ED/h+WJFVO48E/DTg9fWkGhDuUJgaVXtYH9NmhfxVb0EP6S8LCisnPtI1gwvEENg@vger.kernel.org X-Gm-Message-State: AOJu0YwSRfGEn5kunQVPIDR+eEnlugr0gvTxxD6KCOJHnl9ue7OEmcpk ugShKLlu5YJCnbB11uyITysBi90x4lI9g/zzaKWWUHFKbGS+B6tDF+6dQiVoHKpW2VcaD+QUYM1 WMCAbB+x2MS0w28KCSbSZ7ZwX1Iu4phf9jJUhzQk+Mxu6ZQ7w5EyZmAJgoonfVc7PRuAg X-Gm-Gg: AZuq6aIOZtpXvRjDA59K9FW+StDaDUhZsCI4v2ZmwFh8hIBA7NrqG9/AWTy+fxtMlfs UN7gH18cvkowQNJD1TmWuUbZMlYAoigm1GNz2PUzhrHAOamzV8HlqltZcKH/Ew/60zG4ct3oGqT HoPj4HDNOlF/LhWMDiY3QUVYkBjOzrmbKRt3MbNQvtw7rDXQto+WpDyakxqohythAmk82Fy0fpb HZrtVBkpA/QqUZ5eOGuyb8hLS676V93syoJOCn1mPAh2E+v9TYkM4LLBN1t6zj+ht+YEZJDZ0cN HVjwQe2YwAGRcOm9LIqm8pZPyMPuU5nb/muAqqg1YYqTFSHH9jxiBGxGk/fT608g3u0C6JXGIYB vRIRP41oGlszNErNii1IVI4eGAr2O7eYZ+635cCh7KZMkyCg5A3batZGihUvnevKVP/HMCSc33S v9qmeb1SCnogN7fEFvXLCjahYTPA== X-Received: by 2002:a05:6a00:328f:b0:81f:37b2:5657 with SMTP id d2e1a72fcca58-82441623056mr2988942b3a.17.1770394501924; Fri, 06 Feb 2026 08:15:01 -0800 (PST) X-Received: by 2002:a05:6a00:328f:b0:81f:37b2:5657 with SMTP id d2e1a72fcca58-82441623056mr2988919b3a.17.1770394501445; Fri, 06 Feb 2026 08:15:01 -0800 (PST) Received: from [10.50.45.102] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824418e0234sm3321026b3a.60.2026.02.06.08.14.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 08:15:00 -0800 (PST) Message-ID: <269e511f-4e8b-4eff-b51c-6ef2ad5180fc@oss.qualcomm.com> Date: Fri, 6 Feb 2026 21:44:56 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/4] arm64: defconfig: Enable Glymur configs for boot to shell To: Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260205-upstream_v3_glymur_introduction-v7-0-849e7a9e6888@oss.qualcomm.com> <20260205-upstream_v3_glymur_introduction-v7-2-849e7a9e6888@oss.qualcomm.com> Content-Language: en-US From: Pankaj Patil In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=P5k3RyAu c=1 sm=1 tr=0 ts=69861386 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=lhv8K5t9L7V_iG4xXbQA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDExOCBTYWx0ZWRfXyNpB5TyOogRS zpsiJCPsXhX1Ju5GvpjMk0uJafU0/48Byfja3nNtXMi2YcRzCuequvxX8s9I2LXF2brN1WT8ke2 WVlDSDyltKNQoE7ulawBQ5OO/Z/m2sbr/uG/F3IUiFFn/OeE2Gsf6XfqVthamSAoJn00sUHAKNb 0esn0qYdbwgmtNBtaTNq4JnNKGwbA/qYBSdHRKOuwmCeLkqA5hGcEkYqML2IsWu3DRqUNCYEVC1 0RN9kd1Ga7kFfqNcdtarNovj7zrZCl2Ku5RlrrHfbU6tsJD2VLaW3dPEAm+AQlLpM7PhOPH4/03 wnbG/WHq7lkZig+c56cVPrLLjafzkUrjAOdaMBnNEAR2Nm6NHvptKXw8qlXEQ7jOAZKPd6HD2PJ UZXOMeNDSeL4/lqLik7chSULew9Lle6DRjJIfNBkeUouvb79uxAIwz/+r0Hnyah7AU+enAjHlas Tp8bV499o9ELrM9BQ7g== X-Proofpoint-ORIG-GUID: jPuIsosUQHRsMD5Z1ztH3yVLdu_x6nEa X-Proofpoint-GUID: jPuIsosUQHRsMD5Z1ztH3yVLdu_x6nEa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060118 On 2/5/2026 9:46 PM, Bjorn Andersson wrote: > On Thu, Feb 05, 2026 at 05:50:42PM +0530, Pankaj Patil wrote: >> The serial engine must be properly setup before kernel reaches >> "init", so UART driver and its dependencies needs to be built in. >> Enable its dependency clocks,interconnect and pinctrl as built-in >> to boot Qualcomm's dev platform - Glymur CRD board to UART console with >> rootfs on nvme storage. >> DISPCC enabled as module, used for display. >> > > I'm sorry I missed this earlier, but what are you actually saying in > this commit message? > > Subject is lacking "Qualcomm" and "boot to shell" doesn't mean anything. > > You're talking about serial engine and init, and how that relates to > UART needs to be built in. So this must be the most important part of > your patch? No, those drivers where enabled in November 2018... > > Then follows a problem statement (problem statements are good!), saying > that we're enabling the dependencies of the UART. This is good as it > allow us to reach "init" with a working /dev/console (the reason for > =y). > > But your mixing this up with "rootfs on NVMe storage", which might > follow from being able to reach "init" with working UART, but it's not > the same "problem". What I do believe relates to "rootfs on NVMe > storage" is the inclusion of GLYMUR_TCSRCC=m though? > > Surely there must be a better way to write "Qualcomm's dev platform - > Glymur CRD board"? > > DISPCC is used for display, but should your statement be read to imply > that we now have all drivers enabled for "boot to shell" on the display? > Or did you include it just because it was adjacent? > > > The content of the patch looks good, but the commit message is > incoherent and lacks answers to someone who doesn't already know why the > options are enabled in the way they are. > > > For comparison look at Jingyi's patch here: > https://lore.kernel.org/all/20251215-knp-dts-v4-2-1541bebeb89f@oss.qualcomm.com/ > > Regards, > Bjorn > Sure, I'll update the commit subject and text to: arm64: defconfig: Enable configs for Qualcomm Glymur SoC Enable pinctrl, clocks and interconnect drivers as built-in in order for serial console to be available before kernel reaches "init" on Qualcomm Glymur CRD. Additionally, booting rootfs from NVMe requires TCSRCC to be enabled as module Enable dispcc as module which is a dependency for display enablement >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Pankaj Patil >> --- >> arch/arm64/configs/defconfig | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index b67d5b1fc45b..d3ed35d3e6a4 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -647,6 +647,7 @@ CONFIG_PINCTRL_IMX91=y >> CONFIG_PINCTRL_IMX93=y >> CONFIG_PINCTRL_IMX_SCMI=y >> CONFIG_PINCTRL_MSM=y >> +CONFIG_PINCTRL_GLYMUR=y >> CONFIG_PINCTRL_IPQ5018=y >> CONFIG_PINCTRL_IPQ5332=y >> CONFIG_PINCTRL_IPQ5424=y >> @@ -1454,6 +1455,9 @@ CONFIG_COMMON_CLK_MT8192_SCP_ADSP=y >> CONFIG_COMMON_CLK_MT8192_VDECSYS=y >> CONFIG_COMMON_CLK_MT8192_VENCSYS=y >> CONFIG_COMMON_CLK_QCOM=y >> +CONFIG_CLK_GLYMUR_DISPCC=m >> +CONFIG_CLK_GLYMUR_GCC=y >> +CONFIG_CLK_GLYMUR_TCSRCC=m >> CONFIG_CLK_KAANAPALI_GCC=y >> CONFIG_CLK_KAANAPALI_TCSRCC=m >> CONFIG_CLK_X1E80100_CAMCC=m >> @@ -1846,6 +1850,7 @@ CONFIG_INTERCONNECT_IMX8MN=m >> CONFIG_INTERCONNECT_IMX8MQ=m >> CONFIG_INTERCONNECT_IMX8MP=y >> CONFIG_INTERCONNECT_QCOM=y >> +CONFIG_INTERCONNECT_QCOM_GLYMUR=y >> CONFIG_INTERCONNECT_QCOM_KAANAPALI=y >> CONFIG_INTERCONNECT_QCOM_MSM8916=m >> CONFIG_INTERCONNECT_QCOM_MSM8953=y >> >> -- >> 2.34.1 >>