From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Ryan McCann <quic_rmccann@quicinc.com>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Rob Clark <robdclark@chromium.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
quic_jesszhan@quicinc.com
Subject: Re: [PATCH v2 4/5] drm/msm/dpu: Remove redundant prefix/suffix in name of sub-blocks
Date: Wed, 5 Jul 2023 23:11:51 +0300 [thread overview]
Message-ID: <26c7e593-7635-e96c-c21f-5fd2e5285281@linaro.org> (raw)
In-Reply-To: <20230622-devcoredump_patch-v2-4-9e90a87d393f@quicinc.com>
On 05/07/2023 22:30, Ryan McCann wrote:
> For a device core dump, the registers of sub-blocks are printed under a
> title formatted as <mainBlkName_sblkName>. For example, the csc sub-block
> for an SSPP main block "sspp_0" would be printed "sspp_0_sspp_csc0". The
> title is clearly redundant due to the duplicate "sspp" and "0" that exist
> in both the mainBlkName and sblkName. To eliminate this redundancy, remove
> the secondary "sspp" and "0" that exist in the sub-block name by
> elimanting the "sspp_" prefix and the concatenation of "num" that results
> in the redundant "0" suffix. Remove num parameter altogether from relevant
> macros as a consequence of it no longer being used.
>
> Signed-off-by: Ryan McCann <quic_rmccann@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 50 +++++++++++++-------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-07-05 20:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 19:30 [PATCH v2 0/5] Add support to print sub-block registers in dpu hw catalog Ryan McCann
2023-07-05 19:30 ` [PATCH v2 1/5] drm/msm: Update dev core dump to not print backwards Ryan McCann
2023-07-05 21:44 ` Abhinav Kumar
2023-07-05 19:30 ` [PATCH v2 2/5] drm/msm/dpu: Drop unused num argument from relevant macros Ryan McCann
2023-07-05 20:11 ` Dmitry Baryshkov
2023-07-05 21:47 ` Abhinav Kumar
2023-07-05 19:30 ` [PATCH v2 3/5] drm/msm/dpu: Define names for unnamed sblks Ryan McCann
2023-07-05 20:23 ` Dmitry Baryshkov
2023-07-05 21:50 ` Abhinav Kumar
2023-07-05 19:30 ` [PATCH v2 4/5] drm/msm/dpu: Remove redundant prefix/suffix in name of sub-blocks Ryan McCann
2023-07-05 20:11 ` Dmitry Baryshkov [this message]
2023-07-05 21:51 ` Abhinav Kumar
2023-07-05 19:30 ` [PATCH v2 5/5] drm/msm/dpu: Update dev core dump to dump registers " Ryan McCann
2023-07-05 20:22 ` Dmitry Baryshkov
2023-07-05 20:39 ` Ryan McCann
2023-07-05 21:09 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26c7e593-7635-e96c-c21f-5fd2e5285281@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_rmccann@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox