From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular Date: Mon, 08 Feb 2016 11:00:27 +0100 Message-ID: <2730150.DUniNa63fK@wuerfel> References: <1454889644-27830-1-git-send-email-paul.gortmaker@windriver.com> <1454889644-27830-6-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1454889644-27830-6-git-send-email-paul.gortmaker@windriver.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Ley Foon Tan , Geert Uytterhoeven , Stanimir Varbanov , Thierry Reding , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Sunday 07 February 2016 19:00:44 Paul Gortmaker wrote: > We've exported the symbols that we know these specific drivers > will need as tristate, so now we can make the conversion from > bool to tristate w/o concern for build regressions. > > Cc: Bjorn Helgaas > Cc: Ley Foon Tan > Cc: Geert Uytterhoeven > Cc: Stanimir Varbanov > Cc: Thierry Reding > Cc: Arnd Bergmann > Cc: linux-pci@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Paul Gortmaker Looks good, but I'm not sure what happens on unload. Did you check? Until this is tested, maybe it's best to prevent module unloading? Arnd